yiguolei merged PR #43050:
URL: https://github.com/apache/doris/pull/43050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2481848211
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2481848178
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
zhiqiang- commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1843156269
##
be/src/vec/data_types/data_type_number_base.h:
##
@@ -188,12 +189,12 @@ class DataTypeNumberBase : public IDataType {
for (int row_num = 0; row_num <
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2477903544
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2477908419
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1843154790
##
be/src/vec/data_types/data_type_decimal.cpp:
##
@@ -230,7 +238,7 @@ const char* DataTypeDecimal::deserialize(const char*
buf, MutableColumnPtr* c
buf
HappenLee commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1839727120
##
be/src/vec/data_types/data_type_decimal.cpp:
##
@@ -230,7 +238,7 @@ const char* DataTypeDecimal::deserialize(const char*
buf, MutableColumnPtr* c
buf = d
HappenLee commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1839733400
##
be/src/vec/data_types/data_type_number_base.h:
##
@@ -188,12 +189,12 @@ class DataTypeNumberBase : public IDataType {
for (int row_num = 0; row_num < size
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2467141239
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2466551390
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2465010284
TeamCity be ut coverage result:
Function Coverage: 37.91% (9868/26027)
Line Coverage: 29.10% (82303/282788)
Region Coverage: 28.24% (42347/149928)
Branch Coverage: 24.8
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2464778835
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1834403810
##
be/src/vec/data_types/data_type_time_v2.cpp:
##
@@ -37,6 +37,7 @@
#include "vec/runtime/vdatetime_value.h"
namespace doris {
+#include "common/compile_chec
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2464770514
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2464767104
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2464764988
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2464754097
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhiqiang- commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1834391532
##
be/src/vec/data_types/data_type_decimal.cpp:
##
@@ -124,7 +128,8 @@ void DataTypeDecimal::to_string_batch_impl(const
ColumnPtr& column_ptr,
auto
zhiqiang- commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1834385455
##
be/src/vec/data_types/convert_field_to_type.cpp:
##
@@ -257,7 +258,8 @@ void convert_field_to_typeImpl(const Field& src, const
IDataType& type,
Jsonb
HappenLee commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1827244708
##
be/src/vec/data_types/data_type.h:
##
@@ -58,8 +59,11 @@ class Field;
using DataTypePtr = std::shared_ptr;
using DataTypes = std::vector;
constexpr auto SERIALI
HappenLee commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1827200229
##
be/src/vec/data_types/data_type_time_v2.cpp:
##
@@ -37,6 +37,7 @@
#include "vec/runtime/vdatetime_value.h"
namespace doris {
+#include "common/compile_check_be
HappenLee commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1827179839
##
be/src/vec/data_types/convert_field_to_type.cpp:
##
@@ -257,7 +258,8 @@ void convert_field_to_typeImpl(const Field& src, const
IDataType& type,
JsonbWrit
doris-robot commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2452879028
TeamCity be ut coverage result:
Function Coverage: 37.81% (9819/25967)
Line Coverage: 28.98% (81611/281578)
Region Coverage: 28.25% (42128/149152)
Branch Coverage: 24.8
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2452869114
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451912136
TeamCity be ut coverage result:
Function Coverage: 37.82% (9821/25967)
Line Coverage: 28.99% (81631/281578)
Region Coverage: 28.25% (42142/149152)
Branch Coverage: 24.8
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451770669
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451764171
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451458264
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451452372
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451451158
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451446857
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451271853
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451267298
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhiqiang- opened a new pull request, #43050:
URL: https://github.com/apache/doris/pull/43050
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Check List (For Committer)
- Test
- [
doris-robot commented on PR #43050:
URL: https://github.com/apache/doris/pull/43050#issuecomment-2451267255
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
36 matches
Mail list logo
