HappenLee commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1827179839
##########
be/src/vec/data_types/convert_field_to_type.cpp:
##########
@@ -257,7 +258,8 @@ void convert_field_to_typeImpl(const Field& src, const
IDataType& type,
JsonbWriter writer;
Field::dispatch([&writer](const auto& value) {
FieldVisitorToJsonb()(value, &writer); },
src);
- *to = JsonbField(writer.getOutput()->getBuffer(),
writer.getOutput()->getSize());
+ *to = JsonbField(writer.getOutput()->getBuffer(),
+ static_cast<UInt32>(writer.getOutput()->getSize()));
Review Comment:
why use `static_cast` not `cast_set`, `cast_set` can check overflow in DEBUG
MODE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
