HappenLee commented on code in PR #43050: URL: https://github.com/apache/doris/pull/43050#discussion_r1827244708
########## be/src/vec/data_types/data_type.h: ########## @@ -58,8 +59,11 @@ class Field; using DataTypePtr = std::shared_ptr<const IDataType>; using DataTypes = std::vector<DataTypePtr>; constexpr auto SERIALIZED_MEM_SIZE_LIMIT = 256; -inline size_t upper_int32(size_t size) { - return size_t((3 + size) / 4.0); + +template <typename T> +inline T upper_int32(T size) { Review Comment: no need inline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org