zhiqiang-hhhh commented on code in PR #43050: URL: https://github.com/apache/doris/pull/43050#discussion_r1834391532
########## be/src/vec/data_types/data_type_decimal.cpp: ########## @@ -124,7 +128,8 @@ void DataTypeDecimal<T>::to_string_batch_impl(const ColumnPtr& column_ptr, auto str = value.to_string(get_format_scale()); chars.insert(str.begin(), str.end()); } - offsets[row_num] = chars.size(); + + offsets[row_num] = static_cast<UInt32>(chars.size()); Review Comment: cast by row, so not use cast_set for performance issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org