DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2634126067
> I have worked out a possible fix #10317
will regression test #10317 and merge it together with this.
--
This is an automated message from the Apache Git Service.
To re
rp- commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2631534111
> > Just to have it noted here, I'll probably create an issue out of it. It
isn't the `cloud-install-sys-tmplt` script (maybe its usage), but the actual
problem is in:
> >
https://gi
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2631326931
> Just to have it noted here, I'll probably create an issue out of it. It
isn't the `cloud-install-sys-tmplt` script (maybe its usage), but the actual
problem is in:
>
>
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2631256542
@rp- , can you approve??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
rg9975 commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2631125728
I've reverted commit #f066100
> > > AFAIS the script already gets the sizes and writes them correctly into
the `template.properties` file, so all it would need to do is also upd
rp- commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2630991827
> > AFAIS the script already gets the sizes and writes them correctly into
the `template.properties` file, so all it would need to do is also update the
database entries too?
>
>
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2630950156
> AFAIS the script already gets the sizes and writes them correctly into the
`template.properties` file, so all it would need to do is also update the
database entries too?
rp- commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2630904666
> > > @rp- can you review the last changes.
> >
> >
> > @DaanHoogland @rg9975
> > So I dug a bit deeper and found the actual problem to be the
`cloud-install-sys-tmplt` scri
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2630844638
> > @rp- can you review the last changes.
>
> @DaanHoogland @rg9975
>
> So I dug a bit deeper and found the actual problem to be the
`cloud-install-sys-tmplt` scrip
rp- commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2630759239
> @rp- can you review the last changes.
@DaanHoogland @rg9975
So I dug a bit deeper and found the actual problem to be the
`cloud-install-sys-tmplt` script.
I use it in
rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1938950971
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -272,8 +272,17 @@ public Answer copyTemplateToPrimaryStorage(
rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1938905993
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorage(f
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2628992745
@rp- can you review the last changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rg9975 commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1937900293
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorag
rg9975 commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2624918265
@DaanHoogland I'd like to review @rp- comments today, just could not get
to it yesterday. Will provide comments/updates later today.
--
This is an automated message from the Apac
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2624769898
is there consensus growing on this or shall I move this to 4.19.3 and up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1933416600
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorage(f
rg9975 commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1932476650
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorag
rg9975 commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1932476650
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorag
rg9975 commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1932300469
##
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java:
##
@@ -183,4 +183,20 @@ default boolean volumesRequireGr
rg9975 commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1932302874
##
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##
@@ -923,6 +924,7 @@ private HostVO
getHost
rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931948031
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorage(f
DaanHoogland commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931924242
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimary
rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931917770
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorage(f
blueorangutan commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2618169708
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931654204
##
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##
@@ -923,6 +924,7 @@ private HostVO
getHostOnW
slavkap commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931681107
##
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java:
##
@@ -183,4 +183,20 @@ default boolean volumesRequireG
blueorangutan commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2618075240
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progre
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2618074114
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
DaanHoogland commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2618073749
@slavkap , @rp- can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
DaanHoogland commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1930708611
##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##
@@ -1035,9 +1035,7 @@ private void
copyTemplateToManag
rg9975 commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1930693707
##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##
@@ -1035,7 +1035,9 @@ private void
copyTemplateToManagedTemp
blueorangutan commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2596079176
[LL] Trillian Build Failed (tid-7056)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
DaanHoogland commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1918766565
##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##
@@ -1035,7 +1035,9 @@ private void
copyTemplateToManag
blueorangutan commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2596021277
[SF] Trillian Build Failed (tid-12125)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
blueorangutan commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2595123994
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2594983784
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
shwstppr commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2594978836
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
codecov[bot] commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2559288354
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10132?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
rg9975 opened a new pull request, #10132:
URL: https://github.com/apache/cloudstack/pull/10132
### Description
This PR...
This PR fixes several small issues with Fiberchannel implementation and
locally discovered issues:
1. volume disconnect timing issues
2. rescan cleanup sc
40 matches
Mail list logo
