rp- commented on PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#issuecomment-2631534111

   > > Just to have it noted here, I'll probably create an issue out of it. It 
isn't the `cloud-install-sys-tmplt` script (maybe its usage), but the actual 
problem is in:
   > > 
https://github.com/apache/cloudstack/blob/cd81398cb7176698196f72002df5d6088befbaed/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java#L1242
   > > 
   > > For pre-seeded templates, the `template_store_ref` entries get pre 
filled with 0 and never updated, which is bad I guess for most primary 
storages. Using preseeded templates and this commit will break using those 
templates, until the DB entries are fixed.
   > 
   > ok, that to me sounds like we shouldn't merge this untill we fix that as 
well.
   
   I have worked out a possible fix #10317 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to