rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931917770
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorage(final
CopyCommand cmd) {
if
(!storagePoolMgr.connectPhysicalDisk(primaryStore.getPoolType(),
primaryStore.getUuid(), path, details)) {
s_logger.warn("Failed to connect physical disk at path: "
+ path + ", in storage pool id: " + primaryStore.getUuid());
+ return new PrimaryStorageDownloadAnswer("Failed to spool
template disk at path: " + path + ", in storage pool id: " +
primaryStore.getUuid());
Review Comment:
Spun up a fresh Linstor cluster, and this here makes problems (I think
again, we had this change already discussed).
I don't know if this is only for the special first systemvm template case,
but what happens is that I get this exception:
```
com.cloud.exception.StorageUnavailableException: Resource [StoragePool:1] is
unreachable: Unable to create volume
[{"name":"ROOT-2","uuid":"1185cf31-cf58-44c9-b998-80ca3485ef6e"}] due to
[Failed to spool template disk at path: null, in storage pool id:
7a4756ae-c7b6-45fe-b8a2-04d34db421cf].
at
org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.recreateVolume(VolumeOrchestrator.java:1817)
at
org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.prepare(VolumeOrchestrator.java:1930)
...
```
I don't know why CS is trying to connect a disk with path `null`, but it is
and the Linstor driver ignores/return false in this case.
And usually in the second connect I get the correct path and everything
works out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
