rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931948031
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -274,6 +274,7 @@ public Answer copyTemplateToPrimaryStorage(final
CopyCommand cmd) {
if
(!storagePoolMgr.connectPhysicalDisk(primaryStore.getPoolType(),
primaryStore.getUuid(), path, details)) {
s_logger.warn("Failed to connect physical disk at path: "
+ path + ", in storage pool id: " + primaryStore.getUuid());
+ return new PrimaryStorageDownloadAnswer("Failed to spool
template disk at path: " + path + ", in storage pool id: " +
primaryStore.getUuid());
Review Comment:
Either we fix the `null` path attempt or can explain why it happens, but
until than we can't return a exception here otherwise this will break Linstor
primary storage only clusters and maybe other too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
