Re: Review Request: BigSwitch VNS Networking Plugin

2013-02-20 Thread Chiradeep Vittal
https://issues.apache.org/jira/browse/CLOUDSTACK-1345 On 2/1/13 10:50 AM, "Kanzhe Jiang" wrote: >I am working through a few remaining issues, but the intention is to >provide VNS support in 4.1. >Definitely file a blocker bug and I will update with resolution.

Re: Review Request: BigSwitch VNS Networking Plugin

2013-02-01 Thread Kanzhe Jiang
I am working through a few remaining issues, but the intention is to provide VNS support in 4.1. Definitely file a blocker bug and I will update with resolution. On Fri, Feb 1, 2013 at 10:33 AM, Chip Childers wrote: > On Fri, Feb 1, 2013 at 12:40 PM, Chiradeep Vittal > wrote: > > > > ---

Re: Review Request: BigSwitch VNS Networking Plugin

2013-02-01 Thread Chip Childers
On Fri, Feb 1, 2013 at 12:40 PM, Chiradeep Vittal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9131/#review16014 > --- > >

Re: Review Request: BigSwitch VNS Networking Plugin

2013-02-01 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/#review16014 --- Although this has been reviewed and applied, I do have a couple more

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-31 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/#review15991 --- committed to master with 736b236 - Prasanna Santhanam On Feb. 1, 2

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-31 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/#review15990 --- Ship it! Ship It! - Murali Reddy On Feb. 1, 2013, 1:03 a.m., Kanz

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-31 Thread Kanzhe Jiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/ --- (Updated Feb. 1, 2013, 1:03 a.m.) Review request for cloudstack. Changes -

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Kanzhe Jiang
ali > > From: Kanzhe Jiang > Date: Thursday, 31 January 2013 1:28 AM > To: Murali Reddy > Cc: "cloudstack-dev@incubator.apache.org" < > cloudstack-dev@incubator.apache.org> > Subject: Re: Review Request: BigSwitch VNS Networking Plugin > > Hi Murali, >

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Murali Reddy
tor.apache.org<mailto:cloudstack-dev@incubator.apache.org>" mailto:cloudstack-dev@incubator.apache.org>> Subject: Re: Review Request: BigSwitch VNS Networking Plugin Hi Murali, When creating network, the plugin will capture the networkUUID, tenantID, vlan and send a requ

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Rohit Yadav
Hi Kanzhe, Just go through that wiki and see other apis how annotation is used, and add/edit anything missing as well. You may want to test your apis and make sure they work. Feel free to reach out to me for any help regarding apis. Regards. On Wed, Jan 30, 2013 at 4:51 PM, Chiradeep Vittal wro

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Chiradeep Vittal
@EntityReference(FirewallRule.class) The IdentityProxy is deprecated. It looks like you have not rebased to the latest master. See this guide https://cwiki.apache.org/confluence/x/0wDFAQ On 1/30/13 4:20 PM, "Kanzhe Jiang" wrote: >Chiradeep, > >I do not see any annotation referring to the tabl

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Kanzhe Jiang
Chiradeep, I do not see any annotation referring to the table in FirewallRuleResponse.java. What am I missing here? Kanzhe On Wed, Jan 30, 2013 at 3:33 PM, Chiradeep Vittal < chiradeep.vit...@citrix.com> wrote: > Any subclass of BaseResponse. > For example, FirewallRuleResponse > > On 1/30/13 1

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Chiradeep Vittal
Any subclass of BaseResponse. For example, FirewallRuleResponse On 1/30/13 11:14 AM, "Kanzhe Jiang" wrote: >Hi Chiradeep, > >Thank you for your review comments. I resolved all but one of your >comments >and need some clarification on >"Requires an annotation referring to the table" > >Is there a

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Kanzhe Jiang
Hi Murali, When creating network, the plugin will capture the networkUUID, tenantID, vlan and send a request to the controller to create a virtual network. Controller will create an addressSpace construct to match the vlan so that all device in the addressSpace has unique mac and ip, then create a

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-30 Thread Kanzhe Jiang
Hi Chiradeep, Thank you for your review comments. I resolved all but one of your comments and need some clarification on "Requires an annotation referring to the table" Is there any example that I can refer to? Thanks, Kanzhe On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang wrote: >This is an

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-29 Thread Kanzhe Jiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/ --- (Updated Jan. 30, 2013, 4:12 a.m.) Review request for cloudstack. Changes

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-29 Thread Kanzhe Jiang
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote: > > api/src/com/cloud/api/ApiConstants.java, line 386 > > > > > > There is no reason to add your constant here. You can add it in your > > own plugin package Mov

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-29 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/#review15807 --- api/src/com/cloud/api/ApiConstants.java

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-29 Thread Kanzhe Jiang
Hi Murali and Hugo, For L2 isolation, there isn't much difference between Nicira NVP and BigSwitch VNS. Obviously, the differences are on the controllers. Nicira NVP works with OVS with Nicira extension, while BigSwitch Controller works with stock OVS and all physical OpenFlow switches. I referenc

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-29 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/#review15793 --- Hey, The patch looks pretty familiar ;-) Can you explain a bit more

Re: Review Request: BigSwitch VNS Networking Plugin

2013-01-29 Thread Murali Reddy
Kanze, Thanks for the patch. On first look patch look good, but I will do a detailed review tomorrow. Meanwhile could you help me understand how the network is provisioned/de-provisioned through the contrloller? I understand that you plan to support Vlan isolation only for 4.1, so what is the ro

Review Request: BigSwitch VNS Networking Plugin

2013-01-28 Thread Kanzhe Jiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/ --- Review request for cloudstack. Description --- This is the first patch for