Chiradeep, I do not see any annotation referring to the table in FirewallRuleResponse.java. What am I missing here?
Kanzhe On Wed, Jan 30, 2013 at 3:33 PM, Chiradeep Vittal < chiradeep.vit...@citrix.com> wrote: > Any subclass of BaseResponse. > For example, FirewallRuleResponse > > On 1/30/13 11:14 AM, "Kanzhe Jiang" <kanzhe.ji...@bigswitch.com> wrote: > > >Hi Chiradeep, > > > >Thank you for your review comments. I resolved all but one of your > >comments > >and need some clarification on > >"Requires an annotation referring to the table" > > > >Is there any example that I can refer to? > > > >Thanks, > >Kanzhe > > > >On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang > ><kanzhe.ji...@bigswitch.com>wrote: > > > >> This is an automatically generated e-mail. To reply, visit: > >> https://reviews.apache.org/r/9131/ > >> Review request for cloudstack. > >> By Kanzhe Jiang. > >> > >> *Updated Jan. 30, 2013, 4:12 a.m.* > >> Changes > >> > >> Updated patch based on review comments. > >> > >> Description > >> > >> This is the first patch for BigSwitch Network Plugin to CloudStack. The > >>patch follows the design spec that can be found at > >> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networki > >>ng+Plugin. > >> > >> Testing > >> > >> Verify the builds: mvn clean install; > >> The database can be deployed; > >> CloudStack can be launched with the plugin modules. > >> > >> JUnit tests of all api commands to a mock controller. > >> > >> > >> Diffs (updated) > >> > >> - api/src/com/cloud/api/ApiConstants.java (78a3ded) > >> - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0) > >> - build/build-cloud-plugins.xml (207ef71) > >> - build/developer.xml (fdda171) > >> - client/pom.xml (1673429) > >> - client/tomcatconf/bigswitch-vns_commands.properties.in > >>(PRE-CREATION) > >> - client/tomcatconf/components.xml.in (5957b61) > >> - cloud.spec (9f46dd6) > >> - debian/cloud-server.install (9cd1eeb) > >> - docs/en-US/Release_Notes.xml (c8cc686) > >> - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsN > >>etworkAnswer.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsN > >>etworkCommand.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsP > >>ortAnswer.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsP > >>ortCommand.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsN > >>etworkAnswer.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsN > >>etworkCommand.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsP > >>ortAnswer.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsP > >>ortCommand.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBig > >>SwitchVnsCommand.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsP > >>ortAnswer.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsP > >>ortCommand.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigS > >>witchVnsDeviceCmd.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteB > >>igSwitchVnsDeviceCmd.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBig > >>SwitchVnsDevicesCmd.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsCons > >>tants.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwit > >>chVnsDeviceResponse.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVns > >>DeviceVO.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/At > >>tachment.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Bi > >>gSwitchVnsApi.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Bi > >>gSwitchVnsApiException.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Co > >>ntrolClusterStatus.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Ne > >>twork.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Po > >>rt.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitc > >>hVnsDao.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitc > >>hVnsDaoImpl.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigS > >>witchVnsElement.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigS > >>witchVnsElementService.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwit > >>chVnsGuestNetworkGuru.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/Big > >>SwitchVnsResource.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/B > >>igSwitchApiTest.java > >> (PRE-CREATION) > >> - > >>plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/Bi > >>gSwitchVnsResourceTest.java > >> (PRE-CREATION) > >> - plugins/pom.xml (2009302) > >> - server/src/com/cloud/network/NetworkManager.java (057f473) > >> - setup/db/create-schema.sql (fff084e) > >> - tools/apidoc/gen_toc.py (eeaf2a2) > >> - tools/apidoc/pom.xml (b75ee82) > >> - wscript_configure (3b9377b) > >> > >> View Diff <https://reviews.apache.org/r/9131/diff/> > >> > > > > > > > >-- > >Kanzhe Jiang > >MTS at BigSwitch > > -- Kanzhe Jiang MTS at BigSwitch
