----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/#review15807 -----------------------------------------------------------
api/src/com/cloud/api/ApiConstants.java <https://reviews.apache.org/r/9131/#comment34029> There is no reason to add your constant here. You can add it in your own plugin package api/src/com/cloud/event/EventTypes.java <https://reviews.apache.org/r/9131/#comment34030> You can add your event types inside your own plugin api/src/com/cloud/network/Network.java <https://reviews.apache.org/r/9131/#comment34031> You can add this in your own class in your plugin api/src/com/cloud/network/PhysicalNetwork.java <https://reviews.apache.org/r/9131/#comment34032> What is this VNS method? Is the VNS an isolation technology? What is the RFC for this? build/build-cloud-plugins.xml <https://reviews.apache.org/r/9131/#comment34034> ant is not required build/developer.xml <https://reviews.apache.org/r/9131/#comment34033> ant is deprecated/unsupported so this is unnecessary plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java <https://reviews.apache.org/r/9131/#comment34035> this can be in project cloud-api/com.cloud.agent.api as it is likely to be useful to others. if not, then it should be CreateBVSNetworkAnswer plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java <https://reviews.apache.org/r/9131/#comment34037> Rename to CreateBvsNetworkCommand? plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java <https://reviews.apache.org/r/9131/#comment34038> Rename? plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java <https://reviews.apache.org/r/9131/#comment34039> Rename? plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java <https://reviews.apache.org/r/9131/#comment34041> Rename? plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java <https://reviews.apache.org/r/9131/#comment34040> Rename? plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java <https://reviews.apache.org/r/9131/#comment34043> IdentityMapper is deprecated plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java <https://reviews.apache.org/r/9131/#comment34042> IdentityMapper is deprecated with the new api refactoring plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java <https://reviews.apache.org/r/9131/#comment34044> IdentityMapper plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java <https://reviews.apache.org/r/9131/#comment34045> Requires an annotation referring to the table plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java <https://reviews.apache.org/r/9131/#comment34047> What is an attachment? File has tabs plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java <https://reviews.apache.org/r/9131/#comment34046> File has tabs instead of spaces plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java <https://reviews.apache.org/r/9131/#comment34048> These 2 are duplicated. Should be made constants? Also suggest org.apache.cloudstack instead of CloudStack plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java <https://reviews.apache.org/r/9131/#comment34051> How about a finally() { method.releaseConnection()} ? plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java <https://reviews.apache.org/r/9131/#comment34054> Name clash with CloudStack's Network. Should be BvSNetwork? File has tabs plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java <https://reviews.apache.org/r/9131/#comment34055> Name clash? plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java <https://reviews.apache.org/r/9131/#comment34057> Shouldn't need a reference to the NetworkManager. Perhaps you want NetworkModel? plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java <https://reviews.apache.org/r/9131/#comment34058> Empty? plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java <https://reviews.apache.org/r/9131/#comment34059> Should you not be destroying the network here? plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java <https://reviews.apache.org/r/9131/#comment34060> tabs. Are you sure the BVS can handle these? server/src/com/cloud/network/ExternalNetworkDeviceManager.java <https://reviews.apache.org/r/9131/#comment34061> This can be inside the plugin code - Chiradeep Vittal On Jan. 29, 2013, 5:59 a.m., Kanzhe Jiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9131/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 5:59 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > This is the first patch for BigSwitch Network Plugin to CloudStack. The patch > follows the design spec that can be found at > https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin. > > > Diffs > ----- > > api/src/com/cloud/api/ApiConstants.java 78a3ded > api/src/com/cloud/event/EventTypes.java e69e4a4 > api/src/com/cloud/network/Network.java d38f740 > api/src/com/cloud/network/PhysicalNetwork.java be4b1d0 > build/build-cloud-plugins.xml 207ef71 > build/developer.xml fdda171 > client/pom.xml 1673429 > client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION > client/tomcatconf/components.xml.in 5957b61 > cloud.spec 9f46dd6 > debian/cloud-server.install 9cd1eeb > docs/en-US/Release_Notes.xml c8cc686 > plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java > PRE-CREATION > plugins/pom.xml 2009302 > server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f > setup/db/create-schema.sql fff084e > tools/apidoc/gen_toc.py eeaf2a2 > tools/apidoc/pom.xml b75ee82 > wscript_configure 3b9377b > > Diff: https://reviews.apache.org/r/9131/diff/ > > > Testing > ------- > > Verify the builds: mvn clean install; > The database can be deployed; > CloudStack can be launched with the plugin modules. > > JUnit tests of all api commands to a mock controller. > > > Thanks, > > Kanzhe Jiang > >
