----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9131/#review15793 -----------------------------------------------------------
Hey, The patch looks pretty familiar ;-) Can you explain a bit more about the current status of this patch? What is the current implemented functionality, is this code able to create a L2 network on a bigswitch controller? Mainly i think it would be nice to include somekind of details on how to setup this plugin together with a bigswitch controller. I would like to be able to test the functionality of this patch. I have a few questions regarding the reuse of the broadcast type lswitch and the L3 functionality that is still adverstised, but i will hold off until i get a chance to test this. - Hugo Trippaers On Jan. 29, 2013, 5:59 a.m., Kanzhe Jiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9131/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2013, 5:59 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > This is the first patch for BigSwitch Network Plugin to CloudStack. The patch > follows the design spec that can be found at > https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin. > > > Diffs > ----- > > api/src/com/cloud/api/ApiConstants.java 78a3ded > api/src/com/cloud/event/EventTypes.java e69e4a4 > api/src/com/cloud/network/Network.java d38f740 > api/src/com/cloud/network/PhysicalNetwork.java be4b1d0 > build/build-cloud-plugins.xml 207ef71 > build/developer.xml fdda171 > client/pom.xml 1673429 > client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION > client/tomcatconf/components.xml.in 5957b61 > cloud.spec 9f46dd6 > debian/cloud-server.install 9cd1eeb > docs/en-US/Release_Notes.xml c8cc686 > plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortAnswer.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortCommand.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java > PRE-CREATION > > plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java > PRE-CREATION > plugins/pom.xml 2009302 > server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f > setup/db/create-schema.sql fff084e > tools/apidoc/gen_toc.py eeaf2a2 > tools/apidoc/pom.xml b75ee82 > wscript_configure 3b9377b > > Diff: https://reviews.apache.org/r/9131/diff/ > > > Testing > ------- > > Verify the builds: mvn clean install; > The database can be deployed; > CloudStack can be launched with the plugin modules. > > JUnit tests of all api commands to a mock controller. > > > Thanks, > > Kanzhe Jiang > >
