[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 557771. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https://reviews.llvm.org/D153769 Files: clang-to

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo added a comment. Thanks! Comment at: clang-tools-extra/clangd/unittests/tweaks/OrganizeImportsTests.cpp:35-41 + { + R"cpp( +#include "Te^stTU.h" +)cpp", + true, + {}}, + {"void foo(^) {}"

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 483881. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-too

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:51 Type = Type->getPointeeType(); +if (const TemplateSpecializationType *TST = +Type->getAs()) { hokein wrote: > nit: we can u

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 483882. VitaNuo added a comment. Remove unusued include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483910. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.c

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483911. VitaNuo added a comment. Add guard calls to headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeader

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:161 +TEST_F(FindHeadersTest, TargetIsArgumentExpandedFromMacroInHeader) { + llvm::Annotations MainFile(R"cpp( h

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e545816a9e5: [include-cleaner] Handle dependent type members in AST. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483926. VitaNuo marked 7 inline comments as done. VitaNuo added a comment. Address most recent review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files:

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483927. VitaNuo added a comment. Remove extra variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 483941. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-too

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81c3739156fe: [include-cleaner] Use expansion locations for macros. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141271: [include-cleaner] Filter template instantiations from AST roots.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141271 Fi

[PATCH] D141271: [include-cleaner] Filter template instantiations from AST roots.

VitaNuo updated this revision to Diff 487385. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141271/new/ https://reviews.llvm.org/D141271 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D141271: [include-cleaner] Filter template instantiations from AST roots.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:377 continue; -// FIXME: Filter out certain Obj-C and template-related decls. +if (const NamedDecl *ND = dyn_cast(D)) + if (isImplicitTemplateInstantiat

[PATCH] D141271: [include-cleaner] Filter template instantiations from AST roots.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde81dc8fdf27: [include-cleaner] Filter template instantiations from AST roots. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141477: [include-mapping] Fix the instructions for running stdlib recognizer. Mention python command explicitly. Remove angle brackets.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141477 Files: clang/tools/include-mapping/gen_std.py I

[PATCH] D141477: [include-mapping] Fix the instructions for running stdlib recognizer. Mention python command explicitly. Remove angle brackets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83c5040f6f32: [include-mapping] Fix the instructions for running stdlib recognizer. Mention… (authored by VitaNuo). Repository: rG LLVM Github Mon

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:100 SYMBOL(atoll, std::, ) +SYMBOL(atomic, std::, ) +SYMBOL(atomic, std::, ) VitaNuo wrote: > kadircet wrote: > > hokein wrote: > > > Conceptually, this (and other

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491796. VitaNuo added a comment. Add early return for found symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/C

[PATCH] D142555: Refactor symbol page parsing.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142555 Files: clang/tools/include-mapping/cppreference_p

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492130. VitaNuo added a comment. Refactor the symbol parsing loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSy

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492160. VitaNuo added a comment. Refine C parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc cl

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492352. VitaNuo added a comment. Sort the C symbol map. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492366. VitaNuo added a comment. Fix "atomic" and "div" overloads programmatically. Add a FIXME for future proper handling of overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://review

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:106 -SYMBOL(atomic_exchange_explicit, std::, ) -SYMBOL(atomic_fetch_add, std::, ) -SYMBOL(atomic_fetch_add_explicit, std::, ) -

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492396. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove special casing from gen_std.py. Re-introduce special handling for std::remove. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492398. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clang/in

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492400. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clang/in

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492408. VitaNuo marked an inline comment as done. VitaNuo added a comment. Rely on alphabetic ordering to determine whether the symbol is new. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://r

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Thank you all for comments! The patch should be ready for the next review now. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:1053 SYMBOL(remainder, std::, ) +SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) ---

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492413. VitaNuo added a comment. Remove extra import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492774. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. No new tests in this version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.o

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492775. VitaNuo added a comment. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clang/inc

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! AFAICS I've addressed all of them. Re tests, thanks for the reminder @hokein! I've fixed them now, everything is green. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.i

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493564. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Remove all special-casing, skip all variant pages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Thanks for the comments! Comment at: clang/tools/include-mapping/cppreference_parser.py:196 + "std::remove$": "algorithm", + "std::atomic.*": "atomic", + kadircet wrote: > there's no variant of "std::atomic.*" called "atomic",

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493565. VitaNuo added a comment. Remove a FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clan

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/Sta

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493651. VitaNuo added a comment. Remove comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibrary.h

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493863. VitaNuo added a comment. Minor improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibrary.h

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493869. VitaNuo marked an inline comment as done. VitaNuo added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/T

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493870. VitaNuo added a comment. Revert all changes to generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/Standar

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493871. VitaNuo added a comment. Revert more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp Index

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Reverted everything apart from library support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 ___ cfe-commits mailing list cfe-commit

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143054 Files:

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493886. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibr

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo added a comment. Thanks for the comments! Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:31 + +static llvm::DenseMap LanguageMappings; + hokein wrote: > using a map here seems like an overkill, we have just 2 elements, I'd just > u

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 493918. VitaNuo added a comment. Add a couple more test cases to StandardLibraryTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo added a comment. Added a couple of test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

VitaNuo updated this revision to Diff 494250. VitaNuo added a comment. Remove the C symbol map from commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143054/new/ https://reviews.llvm.org/D143054 Files: clang/include/clang/Tooling/Inclusions/

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

VitaNuo added a comment. Sure, removed the C symbol mapping from this patch. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143054/new/ https://reviews.llvm.org/D143054 ___ cfe-commits mailing lis

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 494329. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibr

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo updated this revision to Diff 494332. VitaNuo added a comment. Remove extra include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibrary

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

VitaNuo added a comment. Thanks for the comments! Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:31 + +static llvm::DenseMap LanguageMappings; + hokein wrote: > VitaNuo wrote: > > hokein wrote: > > > using a map here seems like an overkill,

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo updated this revision to Diff 488539. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141509/new/ https://reviews.llvm.org/D141509 Files: clang/tools/include-mapping/cppreference_parser.py

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the review! Comment at: clang/tools/include-mapping/cppreference_parser.py:117 def _ReadSymbolPage(path, name): - with open(path) as f: -return _ParseSymbolPage(f.read(), name) + try: +f =

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG301123c7a8b5: [include-mapping] Fix parsing of html_book_20190607.zip (https://en. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHA

[PATCH] D141586: [include-mapping] Replace the stdlib symbol maps with the newest official version from https://en.cppreference.com/w/File:html_book_20190607.zip.

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141586 Files: clang/in

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo created this revision. Herald added a subscriber: arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141611 Files: clang

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo updated this revision to Diff 488653. VitaNuo added a comment. Change implementation from using "print" to using "sys.stderr.write". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141611/new/ https://reviews.llvm.org/D141611 Files: clang/

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:145 path = os.path.join(root_dir, symbol_page_path) - results.append((symbol_name, + if os.path.isfile(path): +results.append((symbol_name, kadi

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo updated this revision to Diff 488659. VitaNuo added a comment. Mention symbol name in the error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141611/new/ https://reviews.llvm.org/D141611 Files: clang/tools/include-mapping/cppref

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed001018a02b: [include-mapping] Print an error message in case the symbol index points to a… (authored by VitaNuo). Repository: rG LLVM Github Mon

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141855 Files: clang/to

[PATCH] D141586: [include-mapping] Replace the stdlib symbol maps with the newest official version from https://en.cppreference.com/w/File:html_book_20190607.zip.

VitaNuo abandoned this revision. VitaNuo added a comment. Abandoning since we will eventually parse a newer version of the archive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141586/new/ https://reviews.llvm.org/D141586

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 489824. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.org/D141855 Files: clang/tools/include-mapping/gen_std.py Index: cla

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 489827. VitaNuo added a comment. Remove extra whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.org/D141855 Files: clang/tools/include-mapping/gen_std.py Index: cla

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 489828. VitaNuo added a comment. Adjust argument value set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.org/D141855 Files: clang/tools/include-mapping/gen_std.py Index: c

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Yes, ofc I've run it, I wouldn't send a patch otherwise :) Comment at: clang/tools/include-mapping/gen_std.py:67 required=True) + parser.add_argument('-output', + def

[PATCH] D141944: [include-mapping] Fix gen_std.py test

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141944 Files: clang/to

[PATCH] D141944: [include-mapping] Fix gen_std.py test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0aaeb25525ec: [include-mapping] Fix gen_std.py test (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo updated this revision to Diff 490117. VitaNuo marked an inline comment as done. VitaNuo added a comment. Minor adjustments in accordance with review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141855/new/ https://reviews.llvm.or

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

VitaNuo added a comment. Thanks for the comments! Comment at: clang/tools/include-mapping/gen_std.py:31 // Generate C++ symbols python3 gen_std.py -cppreference cppreference/reference -language=cpp > StdSymbolMap.inc // Generate C symbols --

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/Standa

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 490468. VitaNuo added a comment. Remove variant logic in generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/Stand

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 490476. VitaNuo added a comment. Restore variant logic for overloads. Remove broken logic for accepted variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 490478. VitaNuo added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp clang/to

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe74f9e788507: [include-mapping] Parse zombie_names.html into a removed symbols map. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CH

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 490824. VitaNuo added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add re-generated symbol maps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Added the re-generated symbol maps to this patch as per @hokein's request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 ___ cfe-comm

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Oh I misunderstood your comment regarding which maps need to be regenerated as part of this patch. Regenerated the 2018 ones now. As expected, there are only added symbols now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491260. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/incl

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491258. VitaNuo added a comment. Update the 20181028 archive maps. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSy

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491367. VitaNuo added a comment. Re-introduce the special std::remove handling for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/T

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:174 - # std::remove<> has variant algorithm. - "std::remove": ("algorithm"), - } kadircet wrote: > this is actually checking for something else (sorry for the

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491380. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments regarding data structure use and style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://revie

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491382. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clan

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:20 static llvm::StringRef *HeaderNames; -static std::pair *SymbolNames; -static unsigned *SymbolHeaderIDs; +static llvm::DenseMap> +*SymbolNames; hokein wrote:

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491407. VitaNuo added a comment. Special case the overloads for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/C

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:100 SYMBOL(atoll, std::, ) +SYMBOL(atomic, std::, ) +SYMBOL(atomic, std::, ) kadircet wrote: > hokein wrote: > > Conceptually, this (and other `atomic_*` symbols)

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:1053 SYMBOL(remainder, std::, ) +SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) hokein wrote: > I think `std::remove` should not be in the scope of t

[PATCH] D155614: [clangd] Make an include always refer to itself. Background: clang-review expects all referents to have definition, declaration or reference(s).

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.

VitaNuo updated this revision to Diff 541882. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Remove only one of the checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155614/new/ https://reviews.llvm.org/D155614 Files: cla

[PATCH] D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.

VitaNuo accepted this revision. VitaNuo added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:1361-1362 }); - if (Results.References.empty()) -return std::nullopt; - usaxena95 wrote: > S

[PATCH] D155614: [clangd] Remove redundant emptiness check in cross ref calculation for includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22605f5f1bf8: [clangd] Make an include always refer to itself. Background: clang-review… (authored by VitaNuo). Repository: rG LLVM Github Monorep

  1   2   3   4   5   >