VitaNuo marked an inline comment as done.
VitaNuo added a comment.

Yes, ofc I've run it, I wouldn't send a patch otherwise :)



================
Comment at: clang/tools/include-mapping/gen_std.py:67
                       required=True)
+  parser.add_argument('-output',
+                      default='SymbolMap.inc',
----------------
hokein wrote:
> instead adding two CLI flags, I'd suggest extending the existing `language` 
> flag to something like `-symbols = {cpp_symbols, c_symbols, 
> cpp_removed_symbols}`, it is easy to extend in the future (e.g. 
> `c_removed_symbols`).
> 
Sure, good idea!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141855/new/

https://reviews.llvm.org/D141855

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to