VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the review!
================ Comment at: clang/tools/include-mapping/cppreference_parser.py:117 def _ReadSymbolPage(path, name): - with open(path) as f: - return _ParseSymbolPage(f.read(), name) + try: + f = open(path) ---------------- hokein wrote: > so the input path can be invalid, pointing to a non-existing file, I'd just > check it in the caller side, see my other comment. good idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141509/new/ https://reviews.llvm.org/D141509 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
