On 17 October 2016 at 09:11, Nico Weber via cfe-commits
wrote:
> Looks like things are still unexpectedly passing at r284389 on macOS (but we
> currently only build and test libc++ on macOS, so maybe it's broken
> elsewhere too).
Green dragon is showing similar failures:
http://lab.llvm.org:8080/
Hi Krzysztof,
This still seems to be failing on Darwin:
/Users/tim/llvm/llvm/tools/clang/test/Driver/hexagon-toolchain-elf.c:9:14:
error: expected string not found in input
// CHECK000: "-cc1" {{.*}} "-internal-externc-isystem"
"{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/include"
The
On 14 October 2016 at 14:21, Eric Fiselier via cfe-commits
wrote:
> Could you give me more information about the compiler your using?
Do you mostly build libcxx outside of a Clang source tree? I suspect
the problem is that if Clang is built at the same time then that's the
Clang which gets used t
Author: tnorthover
Date: Mon Oct 17 13:00:27 2016
New Revision: 284401
URL: http://llvm.org/viewvc/llvm-project?rev=284401&view=rev
Log:
Hexagon: add dummy files to test dir so git keeps them.
Should fix hexagon-elf-toolchain.c tests on Git.
Added:
cfe/trunk/test/Driver/Inputs/hexagon_tree/T
On 17 October 2016 at 11:13, Krzysztof Parzyszek
wrote:
> That is crazy! You are right---git does not store empty directories. "SVN
> co" worked fine for me, but "git clone" didn't. D:
Oops, a bit of overlap. Thanks for fixing it more thoroughly than me!
Tim.
___
On 17 October 2016 at 10:34, Tim Northover wrote:
> I think this might be something to do with git not actually recording
> empty directories. Could you have another look?
Never mind, I've confirmed and committed a fix in r284401.
Tim.
___
cfe-commits
On 15 October 2016 at 13:08, Eric Fiselier via cfe-commits
wrote:
> Are these tests still broken for you?
They're still breaking multiple Green Dragon bots (e.g. the basic
"make check" at
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA/)[1].
What do you need to help fix the issue?
C
t.p.northover added a comment.
I can't explain the Opts.C99 (fesetround is provided by conforming C++11
implementations too), but I think I was just trying to capture the fact that
decent hosted platforms support fesetround but freestanding ones don't (not
having any library).
Supporting "C89
On 24 September 2015 at 07:53, Alexandros Lamprineas
wrote:
> @t.p.northover I think we should not be defining _ARM_FP_FENV_ROUNDING on
> neither of ARM and AArch64 targets since "-frounding-math" is not available
> on clang: clang/llvm don't support C99 FP rounding mode pragmas (FENV_ACCESS
>
t.p.northover created this revision.
t.p.northover added a subscriber: cfe-commits.
t.p.northover set the repository for this revision to rL LLVM.
When a struct's size is not a power of 2, the corresponding _Atomic() type is
promoted to the nearest. We already correctly handled normal C++ express
Author: tnorthover
Date: Fri Oct 23 12:56:08 2015
New Revision: 251131
URL: http://llvm.org/viewvc/llvm-project?rev=251131&view=rev
Log:
Set LC_COLLATE rather than LANG to override collation.
On a system with LC_COLLATE=C, this takes precedence over a non-C LANG
the test tries to impose and the t
t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
This looks mostly fine, just one quick question that shouldn't block anything:
===
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
Using alignas(heap_node) might be a little clearer and more semantically
correct here. Should be OK support-wise, libc++ is already using that for some
of its bits. Otherwise, good find!
Tim.
Repository:
rL LLVM
t.p.northover added a comment.
Oh, and I **think** it can probably be justified under C++, though I've not
quite joined up all the dots. The "object lifetime" rules seem to bless
declaring a char array dead and reusing its storage for another purpose. Since
heap_node has trivial initialization,
t.p.northover added inline comments.
Comment at: lib/Driver/ToolChain.cpp:485
@@ +484,3 @@
+if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) ||
+(InputType != types::TY_PP_Asm &&
+ Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb,
ThumbDefault)))
-
t.p.northover added a comment.
If you're on Linux or something you need "clang -target x86_64-apple-darwin
-arch armv7 -c tmp.s". Another mess I keep meaning to fix.
I suspect the reason for this hack is that we've already changed the triple to
"thumbv7-apple-iosN" by this point (because -arch
t.p.northover added a comment.
Ping?
Repository:
rL LLVM
http://reviews.llvm.org/D13874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Oct 27, 2015 11:06, "Renato Golin" wrote:
>
> rengolin added a comment.
>
> In http://reviews.llvm.org/D14121#276389, @t.p.northover wrote:
>
> > If you're on Linux or something you need "clang -target
x86_64-apple-darwin -arch armv7 -c tmp.s".
>
>
> x86_64 + ARMv7? This doesn't make sense... W
Author: tnorthover
Date: Fri Oct 30 11:30:30 2015
New Revision: 251707
URL: http://llvm.org/viewvc/llvm-project?rev=251707&view=rev
Log:
Preprocessor: define correct tvOS and watchOS version macros
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Frontend/darwin-version.c
Modifie
Author: tnorthover
Date: Fri Oct 30 11:30:41 2015
New Revision: 251709
URL: http://llvm.org/viewvc/llvm-project?rev=251709&view=rev
Log:
Disable SjLj exceptions for watchOS
Modified:
cfe/trunk/include/clang/Driver/ToolChain.h
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/To
Author: tnorthover
Date: Fri Oct 30 11:30:27 2015
New Revision: 251706
URL: http://llvm.org/viewvc/llvm-project?rev=251706&view=rev
Log:
Support watchOS and tvOS driver options
This patch should add support for almost all command-line options and
driver tinkering necessary to produce a correct "c
Author: tnorthover
Date: Fri Oct 30 11:30:49 2015
New Revision: 251711
URL: http://llvm.org/viewvc/llvm-project?rev=251711&view=rev
Log:
Support tvOS and watchOS availability attributes
Added:
cfe/trunk/test/Sema/attr-availability-tvos.c
cfe/trunk/test/Sema/attr-availability-watchos.c
Mod
Author: tnorthover
Date: Fri Oct 30 11:30:45 2015
New Revision: 251710
URL: http://llvm.org/viewvc/llvm-project?rev=251710&view=rev
Log:
ARMv7k: implement ABI changes for watchOS from standard iOS.
Added:
cfe/trunk/test/CodeGen/armv7k-abi.c
cfe/trunk/test/CodeGenCXX/armv7k.cpp
cfe/tru
Author: tnorthover
Date: Fri Oct 30 11:30:51 2015
New Revision: 251712
URL: http://llvm.org/viewvc/llvm-project?rev=251712&view=rev
Log:
Support watchOS and tvOS in compiler-rt builds
Hopefully autotools will be deprecated soon and this entire file can go away,
but until then...
Modified:
cf
Author: tnorthover
Date: Fri Oct 30 11:30:36 2015
New Revision: 251708
URL: http://llvm.org/viewvc/llvm-project?rev=251708&view=rev
Log:
Watch and TV OS: wire up basic ABI choices
This sets the mostly expected Darwin default ABI options for these two
platforms. Active changes from these defaults
> On 30 Oct 2015, at 14:37, Alexey Samsonov wrote:
> Do we need to port this to CMake as well?
Yep, we're working on it. Sorry about that, I was cross-referencing a slightly
stale patch to produce the final split commits, and missed the CMake bits we’ve
got here. Should be sorted soon.
Tim.
_
Author: tnorthover
Date: Mon Nov 2 13:32:23 2015
New Revision: 251821
URL: http://llvm.org/viewvc/llvm-project?rev=251821&view=rev
Log:
Fix va_arg on watchOS.
As in other contexts, alignments can go up to 16 bytes in a va_list.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
cfe/trunk/te
Author: tnorthover
Date: Mon Nov 2 15:14:48 2015
New Revision: 251832
URL: http://llvm.org/viewvc/llvm-project?rev=251832&view=rev
Log:
watchOS & tvOS: add a few more tests.
Modified:
cfe/trunk/test/Driver/darwin-version.c
cfe/trunk/test/Driver/implicit-function-as-error.c
cfe/trunk/
Author: tnorthover
Date: Tue Nov 3 12:14:42 2015
New Revision: 251953
URL: http://llvm.org/viewvc/llvm-project?rev=251953&view=rev
Log:
Revert "Support watchOS and tvOS in compiler-rt builds"
The required compiler-rt changes aren't present yet so attempting to
build with compiler-rt breaks. And
t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Saleem, committed in r252507.
Comment at: lib/CodeGen/CGAtomic.cpp:782
@@ +781,3 @@
+ LValue AtomicVal = MakeAddrLValue(Ptr, AtomicTy);
+ AtomicInfo Atomics(*this, AtomicVal);
+
compnerd
Author: tnorthover
Date: Mon Nov 9 13:56:35 2015
New Revision: 252507
URL: http://llvm.org/viewvc/llvm-project?rev=252507&view=rev
Log:
Atomics: support __c11_* calls on _Atomic struct types.
When a struct's size is not a power of 2, the corresponding _Atomic() type is
promoted to the nearest. W
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
This looks fine to me. Thanks for working on it!
Tim.
http://reviews.llvm.org/D14521
___
cfe-commits mailing list
cfe-commits@list
>> Can't handle the update of the umbrella *because of GitHub*, this could be
>> possible with our own hosting of git for instance.
>>
> Pre-commit hooks are not designed to update the umbrella. Webhooks will be
> able to update the umbrella with a small external service, as proposed in the
> IR
Author: tnorthover
Date: Tue Feb 2 12:02:10 2016
New Revision: 259537
URL: http://llvm.org/viewvc/llvm-project?rev=259537&view=rev
Log:
ARM: allow both vfma and vfms intrinsics on v7.
The main purpose here is that vfma/vfms should be symmetric, and they are
supported on most v7 cores.
The new A
Hi Eric,
On 6 February 2016 at 16:36, Eric Fiselier via cfe-commits
wrote:
> Cleanup node-type handling in the unordered containers
This seems to have broken __gnu_cxx::hash_map (used by hash.cpp and
hash2.cpp in the test-suite). A smaller reproducer is:
#include
typedef __gnu_cxx::hash_map >
Hi Richard,
On 9 February 2016 at 16:59, Richard Smith via cfe-commits
wrote:
> Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from
> and wcschr, wcspbrk, wcsrchr, wmemchr, and wcsstr from to
> provide a const-correct overload set even when the underlying C library does
> not.
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me now.
Tim.
http://reviews.llvm.org/D15040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
On 10 February 2016 at 12:52, Eric Fiselier wrote:
> @Tim Are these tests in the clang test suite?
Yep, at http://llvm.org/git/test-suite.git.
> Marshall and I were just talking about removing all together.
> Could you explain who still uses it?
In the test-suite, it looks like it's just thes
On 10 February 2016 at 12:06, Richard Smith wrote:
> OK, got the build working. This should be fixed in r260425. Please let
> me know if you're still seeing failures.
Thanks Richard, that did it.
Tim.
___
cfe-commits mailing list
cfe-commits@lists.llvm
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me.
Tim.
http://reviews.llvm.org/D17124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: tnorthover
Date: Thu Feb 11 15:31:51 2016
New Revision: 260596
URL: http://llvm.org/viewvc/llvm-project?rev=260596&view=rev
Log:
Relax recently added clang version checks.
You can override the value of these during CMake, and we often use sentinels
with more than one digit (not to mention
Author: tnorthover
Date: Fri Feb 12 16:30:42 2016
New Revision: 260755
URL: http://llvm.org/viewvc/llvm-project?rev=260755&view=rev
Log:
Darwin: pass -stdlib=libc++ down to cc1 whenever we're targeting libc++
Recent refactoring meant it only got passed down when explicitly specified,
which breaks
Author: tnorthover
Date: Mon Feb 15 10:38:10 2016
New Revision: 260898
URL: http://llvm.org/viewvc/llvm-project?rev=260898&view=rev
Log:
Darwin: fix stdlib handling when CLANG_DEFAULT_STDLIB is set
I'd accidentally skipped the CMake check in a premature optimisation. I'd also
put the original tes
Hi Jonas,
Thanks for looking at the patch!
> On 13 Feb 2016, at 01:26, Hahnfeld, Jonas wrote:
> as I did the change: Sorry that it broke for you on Darwin! I could not test
> myself and there doesn't seem to be a build-bot…
No worries. I think it only triggered in the stage 2 Green Dragon bots
Author: tnorthover
Date: Wed Feb 24 11:57:48 2016
New Revision: 261758
URL: http://llvm.org/viewvc/llvm-project?rev=261758&view=rev
Log:
AArch64: fix Cyclone CPU features list.
It turns out we don't have CRC after all. Who knew?
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Pre
t.p.northover added a comment.
I'm opposed to the changes on ARM. It would be undefined behaviour if the user
wrote it at the C level, but not LLVM IR I think, which means Clang is
perfectly entitled to emit calls like that.
Tim.
http://reviews.llvm.org/D19275
_
t.p.northover added a comment.
Yep, that sounds about perfect to me. Exactly what the different CXXABI classes
are for, really.
Tim.
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: tnorthover
Date: Thu Apr 28 08:59:55 2016
New Revision: 267880
URL: http://llvm.org/viewvc/llvm-project?rev=267880&view=rev
Log:
ARMv7k: define __ARM_PCS_VFP since we're hard-float.
It's a little debateable because we're not truly AAPCS, so I'm
certainly not going to define __ARM_PCS, but
Author: tnorthover
Date: Thu Apr 28 09:01:49 2016
New Revision: 267881
URL: http://llvm.org/viewvc/llvm-project?rev=267881&view=rev
Log:
Add accidentally dropped test to r267880.
Forgot "git add".
Modified:
cfe/trunk/test/Preprocessor/arm-target-features.c
Modified: cfe/trunk/test/Preproces
t.p.northover added a comment.
Couple of issues, as far as I can see:
Comment at: include/clang/Basic/arm_neon.td:710-711
@@ +709,4 @@
+ def VCVT_F32_F16 : SInst<"vcvt_f32_f16", "wd", "h">;
+ def VCVT_HIGH_F16_F32 : SOpInst<"vcvt_high_f16", "hmj", "Hf",
OP_VCVT_NA_HI_F16>;
+
t.p.northover added a comment.
The __ARM_DWARF_EH__ change looks reasonable, but it's probably an idea to put
a check into tools/clang/tests/Preprocessor/arm-target-features.c (watch is
checked with "ARMV7K").
The rest of the changes look like they're from an unsynchronized branch?
http://rev
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for updating the patch.
Tim.
http://reviews.llvm.org/D19665
___
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks Chris!
http://reviews.llvm.org/D19693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: tnorthover
Date: Tue May 3 14:22:41 2016
New Revision: 268422
URL: http://llvm.org/viewvc/llvm-project?rev=268422&view=rev
Log:
AArch64: simplify illegal vector check. NFC.
Use a utility function to check whether the number of elements is a power of 2
and drop the redundant upper limit (
Author: tnorthover
Date: Tue May 3 14:24:47 2016
New Revision: 268423
URL: http://llvm.org/viewvc/llvm-project?rev=268423&view=rev
Log:
AArch64: fixup comment after change
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vie
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
I think it would be better to use a generic method so the size is minimal
everywhere rather than making ARM a special case. Possibly move the #define
bits from libunwind.cpp to __libunwind_config.h and use REGISTER_K
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
This looks reasonable to me, but please make sure you don't inject Windows line
endings into the real repository.
Cheers.
Tim.
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: tnorthover
Date: Fri May 13 16:26:45 2016
New Revision: 269487
URL: http://llvm.org/viewvc/llvm-project?rev=269487&view=rev
Log:
ARM-MachO: stop claiming to be EABI
Embedded ARM MachO targets are AAPCS but not full EABI (we don't use
__aeabi_whatever and the functions are allowed to be ha
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
I don't think we need to wait until the document is public, necessarily. The
entire AArch64 backend went in before the encodings were public outside ARM
(except maybe in binutils source?) and releasing specifications
t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks pretty straightforward, go for it.
Tim.
http://reviews.llvm.org/D20283
_
On 17 May 2016 at 10:32, Renato Golin wrote:
> I don't think a small future ACLE builtin is on the same league as a whole
> new back-end. :)
Well yes, it's probably got orders of magnitude less bugs than the
backend for a start.
> Nor I think that having this when the docs are public, rather th
Author: tnorthover
Date: Thu Mar 31 14:19:24 2016
New Revision: 265038
URL: http://llvm.org/viewvc/llvm-project?rev=265038&view=rev
Log:
Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics.
Whatever crash it was there to present appears to have been fixed in the
backend now, and i
> On 31 Mar 2016, at 16:51, Steven Wu wrote:
>
> The original handler is not there to workaround a crash. It is to avoid
> generate a crash report (report_fatal_error) when the input bitcode contains
> invalid assembly.
Ah, I see now. That test needs tweaking too, since it doesn't actually p
Author: tnorthover
Date: Wed Apr 6 14:58:07 2016
New Revision: 265592
URL: http://llvm.org/viewvc/llvm-project?rev=265592&view=rev
Log:
Restore slightly less dodgy diagnostic handler for inline asm
Turns out it was there mostly to prevent Clang asking people to report a bug.
This time we report
> Generally good. How about only report error when SM.getKind() == DK_Error?
Good idea. I've committed it with more flexible diagnostic kinds as r265592.
Tim.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
t.p.northover added inline comments.
Comment at: test/Sema/arm_vfma.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-target-feature +vfp4
t.p.northover added inline comments.
Comment at: test/Sema/arm_vfma.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-target-feature +vfp4
Author: tnorthover
Date: Wed Apr 13 12:08:51 2016
New Revision: 266211
URL: http://llvm.org/viewvc/llvm-project?rev=266211&view=rev
Log:
ARM: make Darwin's "-arch armv7em" default to hard-float.
We've already paid the price for separate "armv7m" and "armv7em" slices
(support in other tools), it's
Author: tnorthover
Date: Wed Apr 13 12:08:55 2016
New Revision: 266212
URL: http://llvm.org/viewvc/llvm-project?rev=266212&view=rev
Log:
AArch64: allow 64-bit access to sysregs.
Although all the registers are actually 32-bits, I think we have to assume the
high 32-bits could be RES0 (the ARM ARM
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good to me. I love seeing the death of a target-specific intrinsic!
Tim.
Repository:
rL LLVM
http://reviews.llvm.org/D19099
_
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Sorry, I thought I'd already commented here. It looked good to me too.
Tim.
http://reviews.llvm.org/D18998
___
cfe-commits mailing
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
Just one suggestion for the tests here:
Comment at: test/Sema/builtins-arm.c:50
@@ -49,2 +49,3 @@
void test6(int a, int b, int c) {
+ __builtin_arm_ldc(a, 2, &a); // expected-error {{argument to
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Thanks Ranjeet. LGTM!
Tim.
http://reviews.llvm.org/D20563
___
cfe-commits mailing l
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
This could do with a test in test/Driver.
http://reviews.llvm.org/D21163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
I think that looks good. Thanks for adding the test!
Tim.
http://reviews.llvm.org/D21163
__
t.p.northover added a comment.
I agree with Renato too.
It seems like, as a compiler, we can provide virtually no guarantees about the
value of `__builtin_arm_current_pc`: it's not necessarily in the PC-range of
the dynamically innermost frame (inlining); it's not necessarily even in the
calls
Author: tnorthover
Date: Tue Jul 12 12:38:50 2016
New Revision: 275195
URL: http://llvm.org/viewvc/llvm-project?rev=275195&view=rev
Log:
AArch64: fix return type of vqmovun_high_*.
These should be returning an unsigned quantity.
Added:
cfe/trunk/test/Sema/arm64-neon-header.c
Modified:
cf
t.p.northover created this revision.
t.p.northover added reviewers: rengolin, jmolloy.
t.p.northover added a subscriber: cfe-commits.
Herald added subscribers: mcrosier, rengolin, aemerson.
We've had embedded developers requesting we extend the __ARM_VFPVn__ series to
support Cortex-M7, which sou
Author: tnorthover
Date: Tue Mar 8 17:10:58 2016
New Revision: 262964
URL: http://llvm.org/viewvc/llvm-project?rev=262964&view=rev
Log:
AArch64: remove tests of intrinsics completely duplicated elsewhere.
Removed:
cfe/trunk/test/CodeGen/arm64_neon_high_half.c
cfe/trunk/test/CodeGen/arm64
Author: tnorthover
Date: Wed Mar 9 12:00:06 2016
New Revision: 263038
URL: http://llvm.org/viewvc/llvm-project?rev=263038&view=rev
Log:
AArch64: remove a couple more tests already covered elsewhere.
Removed:
cfe/trunk/test/CodeGen/arm64-scalar-test.c
cfe/trunk/test/CodeGen/arm64-vrsqrt.c
Modified: cfe/trunk/test/CodeGen/builtins-arm-exclusive.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins-arm-exclusive.c?rev=263048&r1=263047&r2=263048&view=diff
==
--- cfe/trunk/test/CodeGen/buil
t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Eric. Committed as r263048.
http://reviews.llvm.org/D17999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 9 March 2016 at 11:12, Sanjay Patel wrote:
> Nothing to do with the patch itself (although it looks great and thanks!) -
> is the CHECK line generator script available somewhere? I'd love to be able
> to use that.
It's horribly hacky and fragile, but what I've got should be attached
here. Pa
On 9 March 2016 at 13:20, David Blaikie via cfe-commits
wrote:
> If we are touching these tests at all, as a cleanup, why aren't we adjusting
> them to not pass through the llvm optimizers/code generators at all?
> Generally we are pretty clear that any test in Clang looking at llvms
> generated a
Author: tnorthover
Date: Wed Mar 9 22:39:45 2016
New Revision: 263093
URL: http://llvm.org/viewvc/llvm-project?rev=263093&view=rev
Log:
ARM: fix arm_neon_intrinsics.c and re-enable.
It turns out I'd never actually tested my recent change because it was
gated on long-tests. Failure ensued.
Modif
t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
This looks fine to me.
Tim.
http://reviews.llvm.org/D18193
___
Author: tnorthover
Date: Wed Jan 27 13:32:40 2016
New Revision: 258976
URL: http://llvm.org/viewvc/llvm-project?rev=258976&view=rev
Log:
ARMv7k: select ABI based on v7k Arch rather than watchos OS.
Various bits we'd like to use the new ABI actually compile with "-arch armv7k
-miphoneos-version-mi
Author: tnorthover
Date: Wed Jan 27 16:14:02 2016
New Revision: 258994
URL: http://llvm.org/viewvc/llvm-project?rev=258994&view=rev
Log:
ARMv7k: simplify logic for deciding sjlj-exceptions.
Slight change of behaviour in the odd armv7+watchos case, which should match
the other runtime components.
Author: tnorthover
Date: Tue Nov 17 12:27:27 2015
New Revision: 253355
URL: http://llvm.org/viewvc/llvm-project?rev=253355&view=rev
Log:
ARM: fix mismatch between Clang and backend on exception type.
"-arch armv7k" is only normally used with a watchos target, but Clang doesn't
stop you from givin
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
Do these get the right diagnostics when used on CPUs without the new feature? I
can't see how __ARM_FEATURE_QRDMX gets wired through to arm_neon.h.
http://reviews.llvm.org/D14982
_
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
This looks good, too.
Tim.
Repository:
rL LLVM
http://reviews.llvm.org/D15022
___
cfe-commits mailing list
cfe-commits@lists.ll
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
All obviously good stuff here too.
Repository:
rL LLVM
http://reviews.llvm.org/D15023
___
cfe-commits mailing list
cfe-commits@l
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Tim.
http://reviews.llvm.org/D14982
___
cfe-commits mailing list
cfe-
On 1 December 2015 at 10:42, James Molloy via cfe-commits
wrote:
> W.r.t the test-suite, that is a possibility. There are currently no
> codegen-filecheck tests in the test-suite but there seems to be no reason I
> can see why not. The disadvantage there for me is that we take short
> running, sim
On 14 December 2015 at 09:20, Eric Christopher via cfe-commits
wrote:
> I understand the conflicting priorities here for sure. You'd like a test
> that's as minimal as possible, without having to depend on external (to
> clang) libraries here. I really would appreciate it if you'd make the test
> I don't think it's going to be even vaguely that bad here and that you're
> blowing it a bit out of proportion. [...] It does make the tests a little
> harder
> to write, but having done a bunch of them it's not that bad.
I've also tried to write such tests in the past, and I did find it that b
On 14 December 2015 at 11:12, Eric Christopher wrote:
> There really is a pretty good separation of concerns and for a lot if not
> most of the tests here all the difference is checking is the arguments,
> keeping track of an alloca and making sure that goes is pretty simple and
> not really hard
t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
Looks fine to me too. Thanks!
Tim.
http://reviews.llvm.org/D15664
___
cfe-commits m
Author: Tim Northover
Date: 2024-04-04T10:25:30+01:00
New Revision: 7a8cf951b3bdc60feac412200ab9661e009d44ae
URL:
https://github.com/llvm/llvm-project/commit/7a8cf951b3bdc60feac412200ab9661e009d44ae
DIFF:
https://github.com/llvm/llvm-project/commit/7a8cf951b3bdc60feac412200ab9661e009d44ae.diff
@@ -1480,11 +1480,11 @@ AArch64leTargetInfo::AArch64leTargetInfo(const
llvm::Triple &Triple,
void AArch64leTargetInfo::setDataLayout() {
if (getTriple().isOSBinFormatMachO()) {
if(getTriple().isArch32Bit())
- resetDataLayout("e-m:o-p:32:32-i64:64-i128:128-n32:64-S12
101 - 200 of 201 matches
Mail list logo
