[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

svenvh added a comment. > I've left the check during parsing as well, because it provides slightly > better error messages Do you have an example of what error messages get worse if you remove the parsing check? Just wondering if there is an easy way to fix that and avoid having the check twi

[PATCH] D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100985/new/ https://reviews.llvm.org/D100985 ___ cfe-commits mailing list cfe-

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

svenvh added a comment. In D100860#2709057 , @olestrohm wrote: > The first on explains that `event_t` can't be used in program scope at all, > which is better I think. Agreed, removing the parser check gives a worse diagnostic here. The underlying prob

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

svenvh accepted this revision. svenvh added a comment. LGTM, thanks! Please make sure that the commit message corresponds to the new shape of your patch: you might want to update the description of this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/ https://reviews.

[PATCH] D101089: [OpenCL] Document legacy atomics with generic address space

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Nitpick to make the sentence read more smoothly; otherwise LGTM! Comment at: clang/docs/LanguageExtensions.rst:1819 + +Clang allows use of atomic functions from earlier than

[PATCH] D101092: [OpenCL][Docs] Misc updates about C++ for OpenCL and offline compilation

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101092/new/ https://reviews.llvm.org/D101092 ___ cfe-commits mailing list cfe-commits@

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh added a comment. In D100492#2717232 , @srj wrote: > This change appears to be the injection point for > https://bugs.llvm.org/show_bug.cgi?id=50128 -- trying to build clang-tblgen > after this change crashes VC2019 if targeting 32-bit Windows (se

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh added a comment. Thanks for experimenting! I have pushed 37bc1dc9877f ("[NFC] Workaround MSVC2019 32-bit compiler crash", 2021-04-27). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

svenvh added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1748 +With this extension it is possible to enable bitfields in structs +or unions using regular OpenCL extension pragma mechanism detailed in +`the OpenCL Extension Specification, section 1.2 ---

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. I made some minor comments, that can be fixed before committing. Comment at: clang/docs/UsersManual.rst:3567 +Linking is done using `spirv-link` linker from `the SPI

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

svenvh added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:71 +// SPLINK: {{llvm-spirv.*"}} [[BC]] "-o" [[SPV2:".*o"]] +// SPLINK: {{"spirv-link.*"}} [[SPV1]] [[SPV2]] "-o" "a.out" aganea wrote: > Hello @Anastasia, this line fails on my machin

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b85800bfd6c: [OpenCL] Set external linkage for block enqueue kernels (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

svenvh added a comment. @airlied are you still planning to land this? I started looking at the corresponding .td changes when I realized we don't use `__opencl_c_read_write_images` in `opencl-c.h` either yet. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl. svenvh added a project: clang. Herald added a subscriber: ldrumm. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. All kernels can be called from the host as per the SPIR_KERNEL calling conven

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:10 +// SPV64-SAME: "-o" [[BC:".*bc"]] +// SPV64: {{".*llvm-spirv.*"}} [[BC]] "-o" {{".*o"}} + Anastasia wrote: > svenvh wrote: > > Any reason to not just check for `llvm-spirv{{.*}}`,

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

svenvh added a comment. > Does the langref need to be amended, first, or is it okay to interpret the > `readnone` attribute as it was clearly intended, without going through the > process of updating the langref first? > > I can update this review to use `__attribute__((pure))` for all address

[PATCH] D110742: [OpenCL] Add pure attributes to vload builtins

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. In D110742#3197183 , @stuart wrote: > Thanks! I have updated the review to use `__attribute__((pure))` only (i.e. > it no longer uses `__attribute__(

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Mostly some minor comments that you can address at commit time. It would be good to get approval from another reviewer. Comment at: clang/docs/UsersManual.rst:3538 +

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh added a comment. In D96771#2626507 , @Anastasia wrote: > I had a second thought about the extension name and I realized that the > reason why I initially wanted to use `clcpp` is that it aligns better with > `clc++` which is used in `-cl-std`. Eve

[PATCH] D98855: [OpenCL] Support template parameters for as_type

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Implement the TreeTransform for AsTypeExpr. Split `BuildAsTypeExpr` out of `ActOnAs

[PATCH] D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5c4a88a8400: [OpenCL] Remove spurious atomic_fetch tablegen builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98520/new/ https:/

[PATCH] D98855: [OpenCL] Support template parameters for as_type

svenvh added inline comments. Herald added a subscriber: ldrumm. Comment at: clang/test/SemaOpenCLCXX/template-astype.cl:5 +auto templated_astype(T x) { + return as_int2(x); + // expected-error@-1{{invalid reinterpretation: sizes of 'int2' (vector of 2 'int' values) and '__pri

[PATCH] D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. size_t and friends are built-in scalar data types and s6.4.4.2 of the OpenCL

[PATCH] D98855: [OpenCL] Support template parameters for as_type

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bbc9bccf095: [OpenCL] Support template parameters for as_type (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D98855?vs=331517&id=332251#toc Repository: rG LLVM Github Monore

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

svenvh accepted this revision. svenvh added a comment. LGTM; just one minor comment, which you can address as part of your commit. Comment at: clang/test/CodeGenOpenCLCXX/addrspace-with-class.clcpp:2 +// RUN: %clang_cc1 %s -triple spir-unknown-unknown -emit-llvm -O0 -o - | Fil

[PATCH] D98418: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c6521a0ddfa: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h (authored by svenvh). Herald added a subscriber: ldrumm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh updated this revision to Diff 332675. svenvh added a comment. Emit `#if` guards for extensions and versions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 Files: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp clang/utils/TableGe

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The .rgba vector component accessors are supported in OpenCL C 3.0.

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

svenvh added a comment. In D99969#2671931 , @Anastasia wrote: > The code formating check reported an issue though... My bad, will fix before committing. Comment at: clang/lib/Sema/SemaExprMember.cpp:343 if (HasRGBA || (*compStr &&

[PATCH] D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35bc7569f8ad: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add functionality to assign extensions to types in `OpenCLBuiltins.td` and us

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG731bf28a6092: [OpenCL] Accept .rgba in OpenCL 3.0 (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D99969?vs=335557&id=3367

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:54 +// Extension associated to a type. +class TypeExtension : AbstractExtension<_Ext>; + Anastasia wrote: > I am trying to understand why would we need a special abstraction for the > typ

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh created this revision. svenvh added a reviewer: azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Instead of using a MinVersion and MaxVersion field, encode the version of a b

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh updated this revision to Diff 337663. svenvh added a comment. Adding some more comments / explanation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100209/new/ https://reviews.llvm.org/D100209 Files: clang/lib/Sema/OpenCLBuiltins.td clang/lib/Sema/SemaLookup.cpp clang/tes

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:54 +// Extension associated to a type. +class TypeExtension : AbstractExtension<_Ext>; + Anastasia wrote: > svenvh wrote: > > Anastasia wrote: > > > I am trying to understand why would we

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

svenvh added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8673 +// reference if an implementation supports them in kernel parameters. +if (!PointeeType->isAtomicType() && !PointeeType->isVoidType() && +!PointeeType->isStandardLayoutType())

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:507 +if (VersionIDs[I] >= MinVersion && VersionIDs[I] < MaxVersion) { + Encoded |= 1 << I; +} azabaznov wrote: > nit: Encoded |= clang::encodeOpenCLVersion(V

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100471/new/ https://reviews.llvm.org/D100471 __

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cb7631df348: [OpenCL] Change OpenCL builtin version encoding (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100935: [OpenCL] Add missing C++ legacy atomics with generic

svenvh created this revision. svenvh added reviewers: Anastasia, olestrohm. svenvh added a project: clang. Herald added subscribers: ldrumm, jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D62335 added some C++ for OpenCL spec

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b3b89bf1ce: [OpenCL] Do not add builtins with unavailable types (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

svenvh added a comment. In D91348#2475646 , @Anastasia wrote: > LGTM, the change seems reasonable. Thanks! > >> A minor side-effect of this change is that it also produces the >> warning for co_await and co_yield now. > > This warning is produced for **siz

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh added a comment. Looks good to me, just some grammar nitpicks from my side. (I only discovered the "Suggest Edit" feature halfway through the review; I didn't update the comments I already made as I'm not sure in which format you prefer them?) Comment at: clang/docs/O

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4d2361b817: [OpenCL] Warn about side effects for unevaluated vec_step arg (authored by svenvh). Changed prior to commit: https://reviews.llvm.or

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh added inline comments. Comment at: clang/docs/UsersManual.rst:2832 +Note that if compiled to bitcode for generic targets such as SPIR, +portable IR is produced that it can be used with various vendor +tools as well as open source tools such as `SPIRV-LLVM Translator --

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 ___ cfe-commits mailing list cfe-co

[PATCH] D95038: [OpenCL][Docs] Describe tablegen BIFs declaration

svenvh added a comment. Thanks for working on this! Comment at: clang/docs/OpenCLSupport.rst:118 + +In addition to regular header includes with builtin types/functions using +``-finclude-default-header`` explained in :doc:`UsersManual` clang

[PATCH] D95135: Fix signedness in vector bitcast evaluation

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The included test case triggered a sign assertion on the result in `Success()`. This was caused by the APSInt created

[PATCH] D95135: Fix signedness in vector bitcast evaluation

svenvh added inline comments. Comment at: clang/test/CodeGenOpenCL/vector_literals.cl:71 + // CHECK: extractelement <2 x i32> %{{[0-9]+}}, i64 0 + unsigned int withCast = ((int2)((int2)(12, 34))).s0; +} Anastasia wrote: > I wonder if both `(int2)` are needed i.

[PATCH] D95038: [OpenCL][Docs] Describe tablegen BIFs declaration

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95038/new/ https://reviews.llvm.org/D95038 ___ cfe-commits mailing list cfe-co

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

svenvh added a comment. > For the constant address space, the const attribute (or readnone) can be > used. As memory in the constant address space is immutable, the statement in > the langref that: "if a readnone function reads or writes memory visible to > the program, or has other side-effect

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG544d89e847d4: [OpenCL] Add atomic_half type builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D109740?vs=376467&id=378938#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added a comment. In D107769#2967565 , @Anastasia wrote: > In D107769#2960441 , @svenvh wrote: > >> I have done an alternative spin of this patch: instead of introducing >> `RequireDisabledExtension`, simpl

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh created this revision. svenvh added reviewers: Anastasia, jaykang10. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. With -fpreserve-vec3-type enabled, a cast was not created when conv

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1121 +let Extension = FuncExtFloatAtomicsFp32GlobalAdd in { +def: + Builtin<"atomic_fetch_" #ModOp, Please try to follow the formatting used in the rest of this file: ``` def

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh updated this revision to Diff 368058. svenvh added a comment. Added more tests as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.llvm.org/D108470 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGenOpenCL/preserve_vec3.cl Index

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh added a comment. In D108470#2959708 , @jaykang10 wrote: > Can you also add "double2_to_float3" Instead of `double2_to_float3`, I decided to add `char8_to_short3`. Same idea (vectorN to vector3), but reinterpreting 8 chars as 3 shorts feels like

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh added a comment. >> Instead of `double2_to_float3`, I decided to add `char8_to_short3`. Same >> idea (vectorN to vector3), but reinterpreting 8 chars as 3 shorts feels like >> a more realistic case than reinterpreting 2 doubles as 3 floats. But I'm >> happy to add `double2_to_float3` i

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added a comment. Thanks for the update! I have a comment about indentation, other than that this is looking good to me. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1129 +let Extension = FuncExtFloatAtomicsFp64GlobalAdd in { +def : Builtin<"atomic_fetch_" # Mod

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh updated this revision to Diff 368136. svenvh edited the summary of this revision. svenvh added a comment. I have done an alternative spin of this patch: instead of introducing `RequireDisabledExtension`, simply always make the `private`, `global`, and `local` overloads available. This ma

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___ cfe-commits mailing list cfe-

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd353d1c50112: [OpenCL] Support cl_ext_float_atomics (authored by svenvh). Herald added a subscriber: ldrumm. Changed prior to commit: https://revi

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added a comment. Apologies for the delayed response. In D106343#2967089 , @haonanya wrote: > Hi, svenvh. > Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to > guard the functions using atomic_double type? > Thanks very

<    1   2   3   4   5