svenvh created this revision.
svenvh added a reviewer: Anastasia.
svenvh added a project: clang.
Herald added subscribers: ldrumm, yaxunl.
svenvh requested review of this revision.
Herald added a subscriber: cfe-commits.
size_t and friends are built-in scalar data types and s6.4.4.2 of the
OpenCL C Specification says the `as_type()` operator must be available
for these data types.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D98959
Files:
clang/lib/Headers/opencl-c-base.h
clang/test/SemaOpenCL/as_type.cl
Index: clang/test/SemaOpenCL/as_type.cl
===================================================================
--- clang/test/SemaOpenCL/as_type.cl
+++ clang/test/SemaOpenCL/as_type.cl
@@ -1,4 +1,5 @@
-// RUN: %clang_cc1 %s -emit-llvm -triple spir-unknown-unknown
-finclude-default-header -o - -verify -fsyntax-only
+// RUN: %clang_cc1 %s -emit-llvm -DBITS=32 -triple spir-unknown-unknown
-finclude-default-header -fdeclare-opencl-builtins -o - -verify -fsyntax-only
+// RUN: %clang_cc1 %s -emit-llvm -DBITS=64 -triple spir64-unknown-unknown
-finclude-default-header -fdeclare-opencl-builtins -o - -verify -fsyntax-only
char3 f1(char16 x) {
return __builtin_astype(x, char3); // expected-error{{invalid
reinterpretation: sizes of 'char3' (vector of 3 'char' values) and '__private
char16' (vector of 16 'char' values) must match}}
@@ -12,3 +13,15 @@
char src = 1;
int dst = as_int(src); // expected-error{{invalid reinterpretation: sizes
of 'int' and '__private char' must match}}
}
+
+void target_dependent(int i, long l) {
+ size_t size1 = as_size_t(i);
+#if BITS == 64
+ // expected-error@-2{{sizes of 'size_t' (aka 'unsigned long') and '__private
int' must match}}
+#endif
+
+ size_t size2 = as_size_t(l);
+#if BITS == 32
+ // expected-error@-2{{sizes of 'size_t' (aka 'unsigned int') and '__private
long' must match}}
+#endif
+}
Index: clang/lib/Headers/opencl-c-base.h
===================================================================
--- clang/lib/Headers/opencl-c-base.h
+++ clang/lib/Headers/opencl-c-base.h
@@ -545,6 +545,11 @@
#define as_half16(x) __builtin_astype((x), half16)
#endif // cl_khr_fp16
+#define as_size_t(x) __builtin_astype((x), size_t)
+#define as_ptrdiff_t(x) __builtin_astype((x), ptrdiff_t)
+#define as_intptr_t(x) __builtin_astype((x), intptr_t)
+#define as_uintptr_t(x) __builtin_astype((x), uintptr_t)
+
// OpenCL v1.1 s6.9, v1.2/2.0 s6.10 - Function qualifiers
#define __kernel_exec(X, typen) __kernel \
Index: clang/test/SemaOpenCL/as_type.cl
===================================================================
--- clang/test/SemaOpenCL/as_type.cl
+++ clang/test/SemaOpenCL/as_type.cl
@@ -1,4 +1,5 @@
-// RUN: %clang_cc1 %s -emit-llvm -triple spir-unknown-unknown -finclude-default-header -o - -verify -fsyntax-only
+// RUN: %clang_cc1 %s -emit-llvm -DBITS=32 -triple spir-unknown-unknown -finclude-default-header -fdeclare-opencl-builtins -o - -verify -fsyntax-only
+// RUN: %clang_cc1 %s -emit-llvm -DBITS=64 -triple spir64-unknown-unknown -finclude-default-header -fdeclare-opencl-builtins -o - -verify -fsyntax-only
char3 f1(char16 x) {
return __builtin_astype(x, char3); // expected-error{{invalid reinterpretation: sizes of 'char3' (vector of 3 'char' values) and '__private char16' (vector of 16 'char' values) must match}}
@@ -12,3 +13,15 @@
char src = 1;
int dst = as_int(src); // expected-error{{invalid reinterpretation: sizes of 'int' and '__private char' must match}}
}
+
+void target_dependent(int i, long l) {
+ size_t size1 = as_size_t(i);
+#if BITS == 64
+ // expected-error@-2{{sizes of 'size_t' (aka 'unsigned long') and '__private int' must match}}
+#endif
+
+ size_t size2 = as_size_t(l);
+#if BITS == 32
+ // expected-error@-2{{sizes of 'size_t' (aka 'unsigned int') and '__private long' must match}}
+#endif
+}
Index: clang/lib/Headers/opencl-c-base.h
===================================================================
--- clang/lib/Headers/opencl-c-base.h
+++ clang/lib/Headers/opencl-c-base.h
@@ -545,6 +545,11 @@
#define as_half16(x) __builtin_astype((x), half16)
#endif // cl_khr_fp16
+#define as_size_t(x) __builtin_astype((x), size_t)
+#define as_ptrdiff_t(x) __builtin_astype((x), ptrdiff_t)
+#define as_intptr_t(x) __builtin_astype((x), intptr_t)
+#define as_uintptr_t(x) __builtin_astype((x), uintptr_t)
+
// OpenCL v1.1 s6.9, v1.2/2.0 s6.10 - Function qualifiers
#define __kernel_exec(X, typen) __kernel \
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
