[PATCH] D129014: rewording static_assert to more generic static assertion

xgupta added a comment. Running check-clang after applying the patch, results into 36 failed test cases. Please update them all. Also add a description of patch motivation(via the Edit Revision option on the top) for why you are making the changes (like any wrong behavior you are seeing etc).

[PATCH] D129048: Rewording the "static_assert" to static assertion

xgupta added a comment. Three test cases are failing - Please see: https://buildkite.com/llvm-project/premerge-checks/builds/100784#0181c539-bcd1-4d01-a2db-f27a63e2f17e/6-15379 But I think you want to actually modify https://github.com/llvm/llvm-project/blob/93d6fdfc232c59975d52146532693178def5a

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

xgupta added a comment. @anjankgk You need to provide your identity for commit in "your name " form. see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your behal

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

xgupta added a comment. In D106371#2894736 , @anjankgk wrote: > Anjan Kumar Guttahalli Krishna > > Thank you! Seems you are contributing with an official mail, I think you can ask for commit access, if you want to continue contributing, bar is quite lo

[PATCH] D129048: Rewording the "static_assert" to static assertion

xgupta added a comment. In D129048#3662634 , @Codesbyusman wrote: > the libcxx updates but not tested. working on them I just run the check-cxx on local system. It seems to pass all testcases after applying the current patch. Testing Time: 2147.75s

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

xgupta resigned from this revision. xgupta added a comment. I am really an idol reviewer for this patch -:) don't know anything about AMDGPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134 _

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta created this revision. xgupta added reviewers: awarzynski, stephenkelly. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Example tutorial giving undefine reference error wh

[PATCH] D95766: [Branch-Rename] Fix some links

xgupta created this revision. xgupta added reviewers: mehdi_amini, sqlbyme. Herald added a reviewer: bollu. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester,

[PATCH] D95766: [Branch-Rename] Fix some links

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h:20 // Check for underscores in the names of googletest tests, per -// https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-su

[PATCH] D95766: [Branch-Rename] Fix some links

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94fac81fccfe: [Branch-Rename] Fix some links (authored by xgupta).

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. I build the project on my system x64 with shared libraries enable. It is working correctly. It is also NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee1f64a2e82: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build (authored by xgupta). Repository: rG LLVM Github Monorepo C

[PATCH] D109979: [Clang] [Fix] Clang build fails when build directory contains space character

xgupta created this revision. xgupta added reviewers: aaron.ballman, t.p.northover. Herald added a subscriber: mgorny. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang build fails when build directory contains space character.

[PATCH] D109979: [Clang] [Fix] Clang build fails when build directory contains space character

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae57a6a9795: [Clang] [Fix] Clang build fails when build directory contains space character (authored by Brain Swift , committed by xgupta). Repository: rG LLVM Github Monorepo

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Although this patch is correct, running ./LLJITWithTargetProcessControl result in segmentation fault. PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace. Stack dump: 0. Program arguments: ./LLJITWithTargetProcessControl #0 0x7f

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

xgupta accepted this revision. xgupta added a comment. I can push this for you @fcambus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110041/new/ https://reviews.llvm.org/D110041 ___ cfe-commits mailing

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f5ca8cc2158: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils. (authored by fcambus, committed by xgupta). Repository: rG

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D110260#3018110 , @sgraenitz wrote: > Thanks @xgupta for your note! The parameter passed to > `EPCIndirectionUtils::Create()` in the example was re

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. In D110260#3018555 , @sgraenitz wrote: > Interesting, it does work for me now on macOS with both, shared libs on and > off. Can you please check if you get something like this as well: > > ➜ nm bin/LLJITWithExecutorProcessContro

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Problem is fixed with D110345 , Thank you very much for quick fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110260/new/ https://reviews.llvm.org/D110260

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

xgupta added a comment. Nice work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

xgupta added a comment. nice work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LG, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110715/new/ https://reviews.llvm.org/D110715

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a7caf97012f: [clang] Fix library name (libsupc++) in the admonition note. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github

[PATCH] D110750: [clang] Fix sentence in the usage section of ThinLTO docs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01641f665f5a: [clang] Fix sentence in the usage section of ThinLTO docs. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github Mo

[PATCH] D110763: [clang] Update Clang version from 13 to 14 in scan-build.1.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97a0ba475d10: [clang] Update Clang version from 13 to 14 in scan-build.1. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github M

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! And @fcambus If you want to continue contributing to the llvm-project, I would suggest you ask for commit access so you can directly commit typo fixes without opening revisions.

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta added a comment. Thank @awarzynski for reviewing and explaining the details. I somehow missed it. Should be fixed by https://github.com/llvm/llvm-project/commit/d1ef9a63a68850bbe8cd8877f69c41833804c8dc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

xgupta added inline comments. Comment at: clang/docs/LanguageExtensions.rst:539 +.. code-block:: c++ + typedef float m4x4_t __attribute__((matrix_type(4, 4))); + This is incorrect ig. I get warning message : Warning, treated as error: /home/user/llvm-project/c

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

xgupta added inline comments. Comment at: clang/docs/LanguageExtensions.rst:538 + +.. code-block:: c++ + typedef float m4x4_t __attribute__((matrix_type(4, 4))); oh just an blank line is needed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D104971#2842293 , @SaurabhJha wrote: > This is a light patch that probably does not require a review and I created a > patch anyway. > > Would it

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

xgupta added a comment. btw you should use [Docs] or [NFC] for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104971/new/ https://reviews.llvm.org/D104971 ___ cfe-commits mailing list cfe-com

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

xgupta added reviewers: njames93, kbobyrev. xgupta added a comment. Assuming this is your first patch, I add two reviewers for this patch who touch this file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D1049

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

xgupta added a comment. It seems you need someone to commit this patch? If so you need to share your name and email address. So that someone with commit access can commit it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104604/new/ https

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

xgupta added a comment. > These result in warnings while building and don't need to be there. What are the warnings you get, I run `make clangAPINotes` didn't get any. I am on a7ed55f64c5fdce9af3257458779402fb9de1f8b ( [A

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Seems this line

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Jake-Egan wrote: > xgupta wrote: > > Seems this line need formatting? > I originally had it match

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Jake-Egan wrote: > xgupta wrote: > > Jake-Egan wrote: > > > xgupta wrote: > > > > Seems this line

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

xgupta added subscribers: MyDeveloperDay, xgupta. xgupta added a reviewer: MyDeveloperDay. xgupta added a comment. Thanks for the patch @Et7f3! I tested it locally and can reproduce it with cat folder/file.c int main() { return 0; } And indeed the patch also solved the crash issue and emit a corr

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114632/new/ https://reviews.llvm.org/D114632 __

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b099b68c0c: [Docs] Removed /Zd flag still mentioned in documentation (authored by BHUMITRAM, committed by xgupta). Repository: rG LLVM Github Mo

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta created this revision. xgupta added reviewers: nickdesaulniers, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix PR37919 The below code produces -Wconstant-logical-operand f

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 492374. xgupta added a comment. add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs.c clang/t

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. WIP && TODO- Fixed test Failed Tests (7): Clang :: C/drs/dr4xx.c Clang :: Modules/explicit-build-extra-files.cpp Clang :: Parser/cxx2a-concept-declaration.cpp Clang :: SemaCXX/expressions.cpp Clang :: SemaCXX/warn-unsequenced.cpp Clang :: SemaObjC/unguarded-av

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 492995. xgupta added a comment. update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp clang/test/C/drs/dr4xx.c cla

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta created this revision. xgupta added reviewers: aaron.ballman, dblaikie. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC added the -Wtype-limits warning group to -Wextra around GCC 4.4 and the g

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493477. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/Sem

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493479. xgupta added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Di

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta added a comment. In D142826#4090415 , @aaron.ballman wrote: > Heh, I literally started working on this on Friday afternoon. :-D Yeah, I saw someone asking about it on discord on Sunday. so thought to look. Repository: rG LLVM Github Monorepo

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493649. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493810. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagno

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95668c0d97e6: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility (authored by xgupta). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta added a comment. In D142826#4096348 , @aaron.ballman wrote: > LGTM, thank you! Thank you for reviewing and helping it to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://r

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta added a comment. In D142826#4098076 , @hctim wrote: > Hey, looks like this broke the x86_64-linux sanitizer buildbot: > https://lab.llvm.org/buildbot/#/builders/37/builds/19910 > > You can reproduce the bot using the instructions at > https://git

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 494629. xgupta added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp Index: clang/lib/Sema/SemaExpr.cpp

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 494631. xgupta added a comment. remov blank Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp clang/test/C/drs/dr4xx.c clang/tes

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13611-13653 if (RHS.get()->EvaluateAsInt(EVResult, Context)) { llvm::APSInt Result = EVResult.Val.getInt(); if ((getLangOpts().Bool && !RHS.get()->getType()->isBooleanType() && !R

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 495116. xgupta added a comment. use function to avoid code duplication Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 495122. xgupta added a comment. remove old code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.cpp

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

xgupta created this revision. xgupta added reviewers: aaron.ballman, fahadnayyar. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compiling clang/Lex/DirectoryLookup.h with option -Wbitfield-enum-co

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta created this revision. xgupta added reviewers: aaron.ballman, usaxena95. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found by PVS-Studio - https://pvs-studio.com/en/blog/posts/cpp/1003/, N37.

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

xgupta created this revision. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the current calling convection CurCC is not equal to Target calling convection ToCC and current calling convention (CurCC)

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta updated this revision to Diff 491312. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142334/new/ https://reviews.llvm.org/D142334 Files: clang/include/clang/APINotes/Types.h Index: clang/include/c

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang/include/clang/APINotes/Types.h:535 NullabilityPayload &= -~(NullabilityKindMask << (index * NullabilityKindSize)); +~(static_castNullabilityKindMask << (index * Nullabil

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rG68b890831615: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h (authored by xgupta). Repository:

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

xgupta added a comment. In D142304#4073573 , @aaron.ballman wrote: > LGTM but can you find a test case that would show we don't regress this in > the future? I haven't found the test case, but I found a commit

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

xgupta added a comment. In D142338#4073826 , @tbaeder wrote: > LGTM, assuming the pre-commit CI failures are unrelated. Yeah, those 3 test cases should be unrelated, this is an nfc change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94b9187a7d37: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h (authored by xgupta). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

xgupta added a comment. In D142304#4074211 , @aaron.ballman wrote: > I looked through the code base and I think this fix is good but benign (it > doesn't look like it'll impact anything that I can see). So LGTM without > tests. Thank you for reviewing

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40003af98456: [Clang][NFC] Remove a redundancy check in Sema::adju

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435947. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html =

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added inline comments. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for debug mode and takes a lot of time and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a release build. cmake -DLLVM_ENABLE_PR

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html === --- clang/ww

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added a comment. Thank you for review! Committed in https://reviews.llvm.org/rGa01579ad0a1bde4d90f4fb656f07586c3097428a. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 ___ cfe-commits mailin

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta created this revision. xgupta added a reviewer: aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://github.com/llvm/llvm-project/issues/52873. Don't warn in C++2A mode

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta updated this revision to Diff 436557. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CXX/expr/expr.const/p2-0x.cpp clang/test/SemaCXX/constant

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta updated this revision to Diff 436746. xgupta added a comment. . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CXX/expr/expr.const/p2-0x.cpp clang/test/SemaCXX/constant-expression-cxx

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta closed this revision. xgupta added a comment. In D127518#3581620 , @aaron.ballman wrote: > LGTM! Please add a release note about the issue that was fixed when landing. Done, Thank you for reviewing. Committed in https://reviews.llvm.org/rG48e18

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta created this revision. xgupta added reviewers: thieta, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix https://github.com/llvm/llvm-project/issues/23841. Lots of beginners a

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4507124 , @aaron.ballman wrote: > In D155457#4507107 , @xgupta wrote: > >> In D155457#4506405 , @xbolva00 >> wrote: >> >>> You should

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. In D142609#4507696 , @nathanchance wrote: > I took the most recent version for a spin against the Linux kernel. The > couple of issues that a previous revision of the warning flagged > (https://github.com/ClangBuiltLinux/linux/i

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4511392 , @aaron.ballman wrote: > Whether `size_t` comes from the system header or whether it's manually > deduced from `decltype(sizeof(0))` should make no difference as far as the > frontend is concerned; they shoul

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. In D142609#4510995 , @aaron.ballman wrote: > In D142609#4510596 , @xbolva00 > wrote: > >> In my opinion it makes sense to adjust that kernel code based on this >> warning in the current

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdfdfd306cfaf: [Clang] Fix -Wconstant-logical-operand when LHS is a constant (authored by shivam-amd). Changed prior to co

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. Thanks, @nickdesaulniers for reviewing and @nathanchance for testing the change. @aaron.ballman, I also agree with @xbolva00 seems warning in kernel code is valid but I also agree with your comment about macro, may be better to track the macro-related issue with another

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 541866. xgupta added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/type-limit-com

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4511652 , @aaron.ballman wrote: > In the x86 compilation: `sizeof(std::size_t) < sizeof(uint64_t)` is true, so > we test the other expression; because `Size` is greater than `__SIZE_MAX__` > the function returns false

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 542846. xgupta added a comment. update test for Windows system Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Se

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. Just normal ping, @aaron.ballman, can please take a look, pre-merge checks are also passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 __

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

xgupta added a comment. This LGTM, but can't officially accept the patch so please wait for another reviewer to accept it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

xgupta added a comment. Wanted to point out that there is a clang-tidy check in review doing the similar thing - https://reviews.llvm.org/D144429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142800/new/ https://reviews.llvm.org/D142800 ___

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

xgupta added a comment. Other than these three points everything looks good to me. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:71 + +bool EmptyCatchCheck::isLanguageVersionSupported( +const LangOptions &LangOpts) const { This can b

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

xgupta closed this revision. xgupta added a comment. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. https://reviews.llvm.org/rG475440703238ca32adab6c3fe5e0039c3f96d1a5 committed the remaining shebang change from python to python3. Repository

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, but we can wait for a couple of before committing in case other reviewers have more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543282. xgupta added a comment. Rebase and address one last comment. I think now it will be fine to commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/DeclRef

[PATCH] D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value.

xgupta closed this revision. xgupta added a comment. Herald added subscribers: wangpc, PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This was committed in https://github.com/llvm/llvm-project/commit/03ded5497a2f458b6af054fa7bac0da0240e7

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

xgupta added a comment. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a project: All. Reverse ping, this patch was never gets committed after being accepted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78223/new/ https://reviews.

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543287. xgupta added a comment. Added release note and fix unit test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/Dec

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543299. xgupta added a comment. Update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp cl

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543300. xgupta marked 2 inline comments as done. xgupta added a comment. minor update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-ti

  1   2   3   >