xgupta added inline comments.
================
Comment at: clang/lib/Basic/Targets/OSTargets.h:704
+ if (OsVersion >= std::make_pair(7, 3))
+ Builder.defineMacro("_AIX73");
----------------
Jake-Egan wrote:
> xgupta wrote:
> > Jake-Egan wrote:
> > > xgupta wrote:
> > > > Seems this line need formatting?
> > > I originally had it matching the format of the other _AIX macro
> > > definitions, but clang-format modified it to this.
> > I think clang-format is there to maintain consistency in the codebase. You
> > can ignore it if it is doing the opposite.
> Do you suggest that I revise the formatting then?
Yeah, I think so, neglect clang-format. But you can wait for other reviewer's
comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105185/new/
https://reviews.llvm.org/D105185
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
