r304760 - PR33318: Add missing full-expression checking to static_assert expression.

2017-06-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Jun 5 20:34:24 2017 New Revision: 304760 URL: http://llvm.org/viewvc/llvm-project?rev=304760&view=rev Log: PR33318: Add missing full-expression checking to static_assert expression. This fixes missing lambda-captures for variables referenced only inside a static_assert (

Re: [PATCH] D33719: Add _Float16 as a C/C++ source language type

2017-06-06 Thread Richard Smith via cfe-commits
On 5 June 2017 at 03:49, Sjoerd Meijer via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Yes, initially I wanted to unconditionally support _Float16, but now that > you asked how about it, I agree it makes more sense to enable it for C11 > and C++11 and have: KEYWORD(_Float16

r304852 - Improve error recovery for missing 'template' keyword in contexts where the

2017-06-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 6 19:29:44 2017 New Revision: 304852 URL: http://llvm.org/viewvc/llvm-project?rev=304852&view=rev Log: Improve error recovery for missing 'template' keyword in contexts where the template is valid with or without it (with different meanings). If we see "dependent.x<.

r304862 - Fix a couple of class template argument deduction crashes with libc++'s tuple.

2017-06-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 6 21:42:27 2017 New Revision: 304862 URL: http://llvm.org/viewvc/llvm-project?rev=304862&view=rev Log: Fix a couple of class template argument deduction crashes with libc++'s tuple. RecursiveASTVisitor was not properly recursing through a SubstTemplateTypeParmTypes,

r304946 - [c++1z] Support deducing B in noexcept(B).

2017-06-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 7 16:46:22 2017 New Revision: 304946 URL: http://llvm.org/viewvc/llvm-project?rev=304946&view=rev Log: [c++1z] Support deducing B in noexcept(B). This is not required by the standard (yet), but there seems to be reasonable support for this being a defect according to

Re: r304956 - [ODRHash] Change the fall-back diagnostic error.

2017-06-07 Thread Richard Smith via cfe-commits
On 7 June 2017 at 17:56, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Wed Jun 7 19:56:21 2017 > New Revision: 304956 > > URL: http://llvm.org/viewvc/llvm-project?rev=304956&view=rev > Log: > [ODRHash] Change the fall-back diagnostic error. > > Provid

r304957 - Weaken restriction in r304862 to allow implicit deduction guides to reference

2017-06-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 7 20:08:50 2017 New Revision: 304957 URL: http://llvm.org/viewvc/llvm-project?rev=304957&view=rev Log: Weaken restriction in r304862 to allow implicit deduction guides to reference the injected-class-name of a specialization that uses a partial / explicit specializati

r304960 - Simplify.

2017-06-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 7 21:05:55 2017 New Revision: 304960 URL: http://llvm.org/viewvc/llvm-project?rev=304960&view=rev Log: Simplify. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema

r305045 - Remove 'Filename' parameter from BeginSourceFileAction.

2017-06-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 8 20:36:10 2017 New Revision: 305045 URL: http://llvm.org/viewvc/llvm-project?rev=305045&view=rev Log: Remove 'Filename' parameter from BeginSourceFileAction. No-one was using this, and it's not meaningful in general -- FrontendActions can be run on inputs that don't

r305101 - Add #pragma clang module build/endbuild pragmas for performing a module build

2017-06-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 9 14:22:32 2017 New Revision: 305101 URL: http://llvm.org/viewvc/llvm-project?rev=305101&view=rev Log: Add #pragma clang module build/endbuild pragmas for performing a module build as part of a compilation. This is intended for two purposes: 1) Writing self-containe

r305116 - Add -frewrite-imports flag.

2017-06-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 9 16:24:02 2017 New Revision: 305116 URL: http://llvm.org/viewvc/llvm-project?rev=305116&view=rev Log: Add -frewrite-imports flag. If specified, when preprocessing, the contents of imported .pcm files will be included in preprocessed output. The resulting preprocesse

Re: r305110 - [ODRHash] Add support for TemplateArgument types.

2017-06-09 Thread Richard Smith via cfe-commits
Could this failure be due to your change: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/8365/steps/compile.llvm.stage2/logs/stdio ? On 9 June 2017 at 14:00, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Jun 9 16

r305121 - Attempt to fix shared library build: RewriteFrontend depends on Serialization after r305116.

2017-06-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 9 17:02:33 2017 New Revision: 305121 URL: http://llvm.org/viewvc/llvm-project?rev=305121&view=rev Log: Attempt to fix shared library build: RewriteFrontend depends on Serialization after r305116. Modified: cfe/trunk/lib/Frontend/Rewrite/CMakeLists.txt Modified:

r305126 - 27037: Use correct CVR qualifier on an upcast on method pointer call

2017-06-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 9 17:25:28 2017 New Revision: 305126 URL: http://llvm.org/viewvc/llvm-project?rev=305126&view=rev Log: 27037: Use correct CVR qualifier on an upcast on method pointer call Patch by Taiju Tsuiki! Differential Revision: https://reviews.llvm.org/D33875 Added: cfe/

Re: r304081 - [coroutines] Mark cxx_status.html of Coroutines TS as (SVN)

2017-06-19 Thread Richard Smith via cfe-commits
I don't think we're quite done yet: we still seem to be missing serialization / deserialization support for coroutines. On 27 May 2017 at 15:54, Gor Nishanov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gornishanov > Date: Sat May 27 17:54:52 2017 > New Revision: 304081 > > URL:

r305758 - Support non-identifier module names when preprocessing modules.

2017-06-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Jun 19 18:09:36 2017 New Revision: 305758 URL: http://llvm.org/viewvc/llvm-project?rev=305758&view=rev Log: Support non-identifier module names when preprocessing modules. Modified: cfe/trunk/include/clang/Basic/Module.h cfe/trunk/lib/Basic/Module.cpp cfe/trun

Re: [PATCH] D34251: Add a new driver option to disable warning about c++17's non-throwing exception specification in function signature

2017-06-19 Thread Richard Smith via cfe-commits
On 19 June 2017 at 16:25, Duncan P. N. Exon Smith via Phabricator via cfe-commits wrote: > dexonsmith added a comment. > > > We use the `-Wc++NN-compat-` prefix on all the other subwarnings of > `-Wc++NN-compat` warnings > > Interesting; I thought I saw a counter-example recently, and took that a

r305764 - Turn off "disable free" mode when preprocessing imported module files in

2017-06-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Jun 19 20:31:53 2017 New Revision: 305764 URL: http://llvm.org/viewvc/llvm-project?rev=305764&view=rev Log: Turn off "disable free" mode when preprocessing imported module files in -frewrite-imports mode. This could end up accumulating a very large amount of intermediate

Re: r305860 - Special-case handling of destructors in override lists when dumping ASTs.

2017-06-20 Thread Richard Smith via cfe-commits
On 20 June 2017 at 14:30, Lang Hames via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: lhames > Date: Tue Jun 20 16:30:43 2017 > New Revision: 305860 > > URL: http://llvm.org/viewvc/llvm-project?rev=305860&view=rev > Log: > Special-case handling of destructors in override lists when d

Re: [PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

2017-06-21 Thread Richard Smith via cfe-commits
Does the GCC warning warn on the same cases? On 21 Jun 2017 10:24 am, "Akira Hatanaka via Phabricator" < revi...@reviews.llvm.org> wrote: > ahatanak added a comment. > > I didn't know gcc had its own option. This change seems reasonable to me. > > Since c++1z-compat-mangling was added just a few

Re: [PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

2017-06-21 Thread Richard Smith via cfe-commits
There's plenty of precedent for supporting a name we like for a flag, and also supporting an alias for GCC compatibility (especially for warning flags). On 21 June 2017 at 10:56, Raphael Isemann via Phabricator < revi...@reviews.llvm.org> wrote: > teemperor added a comment. > > @ahatanak I think

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-21 Thread Richard Smith via cfe-commits
whether a declaration is visible in a particular lookup context.) > Thanks, > > On Wed, May 17, 2017 at 7:29 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > > Date: Wed May 17 21:29:20 2017 > > New Revision: 303322 > > > > URL: http://ll

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-21 Thread Richard Smith via cfe-commits
story with regard to whether a declaration is visible in a > > particular lookup context.) > > Oh, that's bad. > > Is there any workaround we can do on top of this change for now in > order to have the previous behavior for non-LSV and ObjC? This is > keeping Swift

r306065 - PR33002: When we instantiate the definition of a static data member, we might

2017-06-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 22 17:18:46 2017 New Revision: 306065 URL: http://llvm.org/viewvc/llvm-project?rev=306065&view=rev Log: PR33002: When we instantiate the definition of a static data member, we might have attached an initializer to the in-class declaration. If so, include the initialize

r306075 - PR33552: Distinguish between declarations that are owned by no module and

2017-06-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 22 20:04:34 2017 New Revision: 306075 URL: http://llvm.org/viewvc/llvm-project?rev=306075&view=rev Log: PR33552: Distinguish between declarations that are owned by no module and declarations that are owned but unconditionally visible. This allows us to set declaration

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-22 Thread Richard Smith via cfe-commits
On 22 June 2017 at 16:18, Michael Gottesman wrote: > > On Jun 21, 2017, at 4:56 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On 21 June 2017 at 16:55, Bruno Cardoso Lopes > wrote: > >> On Wed, Jun 21, 2017 at 4:44 PM, Richard Smit

r306077 - Add missing file from r306075.

2017-06-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 22 20:18:27 2017 New Revision: 306077 URL: http://llvm.org/viewvc/llvm-project?rev=306077&view=rev Log: Add missing file from r306075. Added: cfe/trunk/test/Misc/Inputs/module.modulemap Added: cfe/trunk/test/Misc/Inputs/module.modulemap URL: http://llvm.org/view

Re: r304207 - Allow for unfinished #if blocks in preambles

2017-06-23 Thread Richard Smith via cfe-commits
On 23 June 2017 at 13:34, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Since this change went in I'm seeing spurious errors whenever editing > a header file, filed https://bugs.llvm.org/show_bug.cgi?id=33574 for > that. Does fixing the reversed condition I pointed out f

r306270 - Testcase missed from r306075.

2017-06-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jun 25 21:41:22 2017 New Revision: 306270 URL: http://llvm.org/viewvc/llvm-project?rev=306270&view=rev Log: Testcase missed from r306075. Added: cfe/trunk/test/Modules/interface-visibility.m Added: cfe/trunk/test/Modules/interface-visibility.m URL: http://llvm.org/v

r320697 - Warn if we find a Unicode homoglyph for a symbol in an identifier.

2017-12-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 14 05:15:08 2017 New Revision: 320697 URL: http://llvm.org/viewvc/llvm-project?rev=320697&view=rev Log: Warn if we find a Unicode homoglyph for a symbol in an identifier. Specifically, warn if: * we find a character that the language standard says we must treat as an

r320707 - [c++20] P0515R3: Parsing support and basic AST construction for operator <=>.

2017-12-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 14 07:16:18 2017 New Revision: 320707 URL: http://llvm.org/viewvc/llvm-project?rev=320707&view=rev Log: [c++20] P0515R3: Parsing support and basic AST construction for operator <=>. Adding the new enumerator forced a bunch more changes into this patch than I would hav

r320709 - When attempting to complete an incomplete array bound type in an expression,

2017-12-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 14 07:40:16 2017 New Revision: 320709 URL: http://llvm.org/viewvc/llvm-project?rev=320709&view=rev Log: When attempting to complete an incomplete array bound type in an expression, update the type from the definition even if we didn't instantiate a definition. We may

Re: r320982 - Revert r320978 "No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17"

2017-12-18 Thread Richard Smith via cfe-commits
Can we just strip the noexcept from the function type before emitting the fsan type info? On 18 Dec 2017 13:52, "Stephan Bergmann via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: sberg Date: Mon Dec 18 05:51:48 2017 New Revision: 320982 URL: http://llvm.org/viewvc/llvm-project?rev=3

Re: r320982 - Revert r320978 "No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17"

2017-12-19 Thread Richard Smith via cfe-commits
On 18 Dec 2017 15:23, "Stephan Bergmann via cfe-commits" < cfe-commits@lists.llvm.org> wrote: On 12/18/2017 03:05 PM, Richard Smith wrote: > Can we just strip the noexcept from the function type before emitting the > fsan type info? > As is apparently already done when emitting the (not noexcept

r321297 - When instantiating a deduction guide, transform its name.

2017-12-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 21 11:43:39 2017 New Revision: 321297 URL: http://llvm.org/viewvc/llvm-project?rev=321297&view=rev Log: When instantiating a deduction guide, transform its name. Otherwise it will serve as a deduction guide for the wrong class template. Added: cfe/trunk/test/Sema

r321304 - Don't produce redundant parentheses warning for "A (::B); " and the like.

2017-12-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 21 12:50:39 2017 New Revision: 321304 URL: http://llvm.org/viewvc/llvm-project?rev=321304&view=rev Log: Don't produce redundant parentheses warning for "A (::B);" and the like. The parentheses here are not redundant as they affect the binding of the '::' token. Modif

r321318 - Suppress "redundant parens" warning for "A (::B())".

2017-12-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 21 14:26:47 2017 New Revision: 321318 URL: http://llvm.org/viewvc/llvm-project?rev=321318&view=rev Log: Suppress "redundant parens" warning for "A (::B())". This is a slightly odd construct (it's more common to see "A (::B)()") but can happen in friend declarations, a

Re: r321482 - [hotfix]

2017-12-27 Thread Richard Smith via cfe-commits
Hi Coby, please include a brief description of your commit on the first line of the commit message -- that's all that shows up on the commits list and in the summary view of some repository tools. On 27 Dec 2017 09:23, "Coby Tayree via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: cob

r321683 - Fix and simplify handling of return type for (generic) lambda conversion function to function pointer.

2018-01-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jan 2 15:52:42 2018 New Revision: 321683 URL: http://llvm.org/viewvc/llvm-project?rev=321683&view=rev Log: Fix and simplify handling of return type for (generic) lambda conversion function to function pointer. Previously, we would: * compute the type of the conversion

Re: trivial_abi

2018-01-02 Thread Richard Smith via cfe-commits
On 2 January 2018 at 15:33, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey, Richard et al. Akira and I were talking about the right ABI rule for > deciding can-pass-in-registers-ness for structs in the presence of > trivial_abi, and I think I like Akira's approach but want

r321686 - PR35697: look at the first declaration when determining whether a function or

2018-01-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jan 2 18:34:35 2018 New Revision: 321686 URL: http://llvm.org/viewvc/llvm-project?rev=321686&view=rev Log: PR35697: look at the first declaration when determining whether a function or variable is extern "C" in linkage calculations. Modified: cfe/trunk/lib/AST/Decl.c

Re: trivial_abi

2018-01-02 Thread Richard Smith via cfe-commits
On 2 January 2018 at 19:02, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: > > > > On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >

Re: trivial_abi

2018-01-03 Thread Richard Smith via cfe-commits
Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: >> >> >> >> On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> On 2 January 2018 at 15:33, John McCall via cfe-commits < >> cfe-commits@list

Re: trivial_abi

2018-01-03 Thread Richard Smith via cfe-commits
2, 2018, at 10:43 PM, Richard Smith wrote: >> >> On 2 January 2018 at 19:02, John McCall via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: >>> >>> >>> >

r321770 - PR33503: When a qualified name in a redeclaration names a prior declaration in

2018-01-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jan 3 15:03:54 2018 New Revision: 321770 URL: http://llvm.org/viewvc/llvm-project?rev=321770&view=rev Log: PR33503: When a qualified name in a redeclaration names a prior declaration in an inline namespace, update its semantic DeclContext to match. We would previously ge

Re: trivial_abi

2018-01-03 Thread Richard Smith via cfe-commits
:02, John McCall via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> >>>> >>>> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: >>>> >>>> >>>> >>>> On Jan 2, 2018, at 4:56 PM, Richard Smi

r321777 - PR35028: Retain duplicate alignas attributes in template instantiation.

2018-01-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jan 3 17:02:18 2018 New Revision: 321777 URL: http://llvm.org/viewvc/llvm-project?rev=321777&view=rev Log: PR35028: Retain duplicate alignas attributes in template instantiation. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/test/SemaTemplate/alignas.

r321779 - PR35045: Convert injected-class-name to its corresponding simple-template-id

2018-01-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jan 3 17:24:17 2018 New Revision: 321779 URL: http://llvm.org/viewvc/llvm-project?rev=321779&view=rev Log: PR35045: Convert injected-class-name to its corresponding simple-template-id during template argument deduction. We already did this when the injected-class-name wa

r321834 - Make attribute instantiation instantiate all attributes, not just the first of

2018-01-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jan 4 15:42:29 2018 New Revision: 321834 URL: http://llvm.org/viewvc/llvm-project?rev=321834&view=rev Log: Make attribute instantiation instantiate all attributes, not just the first of each kind. Attribute instantiation would previously default to instantiating each kin

r321899 - Add AST dumping support for _Generic expressions.

2018-01-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jan 5 13:31:07 2018 New Revision: 321899 URL: http://llvm.org/viewvc/llvm-project?rev=321899&view=rev Log: Add AST dumping support for _Generic expressions. Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/vie

r321916 - When name lookup finds a non-imported declaration and looks back along the

2018-01-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jan 5 16:09:23 2018 New Revision: 321916 URL: http://llvm.org/viewvc/llvm-project?rev=321916&view=rev Log: When name lookup finds a non-imported declaration and looks back along the redecl chain for an imported declaration, make sure to check the IDNS of prior imported de

r321921 - Serialize the IDNS for a UsingShadowDecl rather than recomputing it.

2018-01-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jan 5 17:07:05 2018 New Revision: 321921 URL: http://llvm.org/viewvc/llvm-project?rev=321921&view=rev Log: Serialize the IDNS for a UsingShadowDecl rather than recomputing it. Attempting to recompute it are doomed to fail because the IDNS of a declaration is not necessar

r321972 - Factor out common tautological comparison code from scalar and vector compare checking.

2018-01-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jan 7 13:57:48 2018 New Revision: 321972 URL: http://llvm.org/viewvc/llvm-project?rev=321972&view=rev Log: Factor out common tautological comparison code from scalar and vector compare checking. In passing, improve vector compare diagnostic to match scalar compare diag

r321973 - Add tests for three-way self- and array comparison.

2018-01-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jan 7 14:03:44 2018 New Revision: 321973 URL: http://llvm.org/viewvc/llvm-project?rev=321973&view=rev Log: Add tests for three-way self- and array comparison. Modified: cfe/trunk/test/SemaCXX/compare-cxx2a.cpp Modified: cfe/trunk/test/SemaCXX/compare-cxx2a.cpp URL:

r321976 - Fix a couple of wrong self-comparison diagnostics.

2018-01-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jan 7 14:18:05 2018 New Revision: 321976 URL: http://llvm.org/viewvc/llvm-project?rev=321976&view=rev Log: Fix a couple of wrong self-comparison diagnostics. Check whether we are comparing the same entity, not merely the same declaration, and don't assume that weak decla

r321977 - Remove bogus check for template specialization from self-comparison warning.

2018-01-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jan 7 14:25:55 2018 New Revision: 321977 URL: http://llvm.org/viewvc/llvm-project?rev=321977&view=rev Log: Remove bogus check for template specialization from self-comparison warning. The important check is that we're not within a template *instantiation*, which we check

r322024 - Factor out comparison handling for arithmetic types.

2018-01-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Jan 8 13:12:04 2018 New Revision: 322024 URL: http://llvm.org/viewvc/llvm-project?rev=322024&view=rev Log: Factor out comparison handling for arithmetic types. This is not quite NFC: we don't perform the usual arithmetic conversions unless we have an operand of arithmeti

r322030 - PR35862: Suppress -Wmissing-variable-declarations warning on inline variables,

2018-01-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Jan 8 13:46:42 2018 New Revision: 322030 URL: http://llvm.org/viewvc/llvm-project?rev=322030&view=rev Log: PR35862: Suppress -Wmissing-variable-declarations warning on inline variables, variable templates, and instantiations thereof. Modified: cfe/trunk/lib/Sema/Sema

Re: r310427 - Sema: disable implicit conversion from _Complex to real types in C++.

2018-01-09 Thread Richard Smith via cfe-commits
On 8 August 2017 at 16:18, Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tnorthover > Date: Tue Aug 8 16:18:05 2017 > New Revision: 310427 > > URL: http://llvm.org/viewvc/llvm-project?rev=310427&view=rev > Log: > Sema: disable implicit conversion from _Complex to re

Re: r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

2018-01-09 Thread Richard Smith via cfe-commits
On 9 January 2018 at 18:46, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Eric, > > On Mon, Jan 8, 2018 at 9:31 PM, Eric Fiselier wrote: > > I haven't done a ton of investigation yet, but I suspect this commit is > > responsible for breaking my LLVM module selfhost

r322236 - In C++17, when instantiating an out-of-line definition of an inline static data

2018-01-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jan 10 15:08:26 2018 New Revision: 322236 URL: http://llvm.org/viewvc/llvm-project?rev=322236&view=rev Log: In C++17, when instantiating an out-of-line definition of an inline static data member, don't forget to instantiate the initializer too. Modified: cfe/trunk/lib

r326298 - Update cxx_status to mark "SVN" items as "Clang 6" instead.

2018-02-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Feb 27 19:02:07 2018 New Revision: 326298 URL: http://llvm.org/viewvc/llvm-project?rev=326298&view=rev Log: Update cxx_status to mark "SVN" items as "Clang 6" instead. Modified: cfe/trunk/www/cxx_status.html cfe/trunk/www/make_cxx_dr_status Modified: cfe/trunk/ww

r326299 - Fix a couple of cases where we would fail to correctly parse deduced class template specialization types.

2018-02-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Feb 27 19:02:23 2018 New Revision: 326299 URL: http://llvm.org/viewvc/llvm-project?rev=326299&view=rev Log: Fix a couple of cases where we would fail to correctly parse deduced class template specialization types. Specifically, we would not properly parse these types wit

r326493 - [www] Capitalize "Clang" when referring to the project, and generalize the

2018-03-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Mar 1 14:01:06 2018 New Revision: 326493 URL: http://llvm.org/viewvc/llvm-project?rev=326493&view=rev Log: [www] Capitalize "Clang" when referring to the project, and generalize the introduction on the front page page. We still use the lowercase "clang" spelling when ref

r326496 - [modules] Don't diagnose "redefinition" of a friend with a pending definition

2018-03-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Mar 1 14:20:13 2018 New Revision: 326496 URL: http://llvm.org/viewvc/llvm-project?rev=326496&view=rev Log: [modules] Don't diagnose "redefinition" of a friend with a pending definition if the other definition is a merged copy of the same function. Added: cfe/trunk/te

r326624 - PR36581: Support data recursion over Stmts in AST matchers.

2018-03-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Mar 2 13:55:03 2018 New Revision: 326624 URL: http://llvm.org/viewvc/llvm-project?rev=326624&view=rev Log: PR36581: Support data recursion over Stmts in AST matchers. Modified: cfe/trunk/lib/ASTMatchers/ASTMatchFinder.cpp Modified: cfe/trunk/lib/ASTMatchers/ASTMatch

r326741 - Fix typo in comment.

2018-03-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Mar 5 12:54:34 2018 New Revision: 326741 URL: http://llvm.org/viewvc/llvm-project?rev=326741&view=rev Log: Fix typo in comment. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/li

r326973 - When substituting previously-checked template arguments into a template

2018-03-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Mar 7 17:07:33 2018 New Revision: 326973 URL: http://llvm.org/viewvc/llvm-project?rev=326973&view=rev Log: When substituting previously-checked template arguments into a template template parameter that is an expanded parameter pack, only substitute into the current slice

r327099 - PR36645: Go looking for an appropriate array bound when constant-evaluating a

2018-03-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Mar 8 18:00:01 2018 New Revision: 327099 URL: http://llvm.org/viewvc/llvm-project?rev=327099&view=rev Log: PR36645: Go looking for an appropriate array bound when constant-evaluating a name of an array object. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trun

Re: r327099 - PR36645: Go looking for an appropriate array bound when constant-evaluating a

2018-03-08 Thread Richard Smith via cfe-commits
Might be a good candidate for Clang 6.0.1. On 8 March 2018 at 18:00, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Mar 8 18:00:01 2018 > New Revision: 327099 > > URL: http://llvm.org/viewvc/llvm-project?rev=327099&view

r327195 - Revert r326946. It caused stack overflows by significantly increasing the size of a CallArgList.

2018-03-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Mar 9 17:47:22 2018 New Revision: 327195 URL: http://llvm.org/viewvc/llvm-project?rev=327195&view=rev Log: Revert r326946. It caused stack overflows by significantly increasing the size of a CallArgList. Removed: cfe/trunk/test/CodeGenCXX/amdgcn-func-arg.cpp Modifie

Re: r326946 - CodeGen: Fix address space of indirect function argument

2018-03-09 Thread Richard Smith via cfe-commits
Hi, This change increases the size of a CallArg, and thus that of a CallArgList, dramatically (an LValue is *much* larger than an RValue, and unlike an RValue, does not appear to be at all optimized for size). This results in CallArgList (which contains inline storage for 16 CallArgs) ballooning i

Re: [libcxxabi] r327226 - [demangler] Support for structured bindings.

2018-03-10 Thread Richard Smith via cfe-commits
On 10 Mar 2018 13:33, "Erik Pilkington via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: epilk Date: Sat Mar 10 13:31:15 2018 New Revision: 327226 URL: http://llvm.org/viewvc/llvm-project?rev=327226&view=rev Log: [demangler] Support for structured bindings. Modified: libcxxabi/tr

r327545 - [www] Update C++ DR status to match latest issues list.

2018-03-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Mar 14 11:19:41 2018 New Revision: 327545 URL: http://llvm.org/viewvc/llvm-project?rev=327545&view=rev Log: [www] Update C++ DR status to match latest issues list. Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL: http://llvm

r327546 - Update DR script to mark Clang 6 as 'done' not 'svn'.

2018-03-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Mar 14 11:20:45 2018 New Revision: 327546 URL: http://llvm.org/viewvc/llvm-project?rev=327546&view=rev Log: Update DR script to mark Clang 6 as 'done' not 'svn'. Modified: cfe/trunk/www/make_cxx_dr_status Modified: cfe/trunk/www/make_cxx_dr_status URL: http://llvm.o

r327705 - Implement C++ DR727, which permits explicit specializations at class scope.

2018-03-16 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Mar 16 06:36:56 2018 New Revision: 327705 URL: http://llvm.org/viewvc/llvm-project?rev=327705&view=rev Log: Implement C++ DR727, which permits explicit specializations at class scope. More generally, this permits a template to be specialized in any scope in which it could

r327769 - [cxx_status] Update to match Jacksonville 2018 motions.

2018-03-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Mar 17 07:28:47 2018 New Revision: 327769 URL: http://llvm.org/viewvc/llvm-project?rev=327769&view=rev Log: [cxx_status] Update to match Jacksonville 2018 motions. Also rearrange how we list DR motions: rather than listing them as part of some later standard, list them ag

r327770 - [cxx_status] Add entry for the Reflection TS.

2018-03-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Mar 17 07:34:21 2018 New Revision: 327770 URL: http://llvm.org/viewvc/llvm-project?rev=327770&view=rev Log: [cxx_status] Add entry for the Reflection TS. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm

r333587 - As discussed with SG10, bump version of __cpp_deduction_guides macro to indicate support for P0620R0.

2018-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 30 12:54:52 2018 New Revision: 333587 URL: http://llvm.org/viewvc/llvm-project?rev=333587&view=rev Log: As discussed with SG10, bump version of __cpp_deduction_guides macro to indicate support for P0620R0. Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp

r333589 - PR34520: after instantiating a non-templated member deduction guide, don't forget to push it into the class scope.

2018-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 30 13:24:10 2018 New Revision: 333589 URL: http://llvm.org/viewvc/llvm-project?rev=333589&view=rev Log: PR34520: after instantiating a non-templated member deduction guide, don't forget to push it into the class scope. Modified: cfe/trunk/lib/Sema/SemaTemplateIns

r333599 - PR37631: verify that a member deduction guide has the same access as its template.

2018-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 30 15:13:43 2018 New Revision: 333599 URL: http://llvm.org/viewvc/llvm-project?rev=333599&view=rev Log: PR37631: verify that a member deduction guide has the same access as its template. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk

r333606 - [www] Update C++ status to cover P0620.

2018-05-30 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 30 16:30:36 2018 New Revision: 333606 URL: http://llvm.org/viewvc/llvm-project?rev=333606&view=rev Log: [www] Update C++ status to cover P0620. While here, mark three-way comparison as in progress and bump "Clang 6" items from yellow to green. Modified: cfe/trun

r334106 - PR37680: fix faulty assertion condition.

2018-06-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 6 09:36:56 2018 New Revision: 334106 URL: http://llvm.org/viewvc/llvm-project?rev=334106&view=rev Log: PR37680: fix faulty assertion condition. When looking up a template name, we can find an overload set containing a function template and an unresolved non-type usin

Re: [PATCH] D47875: [MS ABI] Mangle unnamed empty enums (PR37723)

2018-06-07 Thread Richard Smith via cfe-commits
On Thu, 7 Jun 2018, 13:54 Hans Wennborg via Phabricator via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > hans added a comment. > > Please take a look. > > I couldn't figure out a way to get a mangled name for this without using > debug info. Do you have any ideas? > struct S { enum {} e; }

r334565 - Fix crash emitting transparent list initializer for a large aggregate.

2018-06-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 12 19:06:28 2018 New Revision: 334565 URL: http://llvm.org/viewvc/llvm-project?rev=334565&view=rev Log: Fix crash emitting transparent list initializer for a large aggregate. Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp cfe/trunk/test/CodeGenCXX/value-init.cp

r334674 - [www] Update cxx_status page for Rapperswil motions.

2018-06-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 13 17:05:28 2018 New Revision: 334674 URL: http://llvm.org/viewvc/llvm-project?rev=334674&view=rev Log: [www] Update cxx_status page for Rapperswil motions. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/view

r334677 - P0096R5, P0941R2: Update to match latest feature test macro specification.

2018-06-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 13 17:40:20 2018 New Revision: 334677 URL: http://llvm.org/viewvc/llvm-project?rev=334677&view=rev Log: P0096R5, P0941R2: Update to match latest feature test macro specification. Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp cfe/trunk/test/Lexer/cxx-fe

r334763 - [c++17] If a class inherits virtual functions from a base class, it is

2018-06-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 14 13:03:22 2018 New Revision: 334763 URL: http://llvm.org/viewvc/llvm-project?rev=334763&view=rev Log: [c++17] If a class inherits virtual functions from a base class, it is not an aggregtae. Modified: cfe/trunk/lib/AST/DeclCXX.cpp cfe/trunk/test/CXX/dcl.decl

Re: r334677 - P0096R5, P0941R2: Update to match latest feature test macro specification.

2018-06-17 Thread Richard Smith via cfe-commits
lt; 201611: > ValueError: invalid literal for int() with base 10: '201703L' > > On Wed, Jun 13, 2018 at 5:44 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Wed Jun 13 17:40:20 2018 >> New Revi

[libcxx] r334917 - Fix libcxx tests after clang r334677.

2018-06-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jun 17 12:58:45 2018 New Revision: 334917 URL: http://llvm.org/viewvc/llvm-project?rev=334917&view=rev Log: Fix libcxx tests after clang r334677. Feature test macro versions may have a trailing L. Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/t

Re: r334677 - P0096R5, P0941R2: Update to match latest feature test macro specification.

2018-06-17 Thread Richard Smith via cfe-commits
ls/libcxx/test/config.py", line 467, in >> configure_features >> int(macros['__cpp_deduction_guides']) < 201611: >> ValueError: invalid literal for int() with base 10: '201703L' >> >> On Wed, Jun 13, 2018 at 5:44 PM Richard Smith via cfe-co

r335182 - Related to PR37768: improve diagnostics for class name shadowing.

2018-06-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 20 14:58:20 2018 New Revision: 335182 URL: http://llvm.org/viewvc/llvm-project?rev=335182&view=rev Log: Related to PR37768: improve diagnostics for class name shadowing. Diagnose the name of the class being shadowed by using declarations, and improve the diagnostics f

r335191 - When a dependent alignas is applied to a non-dependent typedef,

2018-06-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jun 20 16:36:55 2018 New Revision: 335191 URL: http://llvm.org/viewvc/llvm-project?rev=335191&view=rev Log: When a dependent alignas is applied to a non-dependent typedef, prioritize the error for the bad subject over the error for the dependent / non-dependent mismatch.

r335381 - Restore pre-r335182 behavior for naming inherited constructors as

2018-06-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 22 12:50:19 2018 New Revision: 335381 URL: http://llvm.org/viewvc/llvm-project?rev=335381&view=rev Log: Restore pre-r335182 behavior for naming inherited constructors as members of dependent contexts. This permits cases where the names before and after the '::' in a d

r344070 - PR39231: fix null dereference when diagnosing deduction failure due to

2018-10-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 9 11:49:22 2018 New Revision: 344070 URL: http://llvm.org/viewvc/llvm-project?rev=344070&view=rev Log: PR39231: fix null dereference when diagnosing deduction failure due to conflicting values for a non-type pack. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp

r344199 - Add a flag to remap manglings when reading profile data information.

2018-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Oct 10 16:13:35 2018 New Revision: 344199 URL: http://llvm.org/viewvc/llvm-project?rev=344199&view=rev Log: Add a flag to remap manglings when reading profile data information. This can be used to preserve profiling information across codebase changes that have widespread

r344201 - Update documentation to indicate that profile remapping support is only

2018-10-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Oct 10 16:33:18 2018 New Revision: 344201 URL: http://llvm.org/viewvc/llvm-project?rev=344201&view=rev Log: Update documentation to indicate that profile remapping support is only implemented for the new pass manager so far. Modified: cfe/trunk/docs/UsersManual.rst M

r344319 - Update user's manual documentation of profile remapping file to match

2018-10-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 11 16:48:11 2018 New Revision: 344319 URL: http://llvm.org/viewvc/llvm-project?rev=344319&view=rev Log: Update user's manual documentation of profile remapping file to match llvm-cxxmap documentation. Add a hint as to how to perform off-line profile data remapping. M

r344800 - Add basic test that we perform lifetime extension in the expected

2018-10-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Oct 19 12:01:31 2018 New Revision: 344800 URL: http://llvm.org/viewvc/llvm-project?rev=344800&view=rev Log: Add basic test that we perform lifetime extension in the expected situations. Added: cfe/trunk/test/CXX/special/class.temporary/p6.cpp Added: cfe/trunk/test/CX

r344801 - PR24164, PR39336: init-captures are not distinct full-expressions.

2018-10-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Oct 19 12:01:34 2018 New Revision: 344801 URL: http://llvm.org/viewvc/llvm-project?rev=344801&view=rev Log: PR24164, PR39336: init-captures are not distinct full-expressions. Rather, they are subexpressions of the enclosing lambda-expression, and any temporaries in them a

<    1   2   3   4   5   6   7   8   9   10   >