[PATCH] D59745: [NFC] Move writeFuncOrVarName out of class CodegenNameGenerator so that it can be reused more easily.

plotfi created this revision. plotfi added reviewers: compnerd, akyrtzi. Herald added subscribers: cfe-commits, jdoerfert, arphaman. Herald added a project: clang. I simply want a helper function to use for printing out mangled Decl names. I think this could be a pretty simple straightforward pat

[PATCH] D59745: [NFC] Move writeFuncOrVarName out of class CodegenNameGenerator so that it can be reused more easily.

plotfi abandoned this revision. plotfi added a comment. Found a better way to do what I needed without this unnecessary change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59745/new/ https://reviews.llvm.org/D59745 ___

[PATCH] D60974: Clang IFSO driver action.

plotfi created this revision. Herald added subscribers: cfe-commits, eraman, mgorny. Herald added a project: clang. This enables -emit-ifso to generate an interface library for each .o file. Currently it just writes a text file with the mangled names in it. Repository: rC Clang https://revie

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:185 +OS << (IsRDOLate ? "late-parsed-decl: " : "") + << (IsRDOLate ? ND->getNameAsString() : MangledName) << "\n"; +// For now, lets just dump t

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1474591 , @jakehehrlich wrote: > Can you elaborate on the use case for this? Like can you explain end to end > how this would be used? There are a few that I have in mind. 1. -emit-ifso could be added to a build to pr

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 196291. plotfi added a comment. Herald added a subscriber: mgrang. I've added an output format. The YAML coming out of -emit-ifso can now run through yaml2obj to produce a striped .o file. Those .o files can be handled by an existing linker. Repository: r

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1474994 , @compnerd wrote: > Note that I am not advocating that this change go in as is - I think that > this is far from something which would be useful, and until it can produce > something meaningful, this shouldn't r

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1474777 , @jakehehrlich wrote: > In D60974#1474751 , @plotfi wrote: > > > There are a few that I have in mind. > > > > 1. -emit-ifso could be added to a build to produce .so files

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1476084 , @jakehehrlich wrote: > Why is this better than producing output from the output of the static linker > at the end? Also how do we plan on integrating this with llvm-elfabi so that > we don't have unnecessarily

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 196516. plotfi added a comment. Updated to support properly setting OBJECT/FUNC types as well as section flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files:

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1477302 , @phosek wrote: > Aside from comments that @jakehehrlich already made which I agree with, I'm > also concerned about the use of `yaml2obj`. AFAIK that tool has always been > intended as a testing, not a producti

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 196535. plotfi added a comment. First stab at trying to properly handle Weak Symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1477761 , @jakehehrlich wrote: > In D60974#1477690 , @compnerd wrote: > > > @jakehehrlich - when do you expect to have your idea put up? I don't think > > that it is fair to have

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1479467 , @jakehehrlich wrote: > As an example, .tbe and .tbd files use YAML but in a very specific well > defined structure. yaml2obj also uses a specific format which is actually > well defined, it just doesn't map on

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. So, @compnerd and I have discussed and we'd like to propose a yaml schema that can express what we need for ifsos for the Sections and the Symbols. Something like: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. So, @compnerd and I have discussed and we'd like to propose a yaml schema that can express what we need for ifsos for the Sections and the Symbols. For the Symbols we want: Symbols: - Name:_dataA Type:STT_OBJECT Section:

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483210 , @jakehehrlich wrote: > In D60974#1483164 , @plotfi wrote: > > > So, @compnerd and I have discussed and we'd like to propose a yaml schema > > that can express what we ne

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483209 , @jakehehrlich wrote: > I think I know the format that I'd like *roughly*. I haven't worked out how > to handle COMDAT and section groups yet. Roland seems to think that COMDAT > and section groups will be an

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483209 , @jakehehrlich wrote: > I think I know the format that I'd like *roughly*. I haven't worked out how > to handle COMDAT and section groups yet. Roland seems to think that COMDAT > and section groups will be an

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483265 , @jakehehrlich wrote: > In D60974#1483240 , @plotfi wrote: > > > Me and @compnerd had discussed a more abstracted format like this but > > decided it was best to just use

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483480 , @jakehehrlich wrote: > In D60974#1483399 , @plotfi wrote: > > > In D60974#1483265 , @jakehehrlich > > wrote: > > > > > In D60974

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1484744 , @jakehehrlich wrote: > > Does llvm-elfabi consume your proposed Schema format? Has it landed yet? > > No, I just proposed it and explained my reasoning. If you wanted to add this > format to TextAPI that would

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485417 , @jakehehrlich wrote: > Background: > There are two parts to this. TextAPI is a public interface of textual > representations for these sorts of files that already exists in llvm. There > exist ELF and MachO t

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483479 , @jakehehrlich wrote: > In D60974#1483380 , @plotfi wrote: > > > Also, curious on the lack of denoting the sections and which symbols go in > > which sections? Do you jus

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485552 , @jakehehrlich wrote: > Well I think it should be a seperate tool but because the code inside > llvm-elfabi isn't a library yet (though it is written to be used like one) we > can do that by adding a symlink an

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485611 , @jakehehrlich wrote: > Oh and "ifo" is a good name. I still would like to keep the clang flag as -emit-ifso; the intermediate unmerged files are analogous to object files but the final result should be somet

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485610 , @jakehehrlich wrote: > > Wanted to mention, from my testing with yaml2obj, I needed the section > > flags (SHF_EXECINSTR, SHF_WRITE, SHF_ALLOC, etc) otherwise nm was spitting > > the wrong thing. How are you g

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1485607 , @jakehehrlich wrote: > The linker doesn't look at section permissions. In fact the only thing it > even looks at the section index for is to check for alignment for copy > relocations which is something most p

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 197645. plotfi added a comment. - change "ifso" for intermediate files to "ifo" - Updated schemas. I have both our own proposal and the proposal that resembles elfeabi here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added a comment. In D60974#1486631 , @jakehehrlich wrote: > In D60974#1486384 , @compnerd wrote: > > > @jakehehrlich - unfortunately, removing the attributes on the s

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198152. plotfi added a comment. Herald added subscribers: llvm-commits, MaskRay, hiraditya, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. Adding support for multiple formats using -interface-stubs-version=. I'll add ano

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198157. plotfi added a comment. Changing experimental flag to -interface-stubs-version=experimental-ifo-elf-v1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: c

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1490358 , @rupprecht wrote: > I didn't follow the technical details, but I don't see anything wrong with > moving forward on this patch. I think this seems like an interesting idea > worth experimenting with. > > In D609

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @jakehehrlich @compnerd ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 6 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Options.td:626 HelpText<"Use the LLVM representation for assembler and object files">; +def emit_ifso : Flag<["-"], "emit-interface-stubs">, Flags<[CC1Option]>, Group

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3590 +Twine("-interface-stubs-version=") + +Args.getLastArgValue(options::OPT_ifso_version_EQ))); + } compnerd wr

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:223 +for (auto *I : cast(ND)->decls()) + HandleNamedDecl(dyn_cast(I), Symbols, RDO); +return true; compnerd wrote: > Hmm, do we

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198902. plotfi added a comment. addressing a lot of @compnerd 's feedback. Still lots of templating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/inclu

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 202976. plotfi added a comment. Adding a test for inheritance and constructors/destroctors. Also addressing feedback from @alexshap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 203464. plotfi added a comment. Updated hidden parent/child class inheritance cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 203465. plotfi added a comment. git mv'ed hidden-class-inheritance.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td c

[PATCH] D61914: [Support][Test] Time profiler: add regression test

plotfi added a comment. cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you mean to pass the target explicitly ? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914

[PATCH] D61914: [Support][Test] Time profiler: add regression test

plotfi added inline comments. Comment at: cfe/trunk/test/Driver/check-time-trace.cpp:1 +// RUN: %clangxx -ftime-trace %s 2>&1 | grep "Time trace json-file dumped to" \ +// RUN: | awk '{print $NF}' | xargs cat \ This test should probably have // REQUIRES: shell

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 203638. plotfi added a comment. -U99 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/Type

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 204187. plotfi marked 11 inline comments as done. plotfi added a comment. addressing @rupprecht's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added a comment. In D60974#1534662 , @rupprecht wrote: > Can you upload this patch with context? Either use arc or upload w/ -U9 Thanks for the review. > I seem to have a lot of comments, but they're a

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 204308. plotfi marked 2 inline comments as done. plotfi added a comment. Improving support for visibility correctness with classes, methods and inheritance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/ne

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 204978. plotfi marked 17 inline comments as done. plotfi added a comment. Addressing @compnerd's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/

[PATCH] D60974: Clang IFSO driver action.

plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:21 + StringRef InFile; + StringRef Format; + std::set ParsedTemplates; compnerd wrote: > An enumeration may be nicer. For now the format goes into the first line of

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 205191. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/incl

[PATCH] D60974: Clang IFSO driver action.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363626: [clang-ifs] Clang Interface Stubs, first version. (authored by zer0, committed by ). Changed prior to commit: https://reviews.llvm.org/D60974?vs=205191&id=205203#toc Repository: rL LLVM CHAN

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit MaskRay wrote: > This is a layering issue. clangIndex depends on clangFrontend so > clangFronten

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:22 + StringRef Format; + std::set ParsedTemplates; + MaskRay wrote: > Does `StringSet<>` work? It probably could work. I

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit asb wrote: > plotfi wrote: > > MaskRay wrote: > > > This is a layering issue. clangIndex depends

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. I had to back out r363646. While it worked for me building locally with and without shared lib, it appears to have caused bots to break. I will take another look at fixing it in about 10 hours. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1547682 , @MaskRay wrote: > @plotfi Sorry I have to revert this patch. This can also cause problems in > `-DBUILD_SHARED_LIBS=off` builds. clangFrontend files cannot `#include > "clang/Index/CodegenNameGenerator.h"`, I

[PATCH] D63535: [clang][AST] MangleUtil: A refactoring of CodegenNameGeneratorImpl (NFC).

plotfi created this revision. plotfi added reviewers: compnerd, ahatanak, akyrtzi, aaron.ballman. Herald added subscribers: cfe-commits, arphaman, dexonsmith. Herald added a project: clang. CodegenNameGeneratorImpl is the most complete implementation of name mangling but it is in clang::Index. Th

[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

plotfi updated this revision to Diff 205625. plotfi added a comment. Addressing @compnerd's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63535/new/ https://reviews.llvm.org/D63535 Files: clang/include/clang/AST/Mangle.h clang/includ

[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/AST/Mangle.h:249-250 +struct ASTNameGenerator { + std::unique_ptr MC; + llvm::DataLayout DL; + aaron.ballman wrote: > Do these still need to be public members

[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

plotfi updated this revision to Diff 205643. plotfi added a comment. Update to address @aaron.ballman's catch that ASTNameGenerator was not private enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63535/new/ https://reviews.llvm.org/D63535 F

[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: clang/lib/AST/Mangle.cpp:25 #include "llvm/ADT/StringExtras.h" +#include "llvm/IR/Mangler.h" #include "llvm/Support/ErrorHandling.h" aaron.ballman wrote: > Do we have to link in

[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rL363878: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC). (authored by zer0, committed by ). Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Cha

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 205686. plotfi added a comment. This should address the shared lib issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Basic/DiagnosticFr

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi created this revision. plotfi added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63584 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp Index:

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi updated this revision to Diff 205728. plotfi added a comment. moving datalayout.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63584/new/ https://reviews.llvm.org/D63584 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi updated this revision to Diff 205729. plotfi added a comment. full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63584/new/ https://reviews.llvm.org/D63584 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp Index:

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/AST/Mangle.cpp:343 -std::vector -ASTNameGenerator::getAllManglings(const ObjCContainerDecl *OCD) { + std::vector getAllManglings(const ObjCContainerDecl *OCD) { StringRef ClassNam

[PATCH] D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rL363908: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC). (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. This was re-landed in r363948 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi added a comment. @aaron.ballman Any thoughts on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2217 public: -typedef llvm::SmallVector PhasesTy; +typedef const std::vector PhasesTy; aaron.ballman wrote: > Why are you changing this to an STL type? I changed it because it didn

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 210431. plotfi marked 10 inline comments as done. plotfi added a comment. Updated to address @aaron.ballman 's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 F

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) +P.push_back(Phase); aaron.ballman wrote: > Can't you use the local `Phases` object instea

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 210609. plotfi added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files: clang/include/clang/Driver/Types.def clang/include/clang/Driver/Types.

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 210696. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files: clang/include/clang/Driver/Types.def clang/include/clang/Driver/Types.h clang/lib/Driver/Driver.cpp

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) +P.push_back(Phase); aaron.ballman wrote: > plotfi wrote: > > aaron.ballman wrote: > > > C

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366761: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi created this revision. plotfi added reviewers: aaron.ballman, compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Removing a few of the entries in the Flags for the Types.def table. - Removing redundant parts of getCompilationPhases(). Repository: rG LLVM

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi added a comment. In D65176#1598431 , @compnerd wrote: > This looks good to me generally. I don't fully understand the reason for `u` > being kept, is that something you intend to clean up in a subsequent patch? I’d like to remove it but I don’t

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi added a comment. This was a mistake. Updated the Wrong diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.

plotfi updated this revision to Diff 211651. plotfi marked an inline comment as done. plotfi added a comment. Removing 'A' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 Files: clang/include/clang/Driver

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi updated this revision to Diff 211652. plotfi added a comment. Removing 'A' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65176/new/ https://reviews.llvm.org/D65176 Files: clang/include/clang/Driver/Types.def clang/lib/Driver/Types.cpp

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Types.def:39-45 +// Some of the options in Flags have been removed, so far those are: +// a - The type should only be assembled: Now, check that Phases contains +//

[PATCH] D65176: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367063: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

plotfi created this revision. plotfi added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. New improved 'u'-less clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65308 Files: clang/include/clang/Driver/Types.def

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

plotfi updated this revision to Diff 211981. plotfi marked an inline comment as done. plotfi added a comment. addressing @compnerd 's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65308/new/ https://reviews.llvm.org/D65308 Files: clang/

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367345: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

plotfi updated this revision to Diff 212634. plotfi added a comment. trying to re-land, changing TY_ObjCXXHeader to TY_PP_ObjCXXHeader, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65308/new/ https://reviews.llvm.org/D65308 Files: clang/includ

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

plotfi added a comment. @jkorous DirectoryWatcherTests causes ninja check-clang to hang on my Ubuntu 18.04 computer. check-clang will not finish and I am forced to killall -9 DirectoryWatcherTests. My system has 40 threads and this repros on ext4 and btrfs. Repository: rL LLVM CHANGES SINC

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi created this revision. plotfi added reviewers: jkorous, compnerd. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. There are cases where the DirectoryWatcherTests just hang in a deadlock when there are inotify limits hit, with no error reporting. This patch

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:32 #include +#include This include should be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213209. plotfi added a comment. Cleanup some stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h cla

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213218. plotfi added a comment. More cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi added a comment. In D65704#1613688 , @compnerd wrote: > Rather than silently ignoring tests when the DirectoryWatcher isn't created, > can you please print an error message and exit with an error code to indicate > the test failed? llvm::Expecte

[PATCH] D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable.

plotfi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi added reviewers: compnerd, jkorous. Herald added a subscriber: dexonsmith. This should not affect actual behavior, but should pessimize the threading less by avoiding the situation where:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213221. plotfi added a comment. Fix a linux typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 /// Returns nullptr if \param Path doesn't exist or isn't a directory. /// Returns nullptr if OS kernel API told us we can't star

[PATCH] D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367968: [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable (authored by zer0, committed by )

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213515. plotfi added a comment. Improve comments, change Path.empty() errors for asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/Di

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213520. plotfi added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. add another assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704

  1   2   3   4   >