plotfi marked 2 inline comments as done. plotfi added inline comments.
================ Comment at: clang/lib/Frontend/FrontendActions.cpp:223 + for (auto *I : cast<T>(ND)->decls()) + HandleNamedDecl(dyn_cast<NamedDecl>(I), Symbols, RDO); + return true; ---------------- compnerd wrote: > Hmm, do we have a guarantee that the decl is named? Could you not hit a > `_Static_assert` or `static_assert` in this traversal? Or if it is a C++ > context, an `extern "C"` block? What about `#pragma comment(...)`? Please > add test cases for these. HandleNamedDecl bails when the NamedDecl is not a NamedDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
