plotfi marked an inline comment as done.
plotfi added inline comments.
================
Comment at: clang/include/clang/AST/Mangle.h:249-250
+struct ASTNameGenerator {
+ std::unique_ptr<MangleContext> MC;
+ llvm::DataLayout DL;
+
----------------
aaron.ballman wrote:
> Do these still need to be public members? Back when this class was an
> implementation detail, that didn't matter as much, but I'd prefer a cleaner
> public interface before we expose this to other consumers.
Good catch! This was a struct when it was CodegenNameGeneratorImpl but these
were hidden by the mere fact that they were inside the .cpp file and not in a
header. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63535/new/
https://reviews.llvm.org/D63535
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
