[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522 // to be re-used for method bodies as well. - ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope); + ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope| +

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 109366. chill added a comment. Updated with only whitespace changes after formating each changed line with clang-format. https://reviews.llvm.org/D33676 Files: include/clang/Sema/Scope.h lib/Parse/ParseCXXInlineMethods.cpp lib/Parse/ParseDecl.cpp lib

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Thanks for the review, I'll wait a few days. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

This revision was automatically updated to reflect the committed changes. Closed by commit rL310616: Place implictly declared functions at block scope (authored by chill). Changed prior to commit: https://reviews.llvm.org/D33676?vs=109366&id=110587#toc Repository: rL LLVM https://reviews.ll

[PATCH] D71843: [ARM][MVE] MVE-I should not be disabled by -mfpu=none

This revision was automatically updated to reflect the committed changes. Closed by commit rG173b711e83d7: [ARM][MVE] MVE-I should not be disabled by -mfpu=none (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

chill added a comment. Some tests started failing: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/9071 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D83004 __

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill accepted this revision. chill added a comment. In D75044#2292302 , @danielkiss wrote: > @chill ping. Sorry, I thought about committing all PAC/BTI patches together, but there's no reason, is there? So, let's go ahead and commit the two dealing with

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill requested changes to this revision. chill added a comment. This revision now requires changes to proceed. In D85649 I changed the module flags to be always present and have a zero/non-zero value. That's needed during LTO, if a flag is present in one module

[PATCH] D85649: [AArch64] PAC/BTI code generation for LLVM generated functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa88c722e687e: [AArch64] PAC/BTI code generation for LLVM generated functions (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. In D85649 I suggested a different version of module flags, which is a bit nicer to use, e.g. one can say just getModuleFlag("sign-return-address-with-bkey") != nullptr instead of a) checking for the flag presence, b) getting its value a

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

chill added inline comments. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp:106 + + EmitBTIMarking = MarkBTIProperty.getValue(); } No need to the `.getValue()` part. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArc

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. LGTM, as soon as D85649 is accepted (so they stay in sync). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 ___ cfe-commits mailing list cfe-co

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. It'd be nice if we could get someone non-Arm to have a look too. though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91438/new/ https://reviews.llvm.org/D91438 __

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

This revision was automatically updated to reflect the committed changes. Closed by commit rG13dd65b3a1a3: Do not create LLVM IR `constant`s for objects with dynamic initialisation (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

chill added a comment. Thanks, I'll have a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.org/D102693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

chill updated this revision to Diff 347631. chill added a comment. This revision is now accepted and ready to land. Updated a test to run for `x86_64-linux` instead of `%itanium_abi_triple`, to avoid having invalid syntax for MACH-O sections. The patch itself does not care about section attribut

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21aa107eb79f: Reland "Do not create LLVM IR `constant`s for objects with dynamic… (authored by chill). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

chill added a comment. IMHO, it's possible to write a frontend test, which includes, say `arm_neon.h`, but does not really require the `ARM` or `AArch64` backends to be configured (e.g. `CodeGen/arm-vector-align.c`?) If `arm_neon.h` is not built, then the test would need the appropriate `REQUIR

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

chill added inline comments. Comment at: llvm/docs/LangRef.rst:1220 +``alignstack()`` +This indicates the alignment that should be considered by the backend when +assigning this parameter to a stack slot during calling convention rnk wrote: > This seems l

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135 StringRef &Err) const { - llvm::AArch64::ParsedBranchProtection PBP; - if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err)) + llvm::ARM:

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135 StringRef &Err) const { - llvm::AArch64::ParsedBranchProtection PBP; - if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err)) + llvm::ARM:

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:897 +Builder.defineMacro("__ARM_FEATURE_PAUTH", "1"); +Builder.defineMacro("__ARM_FEATURE_BTI", "1"); + } miyuki wrote: > Since we decided to have two separate flags, I think this l

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

chill added inline comments. Comment at: libunwind/src/Unwind-EHABI.cpp:312 uint8_t registers = getByte(data, offset++); - if (registers & 0xf0 || !registers) + if (registers & 0xf0) return _URC_FAILURE; m

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:6377 + +static const char *SignReturnAddrStr[] = {"none", "non-leaf", "all"}; +Fn->addFnAttr("sign-return-address", vhscampos wrote: > I reckon selecting the string using a

[PATCH] D156784: [AArch64][PAC] Declare FPAC subtarget feature

chill added a comment. In D156784#4653741 , @atrosinenko wrote: > As discussed in D156716 , it is not clear > if I have to add FeatureFPAC to every relevant CPU. I would say, yes, it has to be added to each CPU that ha

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. Following D148094 , the patch does not apply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242 ___ cfe-

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c:100 struct packed_struct on_callee_stack; on_callee_stack = va_arg(vl, struct packed_struct); } Can we add some `CHECK:` lines here and to other variadic functi

[PATCH] D75109: Apply function attributes through array declarators

This revision was automatically updated to reflect the committed changes. Closed by commit rG6081ccf4a3b6: Apply function attributes through array declarators (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG080d046c91d2: [ARM][CMSE] Implement CMSE attributes (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } danielkiss wrote: > chill wrote: > > I would really prefer to not set v

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

chill added a reviewer: efriedma. chill added a subscriber: efriedma. chill added a comment. Following @efriedma comment here http://lists.llvm.org/pipermail/cfe-dev/2020-March/065017.html LGTM. Comment at: clang/include/clang/Basic/TargetInfo.h:18 #include "clang/Basic/Addr

[PATCH] D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, conditional on the dependent patch. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77134/new/ https://reviews.llvm.org/D77134

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 3 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3588 + NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask), RegParmOffset = 8 }; // Assumed to be the last field s

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 2 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3622 bool getNoCfCheck() const { return Bits & NoCfCheckMask; } bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; } snidert

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill added a comment. In D71129#1956137 , @snidertm wrote: > Have you already committed support for CMSE attributes to the LLVM backend? > Or is that on the way? The last two CMSE patches are under review: https://reviews.llvm.org/D76518 Repository:

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 4 inline comments as done. chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1882 + if (FI.isCmseNSCall()) +FuncAttrs.addAttribute("cmse_nonsecure_call"); + snidertm wrote: > Just curious … Does the LLVM backend have a way to

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Please, wait a couple of days before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74966/new/ https://reviews.llvm.org/D74966 __

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added a comment. That said, my comments are not of the "over my dead body" kind ;) Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } I would r

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:200 +if (!F.hasFnAttribute("branch-target-enforcement")) + return false; +Attribute A = F.getFnAttribute("branch-target-enforcement"); chill wrote: > T

[PATCH] D68711: Implement target(branch-protection) attribute for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa6d48fa70eb: Implement target(branch-protection) attribute for AArch64 (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[PATCH] D72762: [ARM][TargetParser] Improve handling of dependencies between target features

This revision was automatically updated to reflect the committed changes. Closed by commit rG3627c91ead93: [ARM][TargetParser] Improve handling of dependencies between target features (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D72633: [ARM][MVE] Fix a corner case of checking for MVE-I with -mfpu=none

This revision was automatically updated to reflect the committed changes. Closed by commit rGda3f2b414ace: [ARM][MVE] Fix a corner case of checking for MVE-I with -mfpu=none (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: http

[PATCH] D73459: [ARM] Add documentation for -march= and -mfpu= command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGac2153546074: [ARM] Add documentation for -march= and -mfpu= command line options (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5813 getContext().getTypeUnadjustedAlignInChars(Ty).getQuantity(); -unsigned BaseAlign = getContext().getTypeAlignInChars(Base).getQuantity(); -Align = (Align > BaseAlign && Align >= 16) ?

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5809 -// For alignment adjusted HFAs, cap the argument alignment to 16, leave it -// default otherwise. +// For alignment adjusted HFAs, cap the argument alignment to 16, otherwise +// set

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.c:34 struct aligned_member_8 { uint16x8_t M0 __attribute((aligned (8))); // member alignment 16 since __attribute((aligned (n))) sets the minimum alignment }; Don't you mea

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. I was just thinking to LGTM it :) IMHO, the alignment adjustment happens because of C.4 (B.3 indeed leave the HFA/HVA unmodified). > C.4 If the argument is an HFA, an HVA, a Quad-precision Floating-point or > short vector type then the NSAA is rounded up to the next m

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/test/CodeGen/aarch64-ABI-align-packed.c:34 struct aligned_member_8 { uint16x8_t M0 __attribute((aligned (8))); // member alignment 16 since __attribute((aligned (n))) sets the minimum alignment }; JiruiWu wrote

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. In D146242#4427966 , @tmatheson wrote: > In D146242#4427707 , @chill wrote: > >> I was just thinking to LGTM it :) >> >> IMHO, the alignment adjustment happens because of C.4 (B.3 indeed le

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added a comment. > Previously when a packed struct, containing vector data types such as > uint16x8_t, is passed as a function argument, the alignment of the > struct used by the function caller and the alignment used by the callee > to load the argument from stack does not match. I would s

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: lib/Parse/ParseStmt.cpp:843-845 + return ParseCompoundStatement(isStmtExpr, +Scope::DeclScope | Scope::CompoundStmtScope); } rsmith wrote: > This seems to miss quite a lot of places that i

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 106056. chill added a comment. Herald added a subscriber: eraman. Set the compound statement flag on all compound statement scopes (previous version used to set the flag on just enough scopes as to be sufficient for the purpose of inserting C90 implicit functio

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill created this revision. chill added reviewers: dblaikie, keith.walker.arm. Herald added subscribers: JDevlieghere, aprantl. This is the `clang` counterpart to https://reviews.llvm.org/D42734 This patch: - fixed an incorrect sign-extension of unsigned values, when emitting debug info metad

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132414. chill added a comment. Minor update, the parameter to `createEnumerator` is `IsUnsigned` now (instead of `IsSigned`), changed caller. https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp test/CodeG

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132587. chill added a comment. Changes, relative to the previous revision: - a few tweaks to the tests https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp test/CodeGenCXX/debug-info-enum-class.cpp test/

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill marked 3 inline comments as done. chill added inline comments. Comment at: test/CodeGen/debug-info-enum.cpp:2 +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +enum class E0 : signed char { + A0 = -128, dblaikie wrote: > Could y

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132822. chill added a comment. Changes since last revision: - Add/update test to check that each enumerator belongs to the right enumeration https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp test/CodeGe

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:229 MacroBuilder &Builder) const { + // FIXME: this does not handle the case where MOPS is disabled using +nomops + Builder.defineMacro("__ARM_FEATURE_M

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added a comment. I suppose `clang/test/CodeGen/aarch64-mops.c` needs to be run with `clang -march=armv8-a+mops+memtag` (not `clang_cc1`) so it picks up declarations of tagging intrinsics from `arm_acle.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added a comment. In D118199#3287636 , @chill wrote: > I suppose `clang/test/CodeGen/aarch64-mops.c` needs to be run with `clang > -march=armv8-a+mops+memtag` (not `clang_cc1`) so it picks up declarations of > tagging intrinsics from `arm_acle.h`.

[PATCH] D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c7b43aa8298: [clang][AArch32] Correctly align HA arguments when passed on the stack (authored by chill). Herald added a project: clang. Herald added

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

chill added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745 + IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>, + Requires<[IsThumb2]>, Sched<[WriteBrL]>; DavidSpickett wrote: > Should this require `IsMClass` ins

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:387 + + return a.isArmT32(); +} For example Arm7-a defines the T32 instruction set, buy we still want a warning. Maybe we need `return a.isArmT32() && a.isArmMClass()`. I'm not actually su

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:70 - bool validateBranchProtection(StringRef, BranchProtectionInfo &, + bool validateBranchProtection(StringRef, StringRef, BranchProtectionInfo &, StringRef &) const o

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:391-392 + if (!Arch.empty() && !isBranchProtectionSupportedArch(Arch)) +return false; + amilendra wrote: > chill wrote: > > On empty `Arch` it'd continue down the function, but we'd l

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

chill added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:125 ARM::AEK_DOTPROD| ARM::AEK_BF16 | ARM::AEK_I8MM)) +ARM_ARCH("armv8.8-a", ARMV8_8A, "8.8-A", "v8.8a", + ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8,

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666 + HasMOPS |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || + ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; So, this is enabled by default (as in "is mandatory part

[PATCH] D98794: [AArch64] Correctly align HFA arguments when passed on the stack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9d932e6735a: [clang][AArch64] Correctly align HFA arguments when passed on the stack (authored by chill). Herald added a project: clang. Herald adde

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94081/new/ https://reviews.llvm.org/D94081 ___ cf

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94083/new/ https://reviews.llvm.org/D94083 ___ cfe

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

chill added a comment. In D94083#2486800 , @fhahn wrote: > FWIW I think it would be good to have a bit more details in the description > for changes such as this, like a link to the public docs for the extension. I'm sorry, I assumed this information was

<    1   2