chill added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:6377
+
+ static const char *SignReturnAddrStr[] = {"none", "non-leaf", "all"};
+ Fn->addFnAttr("sign-return-address",
----------------
vhscampos wrote:
> I reckon selecting the string using a switch statement on BPI.SignReturnAddr
> is more type safe than doing it like this. The current selection is prone to
> out of bounds accesses to the array in case the enum changes. Please consider
> so.
Guard it with an assert.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
