chill added inline comments.
================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135
StringRef &Err) const {
- llvm::AArch64::ParsedBranchProtection PBP;
- if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err))
+ llvm::ARM::ParsedBranchProtection PBP;
+ if (!llvm::ARM::parseBranchProtection(Spec, PBP, Err))
return false;
----------------
danielkiss wrote:
> aaron.ballman wrote:
> > chill wrote:
> > > vhscampos wrote:
> > > > aaron.ballman wrote:
> > > > > This change surprises me. Why should AArch64TargetInfo prefer calling
> > > > > into ARM instead?
> > > > Since that particular function ended up identical in both ARM and
> > > > AArch64, we removed the AArch64 specific function and kept only one
> > > > under ARM. You can spot the removal further down the patch.
> > > >
> > > > The ARM namespace under ARMTargetParser.h already had code used in
> > > > AArch64TargetParser, so we did not introduce new cross dependencies.
> > > It's the unfortunate overload of "ARM" used to denote the backend and the
> > > organisation.
> > Ah, that's good to know, thank you for the explanation. (And yeah, that is
> > an unfortunate overload of the term.)
> Wondering will this link when the `LLVM_TARGETS_TO_BUILD` does not contains
> ARM but AArch64?
Should link, the function is in `lib/Support/TragetParser.cpp`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112421/new/
https://reviews.llvm.org/D112421
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
