chill added inline comments.
================ Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:200 + if (!F.hasFnAttribute("branch-target-enforcement")) + return false; + Attribute A = F.getFnAttribute("branch-target-enforcement"); ---------------- chill wrote: > This should be "true", although the comment might turn out moot. > > If we somehow end up with a function, that does not have that attribute, we > should clear the > ELF flag. > Oh, I see, those are the cases of sanitizer functions, created at LLVM level, that don't have the attribute. Please, leave a comment in that sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits