Author: mps
Date: Mon Jun 17 09:12:45 2019
New Revision: 363574
URL: http://llvm.org/viewvc/llvm-project?rev=363574&view=rev
Log:
Various improvements to Clang MSVC Visualizer
This change adds/improves MSVC visualizers for many Clang types, including
array types, trailing return types in functio
Author: mps
Date: Sat Jul 13 08:27:53 2019
New Revision: 366007
URL: http://llvm.org/viewvc/llvm-project?rev=366007&view=rev
Log:
Template-related improvements to Visual Studio visualizers
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualizers/clan
Author: mps
Date: Sun Jul 28 20:34:40 2019
New Revision: 367199
URL: http://llvm.org/viewvc/llvm-project?rev=367199&view=rev
Log:
Improve MSVC visualizers for DeclSpec and TemplateName
DeclSpec now shows the TypeRep, ExprRep, or DeclRep as appropriate
TemplateName decodes and displays the Storage
Author: mps
Date: Tue Aug 6 06:29:35 2019
New Revision: 368029
URL: http://llvm.org/viewvc/llvm-project?rev=368029&view=rev
Log:
Improve MSVC visualizations so the parser shows where we are in the code
Also provide a visualizer for lambda introducers
Modified:
cfe/trunk/utils/ClangVisualize
Author: mps
Date: Sat Jun 22 11:56:40 2019
New Revision: 364138
URL: http://llvm.org/viewvc/llvm-project?rev=364138&view=rev
Log:
Natural MSVC visualization of constructors
E.g., Allow MSVC to visualize a CXXConstructorDecl like
Constructor { Y(type_identity_t)}
Modified:
cfe/trunk/utils/C
Author: mps
Date: Sat Jun 22 18:15:48 2019
New Revision: 364145
URL: http://llvm.org/viewvc/llvm-project?rev=364145&view=rev
Log:
MSVC visualizers for type aliases
For example, the following TypeAliasTemplateDecl now displays in the autos
window as
template using type_identity_t = type_identity:
Author: mps
Date: Sun Jun 30 15:04:25 2019
New Revision: 364724
URL: http://llvm.org/viewvc/llvm-project?rev=364724&view=rev
Log:
Various tweaks to MSVC natvis visualizers
Make more consistent use of na format.
Improve visualization of deduction guides.
Add visualizer for explicit specifier (incl
Author: mps
Date: Fri Jul 5 14:41:30 2019
New Revision: 365248
URL: http://llvm.org/viewvc/llvm-project?rev=365248&view=rev
Log:
Improve MSVC visualization of annot_template_id tokens
Now shows the actual annotated template. E.g.,
{annot_template_id (A)}
Also a few miscellaneous fixes to visual
Author: mps
Date: Sun Dec 30 12:22:37 2018
New Revision: 350167
URL: http://llvm.org/viewvc/llvm-project?rev=350167&view=rev
Log:
DeclAccessPair visualizer should be expandable
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis
URL
Author: mps
Date: Mon Dec 31 15:01:34 2018
New Revision: 350182
URL: http://llvm.org/viewvc/llvm-project?rev=350182&view=rev
Log:
Make clearer which clang::type subclasses have visualizers
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualizers/clan
Author: mps
Date: Thu Jan 3 15:24:39 2019
New Revision: 350371
URL: http://llvm.org/viewvc/llvm-project?rev=350371&view=rev
Log:
Fix MSVC visualizations for ActionResult and OpaquePtr
Mainly just fixing buggy code. Also removed unnecessary visualizers
for specializations of OpaquePtr
Modified:
Author: mps
Date: Sat Jan 5 09:01:34 2019
New Revision: 350470
URL: http://llvm.org/viewvc/llvm-project?rev=350470&view=rev
Log:
Improve MSVC type visualizations
Display TypeBits in a single line.
Fix bit rot in template visualizations
Rudimentary support for deduced types
Modified:
cfe/t
Author: mps
Date: Sat Jan 5 15:15:30 2019
New Revision: 350482
URL: http://llvm.org/viewvc/llvm-project?rev=350482&view=rev
Log:
Fix MSVC Visualization for TemplateTypeParmType and TemplateTypeParmDecl
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVi
Author: mps
Date: Sat Jan 5 20:58:48 2019
New Revision: 350487
URL: http://llvm.org/viewvc/llvm-project?rev=350487&view=rev
Log:
Have MSVC Visualizer for DeducedTemplateSpecializationType show both the
original template and deduced specialization
Now appears in the Autos window something like
mspertus created this revision.
mspertus added a subscriber: cfe-commits.
The Token visualizer in clang.natvis makes debugging Clang in Visual Studio
much easier for keywords (because a given keyword is always the same), but it
doesn't work very well for identifiers (because they are all differe
mspertus added a comment.
Thanks, Aaron! Hal mentioned that I might need to ask you to commit on my
behalf as I don't have commit access as of now.
http://reviews.llvm.org/D12807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: mps
Date: Sun May 15 20:36:09 2016
New Revision: 269623
URL: http://llvm.org/viewvc/llvm-project?rev=269623&view=rev
Log:
Simple visualization of expressions
While more could be done, showing the type is a lot better than what is there
now.
Modified:
cfe/trunk/utils/ClangVisualizers
Author: mps
Date: Thu Mar 31 01:09:56 2016
New Revision: 264997
URL: http://llvm.org/viewvc/llvm-project?rev=264997&view=rev
Log:
Visual Studio native visualization for clang::TemplateDecl
With this change, TemplateDecls display in the Locals Window something like
template struct A;
Modified
Author: mps
Date: Thu Mar 31 22:31:43 2016
New Revision: 265104
URL: http://llvm.org/viewvc/llvm-project?rev=265104&view=rev
Log:
Visual Studio native visualizers for clang::TemplateSpecializationType
Displays a template specialization as, say, A. Does not
yet handle UncommonTemplateNameStorage,
Author: mps
Date: Mon Apr 4 14:36:48 2016
New Revision: 265338
URL: http://llvm.org/viewvc/llvm-project?rev=265338&view=rev
Log:
Fix redundant "typename typename T" in Visual Studio Native Visualizer
Also, a little minor cleanup
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modif
Author: mps
Date: Mon May 23 17:27:44 2016
New Revision: 270505
URL: http://llvm.org/viewvc/llvm-project?rev=270505&view=rev
Log:
Visualizer for Pack template arguments
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis
URL:
http
Author: mps
Date: Mon May 23 20:47:41 2016
New Revision: 270521
URL: http://llvm.org/viewvc/llvm-project?rev=270521&view=rev
Log:
Visualize ellipses in TemplateTypeParm and TemplateTypeParmDecl
Now a TemplateTypeParm will be visualized as typename ...T if it is a pack
Modified:
cfe/trunk/uti
Author: mps
Date: Sun Jun 5 22:37:18 2016
New Revision: 271866
URL: http://llvm.org/viewvc/llvm-project?rev=271866&view=rev
Log:
Slightly improve Visual Studio visualization of clang::Expr
Now it gives the StmtClass of the Expr as well as the type. It's still
a long way from full visualization o
Author: mps
Date: Mon Jun 6 12:08:32 2016
New Revision: 271910
URL: http://llvm.org/viewvc/llvm-project?rev=271910&view=rev
Log:
Better Visual Studio visualization of TemplateArgument and TemplateArgumentList
For pack TemplateArguments, visualize all of the items in the pack
Visualize a Template
Author: mps
Date: Mon Jun 6 12:23:37 2016
New Revision: 271911
URL: http://llvm.org/viewvc/llvm-project?rev=271911&view=rev
Log:
Fix typo in last submission to visualize proper template argument
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualize
Author: mps
Date: Mon Jun 6 16:41:20 2016
New Revision: 271944
URL: http://llvm.org/viewvc/llvm-project?rev=271944&view=rev
Log:
Improved Visual Studio visualizations for template argument lists
Improved the visualizer for TemplateArgumentList to show type arguments in the
DisplayString.
E.g.,
Author: mps
Date: Mon Jun 6 19:27:37 2016
New Revision: 271966
URL: http://llvm.org/viewvc/llvm-project?rev=271966&view=rev
Log:
Improve Visual Studio visualization of DeclaratorDecl
With this change, you can now expand its name and type.
Modified:
cfe/trunk/utils/ClangVisualizers/clang.nat
Author: mps
Date: Fri Jun 10 17:25:43 2016
New Revision: 272441
URL: http://llvm.org/viewvc/llvm-project?rev=272441&view=rev
Log:
Added missing close brace to OpaquePtr Visual Studio visualizer
This syntax error resulted in garbage being appended to OpaquePtr visualizations
Modified:
cfe/tru
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
When visualizing small vectors in VS2015, show the first few elements in the
DisplayString instead of the size. For example, a `SmallVector` of
`DeclAccessPair` w
Author: mps
Date: Fri Jun 10 22:02:33 2016
New Revision: 272448
URL: http://llvm.org/viewvc/llvm-project?rev=272448&view=rev
Log:
Visual Studio visualizers associated with LookupResults
Visualizers for DeclAccessPair, UnresolvedSet, and LookupResult. For example,
when combined with LLVM diff D212
Author: mps
Date: Sat Jun 11 15:15:19 2016
New Revision: 272487
URL: http://llvm.org/viewvc/llvm-project?rev=272487&view=rev
Log:
Visual Studio Visualizers for ActionResult, LocInfoType, and and TypeSourceInfo
Created a visualizer for ActionResult that displayed the validity and the
pointer,
but
Author: mps
Date: Sun Jun 12 13:42:04 2016
New Revision: 272518
URL: http://llvm.org/viewvc/llvm-project?rev=272518&view=rev
Log:
Rudimentary support for Visual Studio Stmt visualizer
Better than nothing...
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/Cl
Author: mps
Date: Sun Jun 12 17:21:56 2016
New Revision: 272521
URL: http://llvm.org/viewvc/llvm-project?rev=272521&view=rev
Log:
Visual Studio native visualizer for ParsedTemplateArgument
Does a good job with type and non-type template arguments
and lays the groundwork for template template argu
Author: mps
Date: Sun Jun 12 17:54:46 2016
New Revision: 272522
URL: http://llvm.org/viewvc/llvm-project?rev=272522&view=rev
Log:
Visual Studio Visualizer for PackExpansionType
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis
URL
mspertus accepted this revision.
mspertus added a reviewer: mspertus.
mspertus added a comment.
This revision is now accepted and ready to land.
No adverse (or otherwise) comments received, so committing as revision 272525
http://reviews.llvm.org/D21256
___
mspertus closed this revision.
mspertus added a comment.
revision 272525
http://reviews.llvm.org/D21256
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mps
Date: Sun Jun 12 23:02:35 2016
New Revision: 272531
URL: http://llvm.org/viewvc/llvm-project?rev=272531&view=rev
Log:
Improved Visual Studio visualization of OpaquePtr
Create a special visualizer for OpaquePtr because the
standard visualizer doesn't work with OpaquePtr
due to QualTyp
Author: mps
Date: Fri Mar 4 19:56:07 2016
New Revision: 262764
URL: http://llvm.org/viewvc/llvm-project?rev=262764&view=rev
Log:
Test commit: Fix run-on sentence in comment
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
Modified: cfe/trunk/lib/Parse/ParseDecl.cpp
URL:
http://llvm.org/viewvc/
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This is the first of a series of patches to add additional Visual Studio native
visualizers for subclasses of clang::Type. For example,
mspertus added a comment.
I believe that it will all work on VS2013 (and have kicked off a build to
confirm). I guess I would rather drop the number so it doesn't get out of sync
whenever the base compiler version changes.
http://reviews.llvm.org/D17908
_
mspertus added a comment.
Hmm, testing reveals that the preexisting clang.natvis does not work in VS2013!
Natvis: E:\Users\mspertus\Documents\Visual Studio
2013\Visualizers\clang.natvis(59,21): Error: identifier
"clang::TypeAlignmentInBits" is undefined
If I change all clang.natvis occurrenc
mspertus updated this revision to Diff 50015.
mspertus added a comment.
Updated in response to review comments to fix issues around MSVC versions
http://reviews.llvm.org/D17908
Files:
clang.natvis
Index: clang.natvis
===
--- cl
mspertus updated this revision to Diff 50022.
mspertus added a comment.
Based on Eric Feiveson's comment that I can suppress the numeric value of an
enum visualization with ", en" I have uploaded a new diff. By suppressing the
numeric values, instead of the verbose TemplateArgumentLoc visualizat
Author: mps
Date: Tue Mar 8 10:14:23 2016
New Revision: 262933
URL: http://llvm.org/viewvc/llvm-project?rev=262933&view=rev
Log:
Add Visual Studio native visualizers for several Clang types
This is one of a series of changes to improve the MSVC visualization of Clang
types.
This one focuses on
mspertus added a comment.
Committed, thanks!
http://reviews.llvm.org/D17908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
The Visual Studio native visualizer in llvm.natvis displays the actual pointer
in a PointerUnion as a void *. E.g.
clang::Type const *: 0x02c4a880
Which doesn't make c
mspertus added a comment.
Good catch. Give me two minutes
http://reviews.llvm.org/D18076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 50432.
mspertus added a comment.
Applying same logic to PointerUnion3 and PointerUnion4 as suggested by Aaron
http://reviews.llvm.org/D18076
Files:
llvm.natvis
Index: llvm.natvis
===
--- ll
mspertus closed this revision.
mspertus added a comment.
Committed as svn revision 263270
http://reviews.llvm.org/D18076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus closed this revision.
mspertus added a comment.
Committed as revision 262933
http://reviews.llvm.org/D17908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
This adds visualizers for PointerType and TemplateTypeParmType.
As I have been using these visualizers, I have found the DisplayStrings
mspertus closed this revision.
mspertus added a comment.
Committed as revision 263821.
Thanks for the trust, Aaron! Note that my next revision (function and member
prototype visualization) will be largish, and I would still appreciate a review
before commit.
http://reviews.llvm.org/D18270
mspertus closed this revision.
mspertus added a comment.
Thanks, Aaron. Committed as revision 263794
http://reviews.llvm.org/D18261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus added inline comments.
Comment at: clang.natvis:25
@@ +24,3 @@
+{*(clang::BuiltinType *)this}
+{*(clang::PointerType *)this}
+{*(clang::AttributedType *)this}
aaron.ballman wrote:
> If we're handling pointers, perhaps we should also do referen
Author: mps
Date: Fri Mar 18 11:38:34 2016
New Revision: 263794
URL: http://llvm.org/viewvc/llvm-project?rev=263794&view=rev
Log:
Show members of DeclContexts (i.e., class members) in Visual Studio native
visualizers
This change shows members of DeclContext objects in the Visual Studio debugger.
mspertus closed this revision.
mspertus added a comment.
Forgot to close the revision
http://reviews.llvm.org/D18163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
In the `` of `PointerIntPair` , I cast the pointer to the actual
type, so VS can leverage it while visualizing, not unlike the recent change to
`PointerUnion` vis
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
Visualizer for clang::FunctionProtoType
Displays return type and parameters for the Function Protoype object in the
Locals window. For example, the prototype `int
Author: mps
Date: Sat Mar 19 19:20:43 2016
New Revision: 263890
URL: http://llvm.org/viewvc/llvm-project?rev=263890&view=rev
Log:
Visual Studio Visualizer for clang::FunctionProtoType
Displays return type and parameters for the Function Protoype object in the
Locals window.
Modified:
cfe/tr
mspertus added a comment.
Based on Aaron's agreement to conducting post-commit reviews, I've committed
this as revision 263890. Please let me know if I should not have done so. (This
change is a lot smaller and simpler than I feared when I commented on my
roadmap in diff http://reviews.llvm.org
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
Whenever possible, use C++ names for visualizing builtin types. E.g., `long
double` instead of `LongDouble`
Committed as revision 263891 for post-commit review
h
Author: mps
Date: Sat Mar 19 19:32:30 2016
New Revision: 263891
URL: http://llvm.org/viewvc/llvm-project?rev=263891&view=rev
Log:
Better visualization of clang::BuiltinType in VisualStudio
Whenever possible, use C++ names for visualizing builtin types. E.g., "long
double" instead of "LongDouble"
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
This change shows members of `DeclContext` objects in the Visual Studio
debugger. It will also cast a `TagType` like a class or a struct to a
`DeclContext`, so its methods
mspertus updated this revision to Diff 50820.
mspertus added a comment.
Added reference types and a more accurate AttributedType enum. I am working on
additional items for the future (class members, function types, etc.) but those
will take longer, and I think it is worthwhile to get this revisi
Author: mps
Date: Wed Mar 16 09:27:50 2016
New Revision: 263638
URL: http://llvm.org/viewvc/llvm-project?rev=263638&view=rev
Log:
Add visualizers for more clang types. Create more C++-like visualizations for
existing Clang types
Created visualizer for PointerType, LValueReferenceType, RValueRefe
mspertus added a comment.
I think the code is correct as written, see response in comment
Comment at: clang.natvis:77
@@ +76,3 @@
+
+
+
aaron.ballman wrote:
> The only hard-wiring I see uses 3 bits, so is this comment still accurate?
I think the code is co
mspertus added a comment.
Committed as revision 263638. At Chandler's suggestion, I am going to send an
announcement to cfe-dev letting people know of all of the recent improvements
to native visualizers
http://reviews.llvm.org/D18163
___
cfe-comm
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
Displays a FunctionDecl in the Visual Studio Locals Window something like:
void g(int, double d, struct A && arr)
http://reviews.llvm.org/D18303
Files:
clang.natvis
I
mspertus accepted this revision.
mspertus added a reviewer: mspertus.
mspertus added a comment.
This revision is now accepted and ready to land.
Accepting revision based on Aaron's LGTM email to reviews.llvm.org.
http://reviews.llvm.org/D18297
___
c
mspertus closed this revision.
mspertus added a comment.
Closing committed revision. Further discussion as needed on mailing list
http://reviews.llvm.org/D18297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
mspertus accepted this revision.
mspertus added a reviewer: mspertus.
mspertus added a comment.
This revision is now accepted and ready to land.
Per Aaron, I want to close the committed diff, but I seem to need to accept it
first. Further discussion as needed on mailing list
http://reviews.llvm
mspertus closed this revision.
mspertus added a comment.
Closing committed revision
http://reviews.llvm.org/D18299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mps
Date: Sun Mar 20 15:15:23 2016
New Revision: 263915
URL: http://llvm.org/viewvc/llvm-project?rev=263915&view=rev
Log:
Visual Studio Visualizers for clang::FunctionDecl
Readably displays a FunctionDecl in the Visual Studio Locals Window something
like:
void g(int, double d, struct A
mspertus added a comment.
Committed as revision 263915.
http://reviews.llvm.org/D18303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus closed this revision.
mspertus added a comment.
Closing accepted revision
http://reviews.llvm.org/D18303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mps
Date: Mon Mar 21 21:29:22 2016
New Revision: 264020
URL: http://llvm.org/viewvc/llvm-project?rev=264020&view=rev
Log:
Visual Studio Native Visualizations for constructors and methods
With this change, the class
struct A {
A(int _i);
~A();
int foo(double d);
double b
Author: mps
Date: Wed Mar 23 12:29:42 2016
New Revision: 264169
URL: http://llvm.org/viewvc/llvm-project?rev=264169&view=rev
Log:
Visualize fields of records as they were declared in Visual Studio debugger
Modified:
cfe/trunk/utils/clang.natvis
Modified: cfe/trunk/utils/clang.natvis
URL:
ht
Author: mps
Date: Wed Mar 23 19:38:54 2016
New Revision: 264229
URL: http://llvm.org/viewvc/llvm-project?rev=264229&view=rev
Log:
Display const/volatile/restrict qualifiers in Visual Studio visualizations
Modified:
cfe/trunk/utils/clang.natvis
Modified: cfe/trunk/utils/clang.natvis
URL:
htt
mspertus created this revision.
mspertus added reviewers: ariccio, aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
This change uses the [[
https://blogs.msdn.microsoft.com/vcblog/2014/06/12/project-support-for-natvis/
| Project Support for Natvis ]] added in VS2015 to eliminate
mspertus created this revision.
mspertus added reviewers: ariccio, aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
This change uses the [[
https://blogs.msdn.microsoft.com/vcblog/2014/06/12/project-support-for-natvis/
| Project Support for Natvis ]] added in VS2015 to eliminate
mspertus updated this revision to Diff 51735.
mspertus added a comment.
Correctly handle non-Visual Studio case (e.g., Linux)
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
mspertus updated this revision to Diff 51739.
mspertus added a comment.
Accepting Aaron's suggestions
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
--- utils/llvm.natvis
++
mspertus marked 3 inline comments as done.
mspertus added a comment.
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 51740.
mspertus added a comment.
Missed one (the missing period in llvm.natvis).
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
--- ut
mspertus marked an inline comment as done.
mspertus added a comment.
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 51741.
mspertus added a comment.
Apply whitespace comments from http://reviews.llvm.org/D18497 mutatis mutandis
to this change
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/clang.natvis
www/hacking.html
Index: www/hacking.html
mspertus added a comment.
In http://reviews.llvm.org/D18498#384233, @zturner wrote:
> For vs2015, the files still need to be in the project right? (In the
> vcxproj with a tag)
This change puts the natvis files in the project for VS2015 but it appears to
use the `none` tag
http://schem
mspertus added a comment.
Hmmm, I just tried adding ` set_source_files_properties(utils/clang.natvis
LANGUAGE natvis)` similar to what you suggest in
http://lists.llvm.org/pipermail/llvm-dev/2016-January/093887.html, but it still
produces the `None` tag in the `.vcxproj` file. Any suggestion wh
mspertus added a comment.
What do you mean by "making both paths the same"?
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus added a comment.
I'm not sure I understand. I'm not installing anything for VS2013. You still
have to manually copy into `Documents\VS2013`. The purpose of this change is to
eliminate this manual step for VS2015 by leveraging the new Natvis project
support. Am I missing something?
ht
mspertus added a comment.
No. Testing shows that it works fine in the project with the `` tag.
VS2015 empirically looks at the extension.
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
mspertus added a comment.
I understand your concerns, but on balance, I don't see a better course of
action than what I've done. If I have some time, I'll submit a CMake change so
we can eventually migrate to having CMake generate a Natvis tag, but that will
take a long time to propagate, so I
mspertus updated this revision to Diff 51754.
mspertus added a comment.
Since this is now creating a project, we should do some housekeeping to move
the files to different directories so that the build tree has an
LLVMVisualizers project directory.
http://reviews.llvm.org/D18497
Files:
CMak
mspertus updated this revision to Diff 51756.
mspertus added a comment.
Add missing newline
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/LLVMVisualizers/CMakeLists.txt
utils/LLVMVisualizers/llvm.natvis
utils/llvm.natvis
Index: utils/llvm.natvis
===
mspertus updated this revision to Diff 51759.
mspertus added a comment.
Now that we are generating projects for native visualizers, have it properly
reflected in the directory structure
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/ClangVisualizers/CMakeLists.txt
utils/Clang
mspertus added a comment.
In http://reviews.llvm.org/D18497#384351, @ariccio wrote:
> `utils/llvm.natvis` is a duplicate of `utils/LLVMVisualizers/llvm.natvis`?
The file was moved to a more appropriate directory (Otherwise, the project
files were stepping on each other).
`svn mv utils/llvm.nat
mspertus marked an inline comment as done.
Comment at: utils/ClangVisualizers/CMakeLists.txt:2
@@ +1,3 @@
+# Do this by hand instead of using add_llvm_utilities(), which
+# tries to create a corresponding executable, which we don't want
+if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION
mspertus marked an inline comment as done.
mspertus added a comment.
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 51762.
mspertus added a comment.
Incorporating ariccio's comments and fixing some html
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/ClangVisualizers/CMakeLists.txt
utils/ClangVisualizers/clang.natvis
utils/clang.natvis
www/hacking.h
mspertus updated this revision to Diff 51764.
mspertus added a comment.
Adding missing period in comment!
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/LLVMVisualizers/CMakeLists.txt
utils/LLVMVisualizers/llvm.natvis
utils/llvm.natvis
Index: utils/llvm.natvis
=
1 - 100 of 109 matches
Mail list logo
