mspertus marked an inline comment as done. ================ Comment at: utils/ClangVisualizers/CMakeLists.txt:2 @@ +1,3 @@ +# Do this by hand instead of using add_llvm_utilities(), which +# tries to create a corresponding executable, which we don't want +if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION) ---------------- ariccio wrote: > Obsessive nit: Use a period after the "want", like `want.` Will do. Note that unfortunately, the CMakeLists.txt files are already inconsistent on that score...
================ Comment at: utils/ClangVisualizers/clang.natvis:9 @@ -8,2 +8,3 @@ +For later versions of Visual Studio, no setup is required--> <AutoVisualizer xmlns="http://schemas.microsoft.com/vstudio/debugger/natvis/2010";> ---------------- ariccio wrote: > Is it just me, or is this a dead link? It's not a link, it's an XML namespace. The idea is that you use a URL that you control as a namespace identifier to avoid collisions. http://reviews.llvm.org/D18498 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
