mspertus added inline comments.

================
Comment at: clang.natvis:25
@@ +24,3 @@
+    <DisplayString Condition="TypeBits.TC==clang::Type::TypeClass::Builtin" 
IncludeView="poly">{*(clang::BuiltinType *)this}</DisplayString>
+    <DisplayString Condition="TypeBits.TC==clang::Type::TypeClass::Pointer" 
IncludeView="poly">{*(clang::PointerType *)this}</DisplayString>
+    <DisplayString Condition="TypeBits.TC==clang::Type::Attributed" 
IncludeView="poly">{*(clang::AttributedType *)this}</DisplayString>
----------------
aaron.ballman wrote:
> If we're handling pointers, perhaps we should also do references similarly? 
> Also, perhaps functions as well (bonus points if you can suss out the 
> function prototype and display it!)?
I've already written references and can slot into an updated diff. After that, 
I plan on adding members of classes, but I'd like to put that in a subsequent 
change. Function prototype display is also coming. Does that sound ok?

================
Comment at: clang.natvis:26
@@ +25,3 @@
+    <DisplayString Condition="TypeBits.TC==clang::Type::TypeClass::Pointer" 
IncludeView="poly">{*(clang::PointerType *)this}</DisplayString>
+    <DisplayString 
Condition="TypeBits.TC==clang::Type::TypeClass::LValueReference" 
IncludeView="poly">{*(clang::LValueReferenceType *)this}</DisplayString>
+    <DisplayString 
Condition="TypeBits.TC==clang::Type::TypeClass::RValueReference" 
IncludeView="poly">{*(clang::RValueReferenceType *)this}</DisplayString>
----------------
Fixed


http://reviews.llvm.org/D18163



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to