[PATCH] D57337: [Targets] Adjust ARM data layout

michaelplatings updated this revision to Diff 183893. michaelplatings added a comment. Diff with -U9 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57337/new/ https://reviews.llvm.org/D57337 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

michaelplatings added a comment. In general LGTM, as someone who's done a 2-3 conversion of similar scale before. The only suggestion I'd make is to consider changing the `__future__` imports to `from __future__ import absolute_import, division, print_function` I found this gave the best consist

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://reviews.llvm.org/D55121 ___ cfe-commits mailing

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k-abi.c clang/test/CodeGen/target-dat

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188325. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k-abi.c clang/test/CodeGen/target-dat

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

This revision was automatically updated to reflect the committed changes. Closed by commit rL355522: [IR][ARM] Add function pointer alignment to datalayout (authored by michaelplatings, committed by ). Changed prior to commit: https://reviews.llvm.org/D57335?vs=188325&id=189524#toc Repository:

[PATCH] D57896: Variable names rule

michaelplatings created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following discussion and general agreement that the current naming rule for variables is not ideal, this patch switc

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1389042 , @lebedev.ri wrote: > Pretty sure this patch should have gone to llvm-commits, not cfe-commits. I just set the repository, Phabricator did the rest - apparently the magic isn't working so well. Repos

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1389067 , @lebedev.ri wrote: > 1. Does clang-tidy warn on every single existing variable now? > 2. It might be best to give this more visibility, by submitting a mail to > llvm-dev, with a **noticeable** subject,

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1390517 , @MyDeveloperDay wrote: > Should we come up with a new style? say `UpperOrLowerCamelCase`, I don't > mind going and doing that in the readability-identifier-naming check, given > that I just wrote u

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187252. michaelplatings added a comment. Update .clang-tidy files to use aNy_CasE until camelBackOrCase is available. Add more guidance around acronyms. Add more guidance around consistency with existing CamelCase variable names. Change other code exam

[PATCH] D57896: Variable names rule

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: llvm/docs/CodingStandards.rst:1195 + be camel case, and start with a lower case letter (e.g. ``leader`` or + ``boats``). It is also acceptable to use ``UpperCamelCase`` for cons

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187339. michaelplatings added a comment. Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187344. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/ https://reviews.llvm.org/D57896 Files: .clang-tidy clang/.clang-tidy llvm/.clang-tidy llvm/docs/CodingStandards.rst Index: llvm/d

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1402194 , @lattner wrote: > > Changed recommendation for acronyms from lower case to upper case, as > > suggested by several responses to the RFC. > > I haven't been following the discussion closely - why is this

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188184. michaelplatings added a comment. Herald added subscribers: cfe-commits, jdoerfert, mgorny, dschuff. Herald added projects: clang, LLVM. Hi @efriedma, sorry for the delayed response. I've added the features you asked for to DataLayout. It is int

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings marked 4 inline comments as done. michaelplatings added inline comments. Comment at: llvm/lib/IR/ConstantFold.cpp:1087 + if (GVAlign == 0U && isa(GV)) +GVAlign = 4U; efriedma wrote: > Using "4" as a default is dangerous; on

[PATCH] D64123: Add clang-llvm-rename tool.

michaelplatings added a comment. Hi @ruiu, Can you comment on how this compares to clang-tidy? I had assumed that the readability-identifier-naming clang-tidy rule would largely do the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/

[PATCH] D71991: Fix external-names.c test when separator is \\

michaelplatings created this revision. michaelplatings added reviewers: rnk, amccarth, dsanders, miyuki. Herald added a project: clang. Herald added a subscriber: cfe-commits. michaelplatings edited the summary of this revision. This fixes the following failure: C:\[...]\llvm\tools\clang\test\V

[PATCH] D71991: Fix external-names.c test when separator is \\

michaelplatings added a comment. Thanks for accepting. The repo is up to date. I guess the reason the failure hasn't happened with the build bots is that our downstream test setup differs somewhat from the norm - our test runner imports lit.discovery & lit.LitConfig directly rather than using t

[PATCH] D71991: Fix external-names.c test when separator is \\

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7ca82161b5: Fix external-names.c test when separator is \\ (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71991/new/ https:/

[PATCH] D134824: Fix frint ACLE intrinsic names

michaelplatings created this revision. michaelplatings added a reviewer: jaykang10. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Although the instruction names begin "frint", the ACLE spec sta

[PATCH] D134824: Fix frint ACLE intrinsic names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdba8fced969e: Fix frint ACLE intrinsic names (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D140959: RFC: Multilib prototype

michaelplatings created this revision. michaelplatings added a project: clang. Herald added subscribers: s.egerton, ormris, abidh, mgrang, simoncook, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib2.h:33-34 +private: + std::vector, std::vector>> Multilibs; + std::vector, std::vector>> RegexAttributes; +}; phosek wrote: > I think it'd really help readability and compre

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. How the multilib system matches user arguments is the main problem I've been struggling with. These are the options I see: 1. Grant the multilib system full access to all cc1 arguments, as demonstrated by the current code. However declare the multilib system un

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The plan is to change

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings updated this revision to Diff 493244. michaelplatings added a comment. Update commit message and run arc with clang-format on the PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878 Files

[PATCH] D142893: Class for building MultilibSet

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The functionality in

[PATCH] D142905: Change multilib selection algorithm

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abrachet, mgrang. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new algori

[PATCH] D142932: Multilib YAML parsing

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings created this revision. michaelplatings added reviewers: phosek, lenary, simon_tatham. Herald added subscribers: abrachet, mgrang. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: c

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The defaul

[PATCH] D140959: RFC: Multilib prototype

michaelplatings abandoned this revision. michaelplatings added a comment. I've created a new stack of changes taking into account the feedback. Unlike this change which was strictly a prototype, the new changes should be suitable for detailed review and hopefully approval. - https://reviews.llv

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: luke, abrachet, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD,

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abidh. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This enables layering ba

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 493968. michaelplatings added a comment. Incorporated changes requested by @miyuki Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clan

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added a comment. > The main trouble I had was at that point we don't have a reference to the > ToolChain, so calling `getMultiSelectionFlags` was not possible. [...] I'm > not sure what the solution here is. I see two options: 1. Split getMultiSelectionFlags into needs-ToolChai

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added a comment. In D142933#4099043 , @Joe wrote: > I did briefly try to pass a ToolChain to Gnu.cpp functions, but it became > intrusive and had to add it in 5+ places, so unless I'm missing a trick to > get the ToolChain from the Drive

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings updated this revision to Diff 494258. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/D

[PATCH] D142893: Class for building MultilibSet

michaelplatings updated this revision to Diff 494259. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142893/new/ https://reviews.llvm.org/D142893 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 494260. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 494262. michaelplatings added a comment. Rebase and change llvm::SmallVector to simply llvm::SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 File

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings marked an inline comment as done. michaelplatings added a comment. In D142933#4099587 , @Joe wrote: > Would it be weird for one target to have the `march=` but anothers not? Yes I think it would be weird. Potentially you could have a tool

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added a comment. In D142933#4099043 , @Joe wrote: > I did briefly try to pass a ToolChain to Gnu.cpp functions, but it became > intrusive and had to add it in 5+ places, so unless I'm missing a trick to > get the ToolChain from the Drive

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 494371. michaelplatings added a comment. Put "experimental" in the argument name. The intention is to include the new multilib as an experimental feature in LLVM 17 and stabilise it in LLVM 18. Also remove support for -f(no-)experimental-relative-c++

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 494406. michaelplatings added a comment. Move the regular expression flag matching functionality into MutlilibSet. This (a) simplifies the code for loading from multilib.yaml; and (b) makes the flag matching functionality easier to access. Reposito

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 494414. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 494416. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 494420. michaelplatings added a comment. Print flags expanded by any regular expression matchers in multilib.yaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D1429

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2213 + if (C.getArgs().hasArg(options::OPT_print_multi_selection_flags)) { +for (StringRef Attr : TC.getMultiSelectionFlags(C.getArgs())) + l

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 494610. michaelplatings added a comment. Bugfix: if -msoft-float is set then -mfpu should be none. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: cl

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings abandoned this revision. michaelplatings added a comment. > A more scalable approach would be to check only the minimal set of > combination necessary to achieve full coverage. In that case the testing you've already got in place in `clang/test/Driver/fuchsia.cpp` is adequate. T

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495070. michaelplatings added a comment. Set both fexceptions and fno-exceptions flags for Fuchsia multilib. Previously that tweak had slipped into D142878 , which is now abandoned. Repository: rG LLVM Github Mon

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 495072. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. A constraint is that the user should be able to choose the library with a single list of arguments, as displayed with `-print-multi-lib`. Therefore I'm sceptical about making the selection mechanism too expressive, because `-print-multi-lib` can't explain that t

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.h:77 bool isARMAProfile(const llvm::Triple &Triple); +bool isArmBigEndian(const llvm::Triple &Triple, const llvm::opt::ArgList &Args); Arm the company has rebranded but fo

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM but please allow a day for others to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154786/new/ https://reviews.l

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

michaelplatings added inline comments. Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49 +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV +// SME-SUBFEATURE-CONFLICT-REV

[PATCH] D155776: [NFC] Add checks for self-assignment.

michaelplatings added a comment. I reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

michaelplatings added a comment. > some nasty and repetitive regexes Yes, it's the same for Arm architecture extensions. Petr & I went back and forth on this for a long time. See discussion here to understand Petr's concerns: https://discourse.llvm.org/t/rfc-multilib/67494/23 CHANGES SINCE LA

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

michaelplatings added inline comments. Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49 +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV +// SME-SUBFEATURE-CONFLICT-REV

[PATCH] D156427: [clang] Improve hermeticity of clang header tests.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156427/new/ https://reviews.llvm.org/D156427 _

[PATCH] D57896: Variable names rule

michaelplatings added a comment. Hi Sam, I won't be able to take this forward but you have my encouragement. To facilitate this change I got as far as changing Git [1], and GitHub has been updated accordingly [2], but I ran out of steam before getting to the change itself. I'd be happy to let s

[PATCH] D154578: [ARM][Driver] Change float-abi warning

michaelplatings created this revision. michaelplatings added a reviewer: simon_tatham. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously the war

[PATCH] D154578: [ARM][Driver] Change float-abi warning

michaelplatings updated this revision to Diff 537673. michaelplatings added a comment. Fix duplicate implicit group warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154578/new/ https://reviews.llvm.org/D154578 Files: clang/include/clang/Bas

[PATCH] D154578: [ARM][Driver] Change float-abi warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79165735e11e: [ARM][Driver] Change float-abi warning (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154736: [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154736/new/ https://reviews.llvm.org/D154736 _

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

michaelplatings accepted this revision. michaelplatings added a comment. Hi @MaskRay, thanks for the add. Yes, we've been deleting a lot of `eabi` recently, but that's specific to AArch64. I have no particular insight into PowerPC but from @jroelofs' link, I agree `eabi` seems correct here. I'v

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

michaelplatings added a comment. Hi Joe, it's nice to see multilib.yaml getting some adoption :) > For the RISCVMultilibFlags, the mabi flag is used in combination with all the > march extension features (e.g +m). Notably, this doesn't align with the > current arm/aarch64 multilib flags, which

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 505279. michaelplatings marked an inline comment as done. michaelplatings added a comment. Calculate the output for -print-multi-lib lazily. This necessitated returning to using std::vector to store flags to avoid reordering them. In theory the big-O

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 505283. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Decouple multilib versioning scheme from the Clang version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 505284. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505286. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184 + SmallString<128> MultilibPath(SysRootDir); + llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME); + phosek wrote: > Rather than hardcoding the filename

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 505288. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 505290. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505293. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst clan

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505451. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add quotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files:

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

michaelplatings created this revision. michaelplatings added reviewers: simon_tatham, dcandler. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald ad

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 505643. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505644. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/l

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:237-245 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos, Neg

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60bbf271b568: [ARM][NFC] Use FPUKind enum instead of unsigned (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 506044. michaelplatings added a comment. fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings added a comment. @phosek ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507527. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add enum to Multilib class for how print options should be calculated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Sometimes it's necessary to define a multilib in terms of

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507864. michaelplatings added a comment. Move change to print options into D146757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D

[PATCH] D142905: [Driver] Change multilib selection algorithm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd30bc9e91241: [Driver] Change multilib selection algorithm (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 508036. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/lib/Dri

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 508037. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 508038. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 508039. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 508040. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 508041. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst clan

[PATCH] D144638: [lit] Detect Consistent File Access Times

michaelplatings added a comment. Thanks very much for looking into this, the flakiness of these tests has been bugging me for ages. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_

[PATCH] D144638: [lit] Detect Consistent File Access Times

michaelplatings added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

michaelplatings added a comment. I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not `UNSUPPORTED: system-windows` - do you know why? Comment at: llvm/utils/lit/lit/llvm/config.py:190 +return False +if "1995" not in touch_r

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 _

  1   2   3   >