This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79165735e11e: [ARM][Driver] Change float-abi warning (authored by michaelplatings).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154578/new/ https://reviews.llvm.org/D154578 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic/DiagnosticGroups.td clang/test/Driver/arm-no-float-regs.c Index: clang/test/Driver/arm-no-float-regs.c =================================================================== --- clang/test/Driver/arm-no-float-regs.c +++ clang/test/Driver/arm-no-float-regs.c @@ -1,7 +1,6 @@ -// REQUIRES: arm-registered-target - // Check that -mfloat-abi=hard gives a warning if FP registers aren't available. -// RUN: %clang --target=arm-none-eabi -mcpu=cortex-m0 -mfloat-abi=hard -### -c %s 2>&1 +// RUN: %clang --target=arm-none-eabi -mcpu=cortex-m0 -mfloat-abi=hard -### -c %s 2>&1 \ +// RUN: | FileCheck %s // RUN: %clang --target=arm-none-eabi -mcpu=cortex-m0 -mhard-float -### -c %s 2>&1 \ // RUN: | FileCheck -check-prefix=HARDFLOAT %s @@ -20,4 +19,4 @@ // CHECK: warning: '-mfloat-abi=hard': selected processor lacks floating point registers // HARDFLOAT: warning: '-mhard-float': selected processor lacks floating point registers -// NOWARN-NOT: selected processor lacks floating point registers +// NOWARN-NOT: warning: Index: clang/include/clang/Basic/DiagnosticGroups.td =================================================================== --- clang/include/clang/Basic/DiagnosticGroups.td +++ clang/include/clang/Basic/DiagnosticGroups.td @@ -1349,6 +1349,8 @@ def UnknownArgument : DiagGroup<"unknown-argument">; +def UnsupportedABI : DiagGroup<"unsupported-abi">; + // A warning group for warnings about code that clang accepts when // compiling OpenCL C/C++ but which is not compatible with the SPIR(-V) spec. def SpirCompat : DiagGroup<"spir-compat">; Index: clang/include/clang/Basic/DiagnosticDriverKinds.td =================================================================== --- clang/include/clang/Basic/DiagnosticDriverKinds.td +++ clang/include/clang/Basic/DiagnosticDriverKinds.td @@ -416,10 +416,10 @@ "unknown platform, assuming -mfloat-abi=%0">; def warn_drv_unsupported_float_abi_by_lib : Warning< "float ABI '%0' is not supported by current library">, - InGroup<DiagGroup<"unsupported-abi">>; + InGroup<UnsupportedABI>; def warn_drv_no_floating_point_registers: Warning< - "'%0': selected processor lacks floating point registers; flag ignored">, - InGroup<OptionIgnored>; + "'%0': selected processor lacks floating point registers">, + InGroup<UnsupportedABI>; def warn_ignoring_ftabstop_value : Warning< "ignoring invalid -ftabstop value '%0', using default value %1">; def warn_drv_overriding_flag_option : Warning<
Index: clang/test/Driver/arm-no-float-regs.c =================================================================== --- clang/test/Driver/arm-no-float-regs.c +++ clang/test/Driver/arm-no-float-regs.c @@ -1,7 +1,6 @@ -// REQUIRES: arm-registered-target - // Check that -mfloat-abi=hard gives a warning if FP registers aren't available. -// RUN: %clang --target=arm-none-eabi -mcpu=cortex-m0 -mfloat-abi=hard -### -c %s 2>&1 +// RUN: %clang --target=arm-none-eabi -mcpu=cortex-m0 -mfloat-abi=hard -### -c %s 2>&1 \ +// RUN: | FileCheck %s // RUN: %clang --target=arm-none-eabi -mcpu=cortex-m0 -mhard-float -### -c %s 2>&1 \ // RUN: | FileCheck -check-prefix=HARDFLOAT %s @@ -20,4 +19,4 @@ // CHECK: warning: '-mfloat-abi=hard': selected processor lacks floating point registers // HARDFLOAT: warning: '-mhard-float': selected processor lacks floating point registers -// NOWARN-NOT: selected processor lacks floating point registers +// NOWARN-NOT: warning: Index: clang/include/clang/Basic/DiagnosticGroups.td =================================================================== --- clang/include/clang/Basic/DiagnosticGroups.td +++ clang/include/clang/Basic/DiagnosticGroups.td @@ -1349,6 +1349,8 @@ def UnknownArgument : DiagGroup<"unknown-argument">; +def UnsupportedABI : DiagGroup<"unsupported-abi">; + // A warning group for warnings about code that clang accepts when // compiling OpenCL C/C++ but which is not compatible with the SPIR(-V) spec. def SpirCompat : DiagGroup<"spir-compat">; Index: clang/include/clang/Basic/DiagnosticDriverKinds.td =================================================================== --- clang/include/clang/Basic/DiagnosticDriverKinds.td +++ clang/include/clang/Basic/DiagnosticDriverKinds.td @@ -416,10 +416,10 @@ "unknown platform, assuming -mfloat-abi=%0">; def warn_drv_unsupported_float_abi_by_lib : Warning< "float ABI '%0' is not supported by current library">, - InGroup<DiagGroup<"unsupported-abi">>; + InGroup<UnsupportedABI>; def warn_drv_no_floating_point_registers: Warning< - "'%0': selected processor lacks floating point registers; flag ignored">, - InGroup<OptionIgnored>; + "'%0': selected processor lacks floating point registers">, + InGroup<UnsupportedABI>; def warn_ignoring_ftabstop_value : Warning< "ignoring invalid -ftabstop value '%0', using default value %1">; def warn_drv_overriding_flag_option : Warning<
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
