michaelplatings abandoned this revision.
michaelplatings added a comment.

I've created a new stack of changes taking into account the feedback. Unlike 
this change which was strictly a prototype, the new changes should be suitable 
for detailed review and hopefully approval.

- https://reviews.llvm.org/D142878 - Add testing for Fuchsia multilib
- https://reviews.llvm.org/D142893 - Class for building MultilibSet
- https://reviews.llvm.org/D142905 - Change multilib selection algorithm
- https://reviews.llvm.org/D142932 - Multilib YAML parsing
- https://reviews.llvm.org/D142933 - Add -print-multi-selection-flags argument
- https://reviews.llvm.org/D142986 - Enable multilib.yaml in the BareMetal 
ToolChain

I'm working on further patches to enable multilib layering, but that needn't 
block the above changes.

Thanks for giving it a try @Joe. The new changes are by design much more 
limited, in order to avoid creating an unstable API. I'd be interested to learn 
from you whether it's suitable for what you need, possibly by adding more 
functionality. In particular you'll see that https://reviews.llvm.org/D142933 
has functionality specific to Arm extensions so something similar may be 
required for other architectures.

In D140959#4028638 <https://reviews.llvm.org/D140959#4028638>, @tschuett wrote:

> Did you look at Yaml I/O <https://llvm.org/docs/YamlIO.html>?

Thanks for the tip, I've used it in https://reviews.llvm.org/D142932 and it's a 
great improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140959/new/

https://reviews.llvm.org/D140959

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to