michaelplatings abandoned this revision. michaelplatings added a comment. > A more scalable approach would be to check only the minimal set of > combination necessary to achieve full coverage.
In that case the testing you've already got in place in `clang/test/Driver/fuchsia.cpp` is adequate. There was a potential bug here so I was being extra cautious, but in practice the test added in this change didn't pick up anything that wasn't also caught by the existing tests. I'll abandon this change and remove it from the stack. The change stack now begins at D142893 <https://reviews.llvm.org/D142893>. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits