[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny updated this revision to Diff 145711. jdenny edited the summary of this revision. jdenny added a comment. Made the suggested changes. https://reviews.llvm.org/D45093 Files: include/clang/Sema/Sema.h lib/Frontend/ASTConsumers.cpp lib/Sema/Sema.cpp test/Misc/ast-print-bool.c Index

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny updated this revision to Diff 146145. jdenny edited the summary of this revision. jdenny added a comment. I've implemented the suggestion to use ElaboratedType. See the last paragraph of the revised summary for details. There might be trouble for CXPrintingPolicyProperty users. That is,

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny updated this revision to Diff 146351. jdenny marked 10 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Made the suggested changes. Thanks. https://reviews.llvm.org/D45463 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h in

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added inline comments. Comment at: lib/AST/DeclPrinter.cpp:218 for (auto *A : Attrs) { + if (A->isInherited()) +continue; I implemented inherited attribute suppression in this function with the expectation that the test suite would revea

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added a comment. In https://reviews.llvm.org/D45463#1096406, @rsmith wrote: > LGTM, thanks! Thanks. I'll remove the fixme as you asked. A few comments ago , I mentioned that IncludeTagDefinition's documentation and name is drifting farther from

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added a comment. In https://reviews.llvm.org/D45463#1096629, @rsmith wrote: > In https://reviews.llvm.org/D45463#1096499, @jdenny wrote: > > > A few comments ago , I mentioned > > that IncludeTagDefinition's documentation and name is drifting farth

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC332275: [AST] Fix -ast-print for _Bool when have diagnostics (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D45093?vs=145711&id=146650#toc Repository: rC Clang

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rC332281: [AST] Print correct tag decl for tag specifier (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D45463?vs=146351&id=146658#toc Repository: rL LLVM https

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

This revision was automatically updated to reflect the committed changes. jdenny marked an inline comment as done. Closed by commit rL332281: [AST] Print correct tag decl for tag specifier (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny updated this revision to Diff 146668. jdenny added a comment. Rebased. Ping. https://reviews.llvm.org/D45465 Files: lib/AST/DeclPrinter.cpp test/Misc/ast-print-enum-decl.c test/Misc/ast-print-record-decl.c test/Sema/ast-print.c test/SemaCXX/ast-print.cpp Index: test/SemaCXX/a

[PATCH] D46846: [Attr] Fix printing attrs for enum forward decl at file scope

jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. For example, given: enum __attribute__((deprecated)) T *p; -ast-print produced: enum T *p; The trouble was that the EnumDecl node was suppressed, as revealed by -ast-dump. The suppression of the EnumDecl

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny updated this revision to Diff 146709. jdenny marked 2 inline comments as done. jdenny added a comment. Made the suggested change. Thanks! https://reviews.llvm.org/D45465 Files: lib/AST/DeclPrinter.cpp test/Misc/ast-print-enum-decl.c test/Misc/ast-print-record-decl.c test/Sema/as

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny added a comment. In https://reviews.llvm.org/D45465#1098710, @rsmith wrote: > Looks good, thanks. Thanks. > It strikes me that this will still lead to inconsistencies. For example, I > expect this: > > struct A { struct B *a, *b; struct B *c, *d; }; > > > ... to print as: > > s

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rL332314: [AST] Fix printing tag decl groups in decl contexts (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45465?vs=1467

[PATCH] D46894: [Attr] Don't print implicit attributes

jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. Fixes bug reported at: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html https://reviews.llvm.org/D46894 Files: lib/AST/DeclPrinter.cpp test/Misc/ast-print-record-decl.c Index

[PATCH] D46903: [Attr] Don't print attr arg with default value

jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. For example, given: class __single_inheritance T; -ast-print -fms-extensions used to print: class __single_inheritance(1) T; Clang fails to parse that because the "(1)" is not valid syntax. This was disc

[PATCH] D46903: [Attr] Don't print attr arg with default value

jdenny added a comment. I occurs to me now that I could have fixed __single_inheritance by declaring its argument "fake". However, I still prefer the above solution because (1) it should help with any other attributes where arguments should have been declared fake (but no, I haven't identified

[PATCH] D46905: [Attr] Don't print fake MSInheritance argument

jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. This was discovered at: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html https://reviews.llvm.org/D46905 Files: include/clang/Basic/Attr.td test/SemaCXX/attr-print.cpp Index:

[PATCH] D46903: [Attr] Don't print attr arg with default value

jdenny abandoned this revision. jdenny added a comment. After further thought, this patch doesn't seem worthwhile. Sorry for all the noise. https://reviews.llvm.org/D46903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D46894: [Attr] Don't print implicit attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rC332411: [Attr] Don't print implicit attributes (authored by jdenny, committed by ). Repository: rC Clang https://reviews.llvm.org/D46894 Files: lib/AST/DeclPrinter.cpp test/Misc/ast-print-record-d

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny created this revision. jdenny added a reviewer: rsmith. And make it have no effect. Suggested at: https://reviews.llvm.org/D45463#1096629 I'm not sure of the proper way to deprecate something in libclang. Let me know if something else is needed. https://reviews.llvm.org/D46919 Files:

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > The deprecated enumerator is also referenced by > `tools/c-index-test/c-index-test.c` This test prompted me to keep the IncludeTagDefinition member in PrintingPolicy so that clang_PrintingPolicy_getProperty w

[PATCH] D46905: [Attr] Don't print fake MSInheritance argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL332481: [Attr] Don't print fake MSInheritance argument (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46905?vs=146923&id

[PATCH] D46846: [Attr] Fix loss of enum forward decl from decl context

jdenny updated this revision to Diff 147130. jdenny retitled this revision from "[Attr] Fix printing attrs for enum forward decl at file scope" to "[Attr] Fix loss of enum forward decl from decl context". jdenny edited the summary of this revision. jdenny added a comment. Made the suggested chang

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 147887. jdenny marked 2 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Made a stab at the suggested changes. https://reviews.llvm.org/D46919 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > The deprecated enumerator is also referenced by > > `tools/c-index-test/c-index-test.c` > > > This test prompted me to keep the IncludeTagDefiniti

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1107296, @rsmith wrote: > In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > > > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > > > The deprecated enumerator is also referenced by > > > `tools/c-index-test/c-i

[PATCH] D46846: [AST] Fix loss of enum forward decl from decl context

jdenny updated this revision to Diff 149021. jdenny added a comment. Rebased. Ping. https://reviews.llvm.org/D46846 Files: lib/Sema/SemaDecl.cpp test/Sema/ast-print.c test/SemaCXX/MicrosoftCompatibility.cpp Index: test/SemaCXX/MicrosoftCompatibility.cpp

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 156620. jdenny added a comment. Ping. Rebased. https://reviews.llvm.org/D46919 Files: clang/include/clang-c/Index.h clang/include/clang/AST/PrettyPrinter.h clang/lib/AST/DeclPrinter.cpp clang/lib/AST/TypePrinter.cpp clang/tools/c-index-test/c-inde

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. -ast-print prints omp pragmas with a trailing space. While this behavior is likely of little concern to most users, surely it's unintentional, and it's annoying for some source-level work I'm pur

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny created this revision. jdenny added reviewers: aaron.ballman, hfinkel. Parameter indices in some attributes (argument_with_type_tag, pointer_with_type_tag, nonnull, ownership_takes, ownership_holds, and ownership_returns) are specified in source as one-origin including any this parameter,

[PATCH] D43204: [OpenMP] Fix trailing space when printing pragmas

jdenny added a comment. In https://reviews.llvm.org/D43204#1007502, @ABataev wrote: > LG Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me? https://reviews.llvm.org/D43204 ___ cfe-commits mailing list c

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > Is there much benefit to forcing the attribute author to p

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny marked 3 inline comments as done. jdenny added a comment. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > aaron.ballman wrote: > > Is

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > jdenny wrote: > > jdenny wrote: > > > aaron.ballman wrote:

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > jdenny wrote: > > aaron.ballman wrote: > > > jdenny wrote:

[PATCH] D43747: [Attr] Fix pointer_with_type_tag assert fail for variadic

jdenny created this revision. jdenny added a reviewer: aaron.ballman. https://reviews.llvm.org/D43747 Files: lib/Sema/SemaDeclAttr.cpp test/Sema/warn-type-safety.c Index: test/Sema/warn-type-safety.c === --- test/Sema/warn-type

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny created this revision. jdenny added a reviewer: aaron.ballman. The first FIXME introduced here will be addressed in another patch soon. https://reviews.llvm.org/D43748 Files: test/Misc/ast-print-objectivec.m test/Sema/attr-print.c test/Sema/attr-print.cpp utils/TableGen/ClangAttr

[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value

jdenny created this revision. jdenny added a reviewer: aaron.ballman. For consistency with other attributes, fix alloc_size's diagnostics to report the attribute's argument index for a function parameter index rather than the actual function parameter index specified in the source. https://revie

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 135839. jdenny retitled this revision from "[Attr] Fix printing of parameter indices in attributes" to "[Attr] Fix parameter indexing for attributes". jdenny edited the summary of this revision. jdenny added a comment. Herald added a subscriber: kristof.beyls.

[PATCH] D43747: [Attr] Fix pointer_with_type_tag assert fail for variadic

jdenny added a comment. Hi Aaron. Thanks for accepting. I do not have commit privileges. Would you please commit this (and any other patches you accept) for me? https://reviews.llvm.org/D43747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value

jdenny added a comment. In https://reviews.llvm.org/D43749#1018818, @aaron.ballman wrote: > Aside from a minor testcase nit, this LGTM. Why is this dependent on > https://reviews.llvm.org/D43248? The dependency goes the other way. Did I get it wrong? Comment at: test/Sema/

[PATCH] D43747: [Attr] Fix pointer_with_type_tag assert fail for variadic

jdenny added a comment. In https://reviews.llvm.org/D43747#1018824, @aaron.ballman wrote: > In https://reviews.llvm.org/D43747#1018814, @jdenny wrote: > > > Hi Aaron. Thanks for accepting. I do not have commit privileges. Would > > you please commit this (and any other patches you accept) for me

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny added inline comments. Comment at: test/Misc/ast-print-objectivec.m:52 // CHECK: @class C1; -// CHECK: struct __attribute__((objc_bridge_related(C1, , ))) S1; +// CHECK: struct __attribute__((objc_bridge_related(C1))) S1; aaron.ballman wrote: > This fix i

[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value

jdenny added a comment. In https://reviews.llvm.org/D43749#1018846, @aaron.ballman wrote: > Committed (with whitespace fix for the test case) in r326058, thanks for the > patch! Sure. Thanks for committing. By the way the commit log you added isn't quite right. The issue isn't base 0 versus

[PATCH] D43749: [Attr] Fix alloc_size's diags to report arg idx not value

jdenny added a comment. In https://reviews.llvm.org/D43749#1019377, @aaron.ballman wrote: > Oh, yeah, I did muck up that commit log message a bit. Sorry about that! No problem. :-) I'll get to your comments in the other patches hopefully soon. Thanks again. https://reviews.llvm.org/D43749

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny updated this revision to Diff 135982. jdenny added a comment. Aaron: Because the last two arguments for objc_bridge_related must be delimited with commas, this revision takes the view that they are not optional but are permitted to be the empty string. The test suite behaves as expected.

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 136019. jdenny marked 8 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. This revision should address all issues raised. https://reviews.llvm.org/D43248 Files: include/clang/AST/Attr.h include/clang/Basic/Attr.

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: include/clang/AST/Attr.h:210-212 + unsigned Idx; + bool HasThis; + bool IsValid; aaron.ballman wrote: > I think it might be best to mash these together using bit-fields: > ``` > unsigned Idx : 30; > unsigned HasThis :

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

jdenny updated this revision to Diff 127088. jdenny added a comment. Herald added a subscriber: mgrang. 1. Use std::binary_search, as suggested by Hal. 2. Fix another case of line wrapping. 3. Rebase onto a recent master, and remove rewrites of tests that have recently changed. https://review

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: lib/Frontend/VerifyDiagnosticConsumer.cpp:398 +// DToken is foo-bar-warning, but foo is the only -verify prefix). +if (Prefixes.end() == std::find(Prefixes.begin(), Prefixes.end(), DToken))

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

jdenny added a comment. In https://reviews.llvm.org/D39694#956661, @hfinkel wrote: > LGTM Thanks for accepting. I don't have commit privileges. Would you please commit for me? This depends on https://reviews.llvm.org/D40995, which also needs to be committed. https://reviews.llvm.org/D39694

[PATCH] D41841: [OpenMP] Fix handling of clause on wrong directive

jdenny created this revision. jdenny added a reviewer: ABataev. First, this patch fixes an assert failure when, for example, "omp for" has num_teams. Second, this patch prevents duplicate diagnostics when, for example, "omp for" has uniform. This patch makes the general assumption (even where it

[PATCH] D41841: [OpenMP] Fix handling of clause on wrong directive

jdenny added a comment. Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me? https://reviews.llvm.org/D41841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny added inline comments. Comment at: test/Sema/attr-print.c:12 +short arr[3] __attribute__((aligned)); + // CHECK: void foo() __attribute__((const)); aaron.ballman wrote: > Please add a test showing that `objc_bridge_related` isn't mangled by > `-ast-print

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny updated this revision to Diff 136136. jdenny edited the summary of this revision. jdenny added a comment. This addresses the comment about redundant ifs. https://reviews.llvm.org/D43748 Files: include/clang/Basic/Attr.td lib/Parse/ParseDecl.cpp test/Sema/attr-print.c test/Sema/at

[PATCH] D43747: [Attr] Fix pointer_with_type_tag assert fail for variadic

jdenny added a comment. In https://reviews.llvm.org/D43747#1018844, @aaron.ballman wrote: > Committed in r326057. > > If you're not already on IRC, I would recommend joining the #llvm channel on > OFTC so that you can watch for build break notifications from the build bots. Thanks. Can your r

[PATCH] D43747: [Attr] Fix pointer_with_type_tag assert fail for variadic

jdenny added a comment. In https://reviews.llvm.org/D43747#1021234, @aaron.ballman wrote: > In https://reviews.llvm.org/D43747#1021209, @jdenny wrote: > > > In https://reviews.llvm.org/D43747#1018844, @aaron.ballman wrote: > > > > > Committed in r326057. > > > > > > If you're not already on IRC,

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny added a comment. In https://reviews.llvm.org/D43748#1021246, @aaron.ballman wrote: > LGTM! I can commit on your behalf, or, if you plan to continue submitting > patches, you can ask for commit privileges > (http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) and > commit

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. Hi Aaron. It occurs to me now that this patch has grown rather large and, in some places, a little subtle. Would it help the review if I were to break it up into a patch series that introduces ParamIdx to each attribute, one at a time? I'm not trying to rush you, but

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1024183, @aaron.ballman wrote: > In https://reviews.llvm.org/D43248#1023720, @jdenny wrote: > > > Hi Aaron. It occurs to me now that this patch has grown rather large and, > > in some places, a little subtle. Would it help the review i

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny marked 3 inline comments as done. jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:172-174 + // Whether the C++ implicit this parameter is allowed. Users that construct + // attributes from the source code use this information when validating + //

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 136624. jdenny marked 23 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. This update should address all outstanding comments. https://reviews.llvm.org/D43248 Files: include/clang/AST/Attr.h include/clang/Basic

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: include/clang/AST/Attr.h:206 + + void cmpable(const ParamIdx &I) const { +assert(isValid() && I.isValid() && aaron.ballman wrote: > jdenny wrote: > > aaron.ballman wrote: > > > The name here can be improved. How abou

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: test/Sema/attr-ownership.cpp:1 +// RUN: %clang_cc1 %s -verify + aaron.ballman wrote: > Please pass `-fsyntax-only` as well. Sure. Would you like me to change test/Sema/attr-ownership.c while we're thinking about it? h

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. Aaron, thanks for the review. I've applied your suggestions and am ready to commit. I've noticed a variety of styles in commit logs, I've read the coding standards, and it seems there's a lot of freedom here. Below are the two commit logs I'm planning to use. Please

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL326602: [Attr] Fix parameter indexing for several attributes (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43248?vs=136

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 137964. jdenny added a comment. This commit was reverted by r326862 due to: https://bugs.llvm.org/show_bug.cgi?id=36620 This revision includes a new test case and a fix. While the difference from the last revision is small, it's not trivial, so another revi

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 138111. jdenny added a comment. OK, this diff has the svn paths, and I've rebased to a more recent master. https://reviews.llvm.org/D43248 Files: trunk/include/clang/AST/Attr.h trunk/include/clang/Basic/Attr.td trunk/lib/AST/ExprConstant.cpp trunk/li

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 138113. jdenny added a comment. Well, that didn't work. Here's another attempt at getting the paths right. https://reviews.llvm.org/D43248 Files: cfe/trunk/include/clang/AST/Attr.h cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/lib/AST/ExprConstant.c

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1035466, @aaron.ballman wrote: > It seems like there are some other changes than just the serialize and > deserialize that I'm not opposed to, but am wondering why they're needed. It > seems some functions are now `getFoo()` calls The

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2 +// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse +// it here to check -emit-ast for attributes. + aaron.ballman wrote: > Can you move this below the R

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:1-2 +// %S/../Sema/attr-print.cpp exercises many different attributes, so we reuse +// it here to check -emit-ast for attributes. + aaron.ballman wrote: > jdenny wrote: > > aaron.ballm

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5 +// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp +// RUN: %clang_cc1 %t.ast -ast-print | FileCheck %S/../Sema/attr-print.cpp aaron.ballman wrote: > Just to verify my und

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1035509, @aaron.ballman wrote: > LGTM with the test comments fixed up. Thanks! I'll commit tomorrow. https://reviews.llvm.org/D43248 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

This revision was automatically updated to reflect the committed changes. jdenny marked 8 inline comments as done. Closed by commit rC327405: Reland "[Attr] Fix parameter indexing for several attributes" (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D432

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: test/Sema/attr-print.cpp:3 +// This file is also used as input for %S/../Frontend/ast-attr.cpp. + echristo wrote: > Relatedly I don't think we use files as input files to other directories and > I don't think we should

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. I'd prefer to move it than to expect people to obey such a comment. Let's see what Aaron says. Repository: rC Clang https://reviews.llvm.org/D43248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1036427, @echristo wrote: > In https://reviews.llvm.org/D43248#1036426, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D43248#1036409, @jdenny wrote: > > > > > I'd prefer to move it than to expect people to obey such a comment.

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1036439, @jdenny wrote: > So, I'm planning to remove test/Frontend/ast-attr.cpp, rename > test/Sema/attr-print.cpp to test/Misc/attr-print-emit.cpp, and change its run > lines to: > > // RUN: %clang_cc1 %s -ast-print | FileCheck %s >

[PATCH] D46846: [AST] Fix loss of enum forward decl from decl context

This revision was automatically updated to reflect the committed changes. Closed by commit rC333574: [AST] Fix loss of enum forward decl from decl context (authored by jdenny, committed by ). Repository: rC Clang https://reviews.llvm.org/D46846 Files: lib/Sema/SemaDecl.cpp test/Sema/ast-p

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 151979. jdenny added a comment. Rebased. Ping. https://reviews.llvm.org/D46919 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h lib/AST/DeclPrinter.cpp lib/AST/TypePrinter.cpp tools/c-index-test/c-index-test.c Index: tools/c-index

[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. This patch adjusts a test not to depend on deprecated FileCheck behavior that permits overlapping matches within a block of CHECK-DAG directives. Thus, this patch also removes uses of FileCheck's

[PATCH] D54765: [OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. This patch adjusts a test not to depend on deprecated FileCheck behavior that permits overlapping matches within a block of CHECK-DAG directives. Thus, this patch also removes uses of FileCheck's

[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

jdenny added a comment. In https://reviews.llvm.org/D54764#1304573, @ABataev wrote: > I'm fine with the patch, Thanks for the quick reviews. I'll push soon. > the original intention was to handle a possible situation where we may have > several debug locations with the same line numbers. We

[PATCH] D54765: [OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rC347351: [OpenMP] Update CHECK-DAG usage in target_parallel_codegen.cpp (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D54765?vs=174817&id=174837#toc Repository:

[PATCH] D54764: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rC347350: [OpenMP] Update CHECK-DAG usage in for_codegen.cpp (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D54764?vs=174816&id=174836#toc Repository: rC Clang

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

jdenny created this revision. jdenny added reviewers: ABataev, Hahnfeld, tra, sylvestre.ledru. Herald added a subscriber: guansong. D40453 (r319317) was meant to handle nvidia-cuda-toolkit's split CUDA installation in Debian. This patch addresses two issues left

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

jdenny added a comment. @tra, @Hahnfeld: Thanks for your replies. In D55269#1318901 , @tra wrote: > I'm not sure that's something that needs to be fixed in clang. > > IIUIC, Debian has added a shim that pretends to be a monolithic CUDA install: > https:/

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

jdenny added a comment. By the way, nvidia-cuda-toolkit does install the following, but there's no nvvm directory as clang currently expects: /usr/lib/nvidia-cuda-toolkit /usr/lib/nvidia-cuda-toolkit/bin /usr/lib/nvidia-cuda-toolkit/bin/cicc /usr/lib/nvidia-cuda-toolkit/bin/crt /usr/li

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

jdenny added a comment. In D55269#1319252 , @tra wrote: > It appears that what you're trying to do is to add "/usr/lib/cuda" on Ubuntu > and Debian when --cuda-path=/usr is specified. > This is a rather odd thing to do. My real goal is to get clang and

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

jdenny added a comment. In D55269#1319319 , @jdenny wrote: > > I do not think that changing clang to work around an issue in cmake files > > of one project is something we want to do. > > I don't have a separate project using cmake. The cmake files I'm r

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

jdenny added a comment. In D55269#1319382 , @tra wrote: > Let's start with fixing OpenMP's cmake files. Once it no longer insists on > specifying --cuda-path=/usr, and isUbuntu is in place, what is the remaining > failure that you see? I'm fairly certa

[PATCH] D55269: [CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

jdenny added a comment. In D55269#1319452 , @tra wrote: > In D55269#1319437 , @jdenny wrote: > > > > > > That may be a bigger can of works than a single patch can solve. The good > news is that the maintainer of CU

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

jdenny updated this revision to Diff 176916. jdenny retitled this revision from "[CUDA][OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu" to "[CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu". jdenny edited the summary of this revision. jdenny added a comment. Apply reviewer suggesti

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

This revision was automatically updated to reflect the committed changes. Closed by commit rL348504: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55269?vs=17691

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

jdenny added a comment. In D55269#1320382 , @tra wrote: > >> Let's start with fixing OpenMP's cmake files. Once it no longer insists on > >> specifying --cuda-path=/usr, and isUbuntu is in place, what is the > >> remaining failure that you see? > > > >

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

jdenny accepted this revision. jdenny added a comment. In D59168#1423587 , @phosek wrote: > I'm not super enthusiastic about the duplicated triple, but the only way to > eliminate it would be to move the Clang resource directory inside of > `lib/clang/x8

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

jdenny added a comment. Herald added a project: LLVM. In D55269#1320382 , @tra wrote: > In D55269#1320207 , @Hahnfeld wrote: > > > In D55269#1319109 , @jdenny wrote: > > > >

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny created this revision. jdenny added reviewers: ABataev, chandlerc, craig.topper. Herald added subscribers: jdoerfert, dexonsmith, guansong. Herald added a project: LLVM. Without this patch, APSInt inherits APInt::isNegative, which merely checks the sign bit without regard to whether the typ

  1   2   3   4   5   >