jdenny added a comment. In https://reviews.llvm.org/D43248#1036427, @echristo wrote:
> In https://reviews.llvm.org/D43248#1036426, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D43248#1036409, @jdenny wrote: > > > > > I'd prefer to move it than to expect people to obey such a comment. > > > Let's see what Aaron says. > > > > > > I have a slight preference for moving the tests now that I know they're > > causing problems, unless that turns out to be overly onerous for some > > reason. > > > > Thank you, @echristo for pointing out the issues with the tests, I hadn't > > considered that. > > > No worries :) > > That said, please don't revert and reapply to move. Just a followup commit is > just fine - and whenever you get a chance. (Though if you let me know when > you do I'd appreciate it :) Sure. So, I'm planning to remove test/Frontend/ast-attr.cpp, rename test/Sema/attr-print.cpp to test/Misc/attr-print-emit.cpp, and change its run lines to: // RUN: %clang_cc1 %s -ast-print | FileCheck %s // RUN: %clang -emit-ast -o %t.ast %s // RUN: %clang_cc1 %t.ast -ast-print | FileCheck %s That seems to work fine locally. I'll just leave the old test/Sema/attr-print.c alone as it's not part of this problem. Any objections? Repository: rC Clang https://reviews.llvm.org/D43248 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
