jdenny added a comment. In D55269#1319382 <https://reviews.llvm.org/D55269#1319382>, @tra wrote:
> Let's start with fixing OpenMP's cmake files. Once it no longer insists on > specifying --cuda-path=/usr, and isUbuntu is in place, what is the remaining > failure that you see? I'm fairly certain I would see no remaining failure then, but it's not clear to me how we should convince OpenMP's cmake files to stop doing that. openmp/libomptarget/cmake/Modules/LibomptargetNVPTXBitcodeLibrary.cmake is the file, and there's one occurrence of --cuda-path. If CUDA_TOOLKIT_ROOT_DIR is specified explicitly to cmake, that --cuda-path is necessary, so we cannot just remove it. If CUDA_TOOLKIT_ROOT_DIR is not specified explicitly, it is computed by cmake. So I believe this boils down to getting cmake to find the right CUDA root on Debian/Ubuntu. Do you agree so far? Would you recommend submitting a patch to cmake's CUDA support? Or would you recommend replicating clang's logic from D40453 <https://reviews.llvm.org/D40453> into openmp's cmake files, overriding cmake's own selection of CUDA_TOOLKIT_ROOT_DIR? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55269/new/ https://reviews.llvm.org/D55269 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
