jdenny added a comment. In D55269#1319452 <https://reviews.llvm.org/D55269#1319452>, @tra wrote:
> In D55269#1319437 <https://reviews.llvm.org/D55269#1319437>, @jdenny wrote: > > > > > > That may be a bigger can of works than a single patch can solve. The good > news is that the maintainer of CUDA support in cmake is working on adding > clang support. So, things may improve soon. To summarize all this as I understand it: It sounds like anything we do now for the cmake issue would be a short-term solution because cmake might later present a better solution. Originally, I figured the easiest place to work around this issue was clang as that would help anyone who detects a CUDA installation using current cmake support. You prefer to do it in OpenMP's cmake files, which I suppose would help avoid any unexpected consequences from my change to clang. A third alternative is to just wait for cmake to improve. For now, I'll trim this patch to just the IsUbuntu() part (maybe tomorrow), and we can think more about the cmake side of things. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55269/new/ https://reviews.llvm.org/D55269 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
