echristo added a subscriber: echristo.
echristo added a comment.
Pending naming from llvm review, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D13572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: echristo
Date: Thu Oct 8 19:35:30 2015
New Revision: 249790
URL: http://llvm.org/viewvc/llvm-project?rev=249790&view=rev
Log:
Fix a few typos in the required feature set for some of the x86
builtins:
avx512vd -> avx512vl
rdrand -> rdrnd
avx512ff -> avx512f
no functional change.
Modifie
Author: echristo
Date: Fri Oct 9 13:39:59 2015
New Revision: 249872
URL: http://llvm.org/viewvc/llvm-project?rev=249872&view=rev
Log:
Fix whitespace, 80-column violations, embedded tabs for the
TargetInfo class.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Basic/Tar
Author: echristo
Date: Fri Oct 9 13:39:55 2015
New Revision: 249871
URL: http://llvm.org/viewvc/llvm-project?rev=249871&view=rev
Log:
constify the feature vector going into initFeatureMap as it shouldn't
change the set of features.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe
Author: echristo
Date: Fri Oct 9 15:30:48 2015
New Revision: 249894
URL: http://llvm.org/viewvc/llvm-project?rev=249894&view=rev
Log:
Add a fixme to handleTargetFeatures.
The goal of wanting this to avoid munging the feature list is so
that it can be used for various targets as a way of both add
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
On Tue, Oct 13, 2015 at 10:32 AM Jonathan Roelofs
wrote:
> jroelofs added a comment.
>
> Other than that, LGTM too.
>
>
>
> Comment at: lib/Driver/ToolChains.cpp:4081
> @@ +4080,3 @@
> +
> + std::string PS4SDK
echristo added a subscriber: echristo.
echristo added a comment.
(Jonathan's review here is fine, don't wait on me. Thanks! :)
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: echristo
Date: Tue Oct 13 13:40:17 2015
New Revision: 250202
URL: http://llvm.org/viewvc/llvm-project?rev=250202&view=rev
Log:
Add subtarget feature support for 3dnowa to the 3dnowa intrinsics.
Modified:
cfe/trunk/lib/Headers/mm3dnow.h
Modified: cfe/trunk/lib/Headers/mm3dnow.h
URL:
Author: echristo
Date: Tue Oct 13 13:40:21 2015
New Revision: 250203
URL: http://llvm.org/viewvc/llvm-project?rev=250203&view=rev
Log:
Move the adc-builtins test to the pattern of the other builtins
tests by predefining _MM_MALLOC_H rather than use -ffreestanding.
Modified:
cfe/trunk/test/Cod
Author: echristo
Date: Wed Oct 14 00:40:11 2015
New Revision: 250270
URL: http://llvm.org/viewvc/llvm-project?rev=250270&view=rev
Log:
Remove the optimization option from this test as it is unnecessary
and front end tests should avoid this if possible.
Modified:
cfe/trunk/test/CodeGen/fma-bui
Author: echristo
Date: Wed Oct 14 00:40:21 2015
New Revision: 250271
URL: http://llvm.org/viewvc/llvm-project?rev=250271&view=rev
Log:
Canonicalize some of the x86 builtin tests and either remove or comment
about optimization options.
Modified:
cfe/trunk/test/CodeGen/3dnow-builtins.c
cfe/
It was already reverted, but I agree, let's get this fixed first.
Thanks!
-eric
On Tue, Oct 13, 2015 at 11:33 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova <
> katya_roman...@playstation.sony.com> wrote:
>
>> kromanova added a comment.
>>
>> Hi,
>>
>> The initial PS4 p
On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote:
> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher
> wrote:
>
>> It was already reverted, but I agree, let's get this fixed first.
>>
>
> It was reintroduced in r250252. It is breaking
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-
Author: echristo
Date: Thu Oct 15 01:56:08 2015
New Revision: 250373
URL: http://llvm.org/viewvc/llvm-project?rev=250373&view=rev
Log:
Update clang for DIBuilder::createSubroutineType API change.
Patch by Amaury Sechet!
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib
Done in r250373.
Thanks!
-eric
On Wed, Oct 14, 2015 at 2:18 PM Amaury SECHET <
deadalnix+llvmrev...@gmail.com> wrote:
> deadalnix created this revision.
> deadalnix added reviewers: chandlerc, dexonsmith, echristo.
> deadalnix added a subscriber: cfe-commits.
>
> This diffs remove use of deprec
Author: echristo
Date: Thu Oct 15 15:04:40 2015
New Revision: 250448
URL: http://llvm.org/viewvc/llvm-project?rev=250448&view=rev
Log:
Add the minimum target features that these tests depend upon.
Modified:
cfe/trunk/test/CodeGen/adc-builtins.c
cfe/trunk/test/CodeGen/builtins-x86.c
Modif
Author: echristo
Date: Thu Oct 15 15:04:42 2015
New Revision: 250449
URL: http://llvm.org/viewvc/llvm-project?rev=250449&view=rev
Log:
The target-feature command line option doesn't take a comma delimited
string, so split them into multiple options.
Modified:
cfe/trunk/test/CodeGen/x86_32-xsa
Author: echristo
Date: Thu Oct 15 17:46:02 2015
New Revision: 250470
URL: http://llvm.org/viewvc/llvm-project?rev=250470&view=rev
Log:
Fix the subtarget features required by some x86 builtins.
Update the fma builtins to be fma/fma4 until some we can find some
documentation either way.
Update a c
Author: echristo
Date: Thu Oct 15 18:47:11 2015
New Revision: 250473
URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev
Log:
Add an error when calling a builtin that requires features that don't
match the feature set of the function that they're being called from.
This ensures that we c
Author: echristo
Date: Thu Oct 15 19:14:36 2015
New Revision: 250475
URL: http://llvm.org/viewvc/llvm-project?rev=250475&view=rev
Log:
Mark this test as requiring and x86 registered target.
Modified:
cfe/trunk/test/CodeGen/target-builtin-noerror.c
Modified: cfe/trunk/test/CodeGen/target-buil
2 ones that list 2 features those features are both
> required, but for FMA you need either one of the features but not both.
> What is the comma separated list currently implemented as?
>
> On Thu, Oct 15, 2015 at 3:46 PM, Eric Christopher via cfe-commits <
> cfe-commits@lists.ll
for the AVX512 ones that list 2 features those features are both
>>> required, but for FMA you need either one of the features but not both.
>>> What is the comma separated list currently implemented as?
>>>
>>> On Thu, Oct 15, 2015 at 3:46 PM, Eric Christoph
t;>>
>>>> So for the AVX512 ones that list 2 features those features are both
>>>> required, but for FMA you need either one of the features but not both.
>>>> What is the comma separated list currently implemented as?
>>>>
>>>> O
Thanks Craig!
-eric
On Thu, Oct 15, 2015 at 10:27 PM Craig Topper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ctopper
> Date: Fri Oct 16 00:25:15 2015
> New Revision: 250496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250496&view=rev
> Log:
> [X86] Add sse4.2 feature name
> are more or less orthogonal.
>
> I guess the fma situation is easier to special case if we want to avoid
> having to parse expressions here. Ie, we could have some kind of
> meta-feature that expands to "fma or fma4". Of course, the obvious name
> for that is &qu
gt; are more or less orthogonal.
> >>
> >> I guess the fma situation is easier to special case if we want to avoid
> >> having to parse expressions here. Ie, we could have some kind of
> >> meta-feature that expands to "fma or fma4". Of course, the obviou
Can't be. We don't know we're going to make the call until we code gen. :)
On Fri, Oct 16, 2015, 7:50 PM Justin Bogner wrote:
> Eric Christopher via cfe-commits writes:
> > Author: echristo
> > Date: Thu Oct 15 18:47:11 2015
> > New Revision: 250473
>
> like it does the right thing in a very cursory test, as well.
>
>
> > On Fri, Oct 16, 2015, 7:50 PM Justin Bogner
> wrote:
> >
> >> Eric Christopher via cfe-commits writes:
> >> > Author: echristo
> >> > Date: Thu Oct 15 18:47:11 2015
>
On Sat, Oct 17, 2015 at 4:30 AM Dimitry Andric wrote:
> On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: echristo
> > Date: Thu Oct 15 18:47:11 2015
> > New Revision: 250473
> >
> &
^
> >
> > for files that include more headers than they need (think x86intrin.h
> being
> > the only header included), but not calling any of the functions and so
> not
> > using a command line option that enables every feature for the x86
> target.
> >
&g
echristo added a comment.
Would this make more sense to put in the Compilation class rather than on the
Action? It seems like it could go next to DefaultToolchain or could even be a
separate toolchain itself so that all of the bits could be looked up?
Thanks!
-eric
http://reviews.llvm.org/D1
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One inline comment, otherwise LGTM.
-eric
Comment at: include/clang/CodeGen/CodeGenAction.h:28
@@ -27,3 +27,3 @@
std::unique_ptr TheModule;
- llvm::Module *LinkModule
echristo added a comment.
I'm ignoring the content of the header, but this seems to be a not terrible way
to do things. I gather that cuda_runtime.h is something that's typically
included by the driver by nvidia and not the client?
Also, tests?
-eric
http://reviews.llvm.org/D13171
___
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I really wish this could be refactored in a better way, that said, this is
better than it was and no harder to refactor at the end.
Thanks.
-eric
http://reviews.llvm.org/D13928
_
echristo added a comment.
Can you give me some more background here? I'm not sure I see what's wrong and
what's going wrong.
Thanks!
-eric
http://reviews.llvm.org/D13610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
echristo accepted this revision.
echristo added a comment.
In http://reviews.llvm.org/D13171#272441, @tra wrote:
> In http://reviews.llvm.org/D13171#272397, @echristo wrote:
>
> > I'm ignoring the content of the header, but this seems to be a not terrible
> > way to do things. I gather that cuda
Author: echristo
Date: Mon Oct 26 19:06:21 2015
New Revision: 251371
URL: http://llvm.org/viewvc/llvm-project?rev=251371&view=rev
Log:
Use early exits to reduce indentation.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/view
On Mon, Oct 26, 2015 at 5:11 PM David Blaikie wrote:
> On Mon, Oct 26, 2015 at 5:06 PM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Mon Oct 26 19:06:21 2015
>> New Revision: 251371
>>
>>
Author: echristo
Date: Tue Oct 27 01:11:03 2015
New Revision: 251388
URL: http://llvm.org/viewvc/llvm-project?rev=251388&view=rev
Log:
Handle target builtin options that are all required rather than
only one of a group of possibilities.
This changes the syntax in the builtin files to represent:
Thank you very much for the suggestion, it helped clean up the algorithm
for what I was trying to do in r251388.
-eric
On Mon, Oct 26, 2015 at 5:12 PM Eric Christopher wrote:
> On Mon, Oct 26, 2015 at 5:11 PM David Blaikie wrote:
>
>> On Mon, Oct 26, 2015 at 5:06 PM, Eric Christo
go down. I guess the question is, which is
>>> >> weirder?
>>> >>
>>> >> - With fma, we have fma4 which is basically a synonym as far as
>>> >> intrinsics go - some chips have 3-argument versions and some have 4,
>>> >>
Author: echristo
Date: Wed Oct 28 01:56:25 2015
New Revision: 251501
URL: http://llvm.org/viewvc/llvm-project?rev=251501&view=rev
Log:
Reflow comment.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
echristo added a comment.
Some inline comments for discussion.
Thanks!
-eric
Comment at: lib/Driver/Driver.cpp:503
@@ -502,3 +502,3 @@
if (TC.getTriple().isOSBinFormatMachO())
-BuildUniversalActions(C->getDefaultToolChain(), C->getArgs(), Inputs,
+BuildUniversalActi
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D13610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sure. You should probably work on the verification side of things as well if
you expect to use this more.
-eric
http://reviews.llvm.org/D14307
echristo added a comment.
I think the basic idea on how to do this is to make sure all of the information
is there from the front end and have the backend select how to emit based on
the code gen flag for this. libLTO is terrible for this, but the schemes
working for lld are showing progress in
echristo added a comment.
My preference for this sort of thing would be an enum of failure reasons, but I
guess this is ok for now. One inline request.
-eric
Comment at: lib/Basic/Targets.cpp:3978-3981
@@ +3977,6 @@
+ bool &HasSizeMismatch)
Author: echristo
Date: Tue Nov 10 20:04:08 2015
New Revision: 252691
URL: http://llvm.org/viewvc/llvm-project?rev=252691&view=rev
Log:
Fix a FIXME about using std::is_sorted.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/vie
Author: echristo
Date: Wed Nov 11 17:05:08 2015
New Revision: 252819
URL: http://llvm.org/viewvc/llvm-project?rev=252819&view=rev
Log:
Extract out a function onto CodeGenModule for getting the map of
features for a particular function, then use it to clean up some
code.
Modified:
cfe/trunk/li
Author: echristo
Date: Wed Nov 11 18:44:12 2015
New Revision: 252834
URL: http://llvm.org/viewvc/llvm-project?rev=252834&view=rev
Log:
Provide a frontend based error for always_inline functions that require
target features that the caller function doesn't provide. This matches
the existing backend
Author: echristo
Date: Wed Nov 11 18:44:04 2015
New Revision: 252832
URL: http://llvm.org/viewvc/llvm-project?rev=252832&view=rev
Log:
In preparation to use it in more places rename
checkBuiltinTargetFeatures to checkTargetFeatures and sink
the error handling into the function.
Modified:
cfe/
Author: echristo
Date: Wed Nov 11 18:44:07 2015
New Revision: 252833
URL: http://llvm.org/viewvc/llvm-project?rev=252833&view=rev
Log:
Move checkTargetFeatures to CodeGenFunction.cpp to make it
more obvious that it's generic.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/Cod
FWIW we should also have the backend avoid inlining and perhaps produce a
diagnostic if something makes it there as well.
-eric
On Wed, Nov 11, 2015 at 4:46 PM Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Nov 11 18:44:1
On Wed, Nov 11, 2015 at 5:03 PM Richard Smith wrote:
> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Wed Nov 11 18:44:12 2015
>> New Revision: 252834
>>
>>
On Wed, Nov 11, 2015 at 5:13 PM David Blaikie wrote:
> On Wed, Nov 11, 2015 at 4:54 PM, David Blaikie wrote:
>
>>
>>
>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author:
On Wed, Nov 11, 2015 at 5:38 PM Richard Smith wrote:
> On Wed, Nov 11, 2015 at 5:25 PM, Eric Christopher
> wrote:
>
>> On Wed, Nov 11, 2015 at 5:03 PM Richard Smith
>> wrote:
>>
>>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
ell.
>>
>> -eric
>>
>> On Wed, Nov 11, 2015 at 4:46 PM Eric Christopher via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: echristo
>>> Date: Wed Nov 11 18:44:12 2015
>>> New Revision: 252834
>>>
>>>
Author: echristo
Date: Thu Aug 6 17:11:54 2015
New Revision: 244286
URL: http://llvm.org/viewvc/llvm-project?rev=244286&view=rev
Log:
Continue the work from r243908 by adding a Features field to Builtin::Info
so that we can populate it on a per-target basis with required features.
Future commits
; On Thu, Aug 6, 2015 at 3:11 PM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Thu Aug 6 17:11:54 2015
>> New Revision: 244286
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244286&view=rev
&
was causing -Wmissing-field-initializers to fire due to Features
>>> not being assigned in BUILTIN or LIBBUILTIN macro expansions. Fixed it in
>>> r244307.
>>>
>>> On Thu, Aug 6, 2015 at 3:11 PM, Eric Christopher via cfe-commits <
>>> cfe-commits@
Author: echristo
Date: Fri Aug 7 13:31:25 2015
New Revision: 244342
URL: http://llvm.org/viewvc/llvm-project?rev=244342&view=rev
Log:
Move the cpu validating virtual method down to the feature routines
where it belongs.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
Modified: cfe/trun
echristo added a comment.
Why isn't the existing +long-calls handling good enough (other than making it a
generic option rather than arm specific)? You don't seem to be using any of the
code in Targets.cpp to do anything.
Also a couple of random comments inline on the patch.
-eric
==
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Not a huge fan of the registration/etc. That said, this is cleaner than a lot
of the alternatives at the moment without making you do a lot of toolchain
evisceration.
LGTM.
-eric
https
echristo added a comment.
Go ahead and split out your cleanups into another patch and remove the custom
handling in the hexagon target then.
Thanks!
-eric
Repository:
rL LLVM
https://reviews.llvm.org/D22766
___
cfe-commits mailing list
cfe-com
Author: echristo
Date: Fri Jul 29 17:11:11 2016
New Revision: 277221
URL: http://llvm.org/viewvc/llvm-project?rev=277221&view=rev
Log:
Remove unused variable.
Fixes PR28761.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/lib/Headers/avx512fintrin.h
URL:
http://llvm.org
Hi Hans,
Can you make sure this makes it into 3.9 please?
Thanks!
-eric
On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Fri Jul 29 17:11:11 2016
> New Revision: 277221
>
> URL: http://llvm.or
> Thanks!
> >
> > -eric
> >
> >
> > On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits
> > wrote:
> >>
> >> Author: echristo
> >> Date: Fri Jul 29 17:11:11 2016
> >> New Revision: 277221
> >&
echristo added a comment.
You haven't removed the custom handling?
-eric
Repository:
rL LLVM
https://reviews.llvm.org/D22766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: echristo
Date: Thu Aug 4 01:02:50 2016
New Revision: 277696
URL: http://llvm.org/viewvc/llvm-project?rev=277696&view=rev
Log:
After PR28761 use -Wall with -Werror in builtins tests to identify
possible problems in headers.
Modified:
cfe/trunk/test/CodeGen/3dnow-builtins.c
cfe/tru
echristo added a comment.
Seems reasonable to fix the tests?
https://reviews.llvm.org/D22943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
OK, please go back and document in ToolChain.h the difference between the
Triple and the EffectiveTriple - at length, as a follow on patch.
-eric
https://reviews.llvm.org/D22944
_
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
OK.
-eric
https://reviews.llvm.org/D22945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
echristo added a comment.
In http://reviews.llvm.org/D16538#344540, @joelkevinjones wrote:
> Ping.
The FIXME at cc1as_main.cpp:413
http://reviews.llvm.org/D16538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
(Without looking)
Please go ahead and feel free to commit any documentation to the intrinsic
files. :)
On Thu, Feb 4, 2016, 5:59 PM Katya Romanova <
katya_roman...@playstation.sony.com> wrote:
> kromanova created this revision.
> kromanova added reviewers: ygao, echristo, jroelofs, gribozavr,
>
:)
We can look at them/deal with them in post-commit review from here on out.
No need to block on me.
-eric
On Thu, Feb 4, 2016 at 6:50 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Thank you!
>
> Paul Robinson did a very detailed code review yesterday, so I suspect that
>
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This works for me and I can't think of anything it's going to break so LGTM.
Thanks!
-eric
http://reviews.llvm.org/D16514
___
cfe-commits mailing list
On Tue, Feb 9, 2016 at 4:16 PM Ekaterina Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kromanova
> Date: Tue Feb 9 18:12:24 2016
> New Revision: 260333
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260333&view=rev
> Log:
> This patch adds doxygen comments for all the
Mostly that you didn't mention it in your commit message.
I'd rather prefer the rest of the file be changed to match the __ rather
than the other way around :)
-eric
On Wed, Feb 10, 2016 at 4:14 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Hi Eric,
>
> Everywhere else in t
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Wow really? That's ... wow.
OK
http://reviews.llvm.org/D17111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
echristo added inline comments.
Comment at: lib/Driver/Tools.cpp:10707
@@ +10706,3 @@
+// ptxas does not accept -g option if optimization is enabled, so we ignore
+// compiler's -O* options if we want debug info.
+CmdArgs.push_back("-g");
jlebar wrote:
echristo added inline comments.
Comment at: lib/Driver/Tools.cpp:10707
@@ +10706,3 @@
+// ptxas does not accept -g option if optimization is enabled, so we ignore
+// compiler's -O* options if we want debug info.
+CmdArgs.push_back("-g");
tra wrote:
>
On Wed, Feb 10, 2016 at 5:07 PM Joerg Sonnenberger
wrote:
> On Thu, Feb 11, 2016 at 12:18:49AM +0000, Eric Christopher via cfe-commits
> wrote:
> > Mostly that you didn't mention it in your commit message.
> >
> > I'd rather prefer the rest of the file be chang
echristo added inline comments.
Comment at: lib/Driver/Tools.cpp:10707
@@ +10706,3 @@
+// ptxas does not accept -g option if optimization is enabled, so we ignore
+// compiler's -O* options if we want debug info.
+CmdArgs.push_back("-g");
tra wrote:
>
Author: echristo
Date: Thu Feb 11 18:32:23 2016
New Revision: 260631
URL: http://llvm.org/viewvc/llvm-project?rev=260631&view=rev
Log:
Use __ before argument names in provided headers.
Modified:
cfe/trunk/lib/Headers/f16cintrin.h
Modified: cfe/trunk/lib/Headers/f16cintrin.h
URL:
http://llvm
ocument.
>
>
>
>
>
> On Wed, Feb 10, 2016 at 5:07 PM Joerg Sonnenberger <
> jo...@britannica.bec.de> wrote:
>
> On Thu, Feb 11, 2016 at 12:18:49AM +, Eric Christopher via cfe-commits
> wrote:
> > Mostly that you didn't mention it in your commit m
Author: echristo
Date: Thu Feb 11 20:22:53 2016
New Revision: 260647
URL: http://llvm.org/viewvc/llvm-project?rev=260647&view=rev
Log:
Update functions in clang supplied headers to use the compiler reserved
namespace for arguments.
Modified:
cfe/trunk/lib/Headers/__clang_cuda_cmath.h
cfe/
Ah thanks. Since my running the test suite yesterday didn't notice, perhaps
a test would be appropriate as well. :)
On Fri, Feb 12, 2016, 12:31 PM Artem Belevich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: tra
> Date: Fri Feb 12 14:26:43 2016
> New Revision: 260719
>
> URL: htt
*nod* I figure at least include them into something :)
-eric
On Fri, Feb 12, 2016 at 1:31 PM Artem Belevich wrote:
> No problem. It's hard to test CUDA wrappers properly without real CUDA
> headers. :-(
>
>
> On Fri, Feb 12, 2016 at 1:28 PM, Eric Christopher
> wrote:
>
>> Ah thanks. Since my r
Hi Adrian,
I'm taking a look at this and can't duplicate using the testcase you gave
without your patch(es) applied. It's also causing asserts in other code as
you can have the forward decl left around and the CU isn't a valid context.
Can you take a look/revert until you've got a different testc
echristo added inline comments.
Comment at: lib/Basic/Targets.cpp:1829
@@ -1820,2 +1828,3 @@
}
+
AddrSpaceMap = &AMDGPUAddrSpaceMap;
Extra whitespace.
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+ if (Has16BitInsts)
+
Hi Adrian,
On Sat, Feb 20, 2016 at 1:18 PM Adrian Prantl wrote:
> This had me puzzled for a second, but then I figured out what happened :-)
> The “crash” I quoted in the commit message really was an assertion
> failure, to be precise, the very assertion I relaxed in LLVM r259973 in
> order to b
Thanks Adrian!
On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote:
> --> r261657.
>
> Author: adrian
> Date: Tue Feb 23 17:13:47 2016 +
>
> Remove an unnecessary workaround introduced in r259975. (NFC)
>
> Now that LLVM r259973 allows replacing a temporary type with another
>
echristo added a subscriber: echristo.
echristo added a comment.
Yeah, we should be doing this. Nice catch Paul and Greg.
Repository:
rL LLVM
http://reviews.llvm.org/D17550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Yeah, we should be doing this. Nice catch Paul and Greg.
On Tue, Feb 23, 2016, 10:34 PM Greg Bedwell
wrote:
> gbedwell added a subscriber: gbedwell.
> gbedwell added a comment.
>
> In http://reviews.llvm.org/D17550#360177, @probinson wrote:
>
> > One question I have, which shouldn't block this (
Nice catch. :)
On Wed, Feb 24, 2016, 10:43 AM Bob Wilson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bwilson
> Date: Wed Feb 24 12:38:35 2016
> New Revision: 261762
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261762&view=rev
> Log:
> Fix typo in test/CodeGen/object-size.c
Those are all compelling reasons for me. Let's go with whatever you and
Dmitri think would be best for now. :)
-eric
On Wed, Feb 24, 2016 at 12:41 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Hello,
>
>
>
> I don’t think it will too hard to convert C++ style doxygen comment
301 - 400 of 571 matches
Mail list logo
