:) We can look at them/deal with them in post-commit review from here on out. No need to block on me.
-eric On Thu, Feb 4, 2016 at 6:50 PM Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Thank you! > > Paul Robinson did a very detailed code review yesterday, so I suspect that > this doxygen comment patch is of very good quality. J > > Katya. > > > > *From:* Eric Christopher [mailto:echri...@gmail.com] > *Sent:* Thursday, February 04, 2016 6:47 PM > *To:* reviews+d16913+public+13cb39057c425...@reviews.llvm.org; Romanova, > Katya; Gao, Yunzhong; jonat...@codesourcery.com; griboz...@gmail.com; > craig.top...@gmail.com; Robinson, Paul > *Cc:* cfe-commits@lists.llvm.org > *Subject:* Re: [PATCH] D16913: Adding doxygen comments to the LLVM > intrinsics (part 4, pmmintrin.h) > > > > (Without looking) > > Please go ahead and feel free to commit any documentation to the intrinsic > files. :) > > > > On Thu, Feb 4, 2016, 5:59 PM Katya Romanova < > katya_roman...@playstation.sony.com> wrote: > > kromanova created this revision. > kromanova added reviewers: ygao, echristo, jroelofs, gribozavr, > craig.topper, probinson. > kromanova added a subscriber: cfe-commits. > kromanova set the repository for this revision to rL LLVM. > > Hello, > > Here is the patch with the doxygen comments for the intrinsincs in the > header file pmmintrin.h. > The doxygen comments are automatically generated based on SCE internal > intrinsics document using DCG tool that I wrote. > > I will submit more doxygen comments for the other intrinsic header files > as soon as this patch is approved. > > Here is the link to the general discussion about adding comments to x86 > intrinsics headers. > http://permalink.gmane.org/gmane.comp.compilers.clang.devel/42032 > > Here are the links to the similar code reviews for the doxygen comments > other header files. > > http://reviews.llvm.org/D8762 (closed) > http://reviews.llvm.org/D15999 (closed) > http://reviews.llvm.org/D16562 (closed) > > Katya. > > Repository: > rL LLVM > > http://reviews.llvm.org/D16913 > > Files: > pmmintrin.h > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
