[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1035 + const RecordDecl *D = RD->getDefinition(); + if (D && D->isCompleteDefinition()) +Size = CGM.getContext().getTypeSize(Ty); akhuang wrote: > dblaikie wrote: > > When is a def

[PATCH] D87062: [DebugInfo] Add size to class declarations in debug info.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf1a96408b1: [DebugInfo] Add size to class declarations in debug info. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. There are some types in libcxx that are used but their constructors are not called (__hash_node, __hash_value_typ

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. No, chromium doesn't need this fixed in clang, but I didn't see a clear way to fix this in libc++. Do you think it should be fixed as a bug in libc++? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90719/new/ https://review

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. In D90719#2377485 , @dblaikie wrote: > In D90719#2377324 , @rnk wrote: > >> I had another thought, which is that even if it is UB, perhaps we really >> shouldn't be using UB as the basis fo

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a subscriber: ldionne. akhuang added a comment. + @ldionne for libc++ input? To summarize, this constructor homing debug info optimization makes the assumption that if a class is being used then its constructor must have been called at some point. We noticed that some libc++ types

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. This was motivated by changes to llvm's `not --crash` disabling symbolization but I ended up removing `not` from the script entirely because it returns d

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang updated this revision to Diff 304964. akhuang marked an inline comment as done. akhuang added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91372/new/ https://reviews.llvm.org/D91372 Files: clang/utils/creduce-

[PATCH] D91372: Some updates/fixes to the creduce script.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c80b542d38b: Some updates/fixes to the creduce script. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. Ok, it seems like the general opinion here is that libc++ should be changed in some way and not ctor homing. I don't know who'd be responsible for changing the libc++ code, though. Maybe I should file a bug for libc++? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. Thanks, looks like I'll try to see if libcxx code can be changed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90719/new/ https://reviews.llvm.org/D90719 ___ cfe-commits ma

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Add class types to the retained types list to make sure they don't get dropped if the constructor is optimized out la

[PATCH] D88522: [DebugInfo] Add types from constructor homing to the retained types list.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4fc581d5fe: [DebugInfo] Add types from constructor homing to the retained types list. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. akhuang requested review of this revision. We used to only emit static const data members in CodeView as S_CONSTANTS when they

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. In D89072#2320209 , @dblaikie wrote: > I'll probably leave the llvm/CodeView parts of this for @rnk - but for the > clang parts, they should have corresponding clang test coverage & I'd be > curious to see the test for that to un

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 297068. akhuang added a comment. Update clang test for static data members, and make it test the general cases on the windows target as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://rev

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Debug info for inline static data members was missing the constant value, because the initializer for these static da

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang added a subscriber: rsmith. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1421-1425 + else if (auto *TemplateDecl = Var->getInstantiatedFromStaticDataMember()) { +// Inline static data members might not have an initialization. +if (

[PATCH] D89286: [DebugInfo] Check for templated static data member when adding constant to record static fields

akhuang updated this revision to Diff 298243. akhuang added a comment. update test case and add check for dependent values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89286/new/ https://reviews.llvm.org/D89286 Files: clang/lib/CodeGen/CGDebugI

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 298258. akhuang marked an inline comment as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/C

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +//

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added a comment. Whoops, forgot to check the tests. Apparently `mapEncodedInteger` asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 300438. akhuang added a comment. Fix test failures; remove assert for signed APSInts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/CGDebug

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG515973222ed2: [CodeView] Emit static data members as S_CONSTANTs. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang added a comment. Patch to emit signed ints for other S_CONSTANTs: https://reviews.llvm.org/D90199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 ___ cfe-

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. Reverted because my copied `isUnsignedDIType` function had problems (guess I copied it at first but then was messing with the code); I moved it to DebugHandlerBase.h so it doesn't need to be

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 301080. akhuang added a comment. Herald added a subscriber: jfb. Moved isUnsignedDIType to DebugHandlerBase to avoid copying it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7669f3c0f69d: Recommit "[CodeView] Emit static data members as S_CONSTANTs." (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang created this revision. akhuang added reviewers: rnk, aganea, amccarth. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first wri

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:872 // using stdin. + void *FileHandle = nullptr; +#ifdef _WIN32 I'm saving the windows HANDLE here instead of using `fd` because for some reason calling `_get_osfhandle(fd)`

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added a comment. In D102736#2769358 , @amccarth wrote: > At some point, the duplicate handle must be closed. I don't see that > happening. I've added an inline comment where I think it should be done. > > (I find it weird that duplicating the h

[PATCH] D102876: Fix tmp files being left on Windows builds.

akhuang created this revision. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first writing to a .tmp file and then renaming to the fi

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang marked 2 inline comments as done. akhuang added a comment. In D102736#2769747 , @akhuang wrote: > In D102736#2769358 , @amccarth > wrote: > >> At some point, the duplicate handle must be closed. I don't

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 346882. akhuang added a comment. Change to using TempFiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 Files: clang/include/clang/Frontend/CompilerInstance.h

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang marked 2 inline comments as done. akhuang added a comment. In D102736#2767432 , @aganea wrote: > Do you think the existing crash tests can be modified to validate that .tmp > files are deleted indeed? Looks like the existing crash tests use `#pr

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 347090. akhuang marked an inline comment as done. akhuang added a comment. Use TempFile on both linux and windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 File

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: llvm/lib/Support/Path.cpp:1237 RenameEC = copy_file(TmpName, Name); setDeleteDisposition(H, true); } amccarth wrote: > I'm curious if this path has ever been exercised. > > I see that rename_handle is

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 347802. akhuang marked 5 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 Files: clang/include/cla

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently (for codeview) lambdas have a string like `` in their mangled name, and don't have any display name. Th

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 318657. akhuang added a comment. -add to comment -Add externally visible lambda to test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clan

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319348. akhuang marked an inline comment as done. akhuang added a comment. change to function returning a number, fill in ItaniumMangle function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + rnk wrote: > I think I would prefer to have this return a number. I think CGDebugInfo > should be responsibl

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319379. akhuang added a comment. Avoid using getLambdaId function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clang/AST/Mangle.h clang/lib/

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + rnk wrote: > akhuang wrote: > > rnk wrote: > > > I think I would prefer to have this return a number. I think

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 319668. akhuang added a comment. make function return lambda string, and add test for lambda in function parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Fil

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd73564c51003: [DebugInfo][CodeView] Use as the display name for lambdas. (authored by akhuang). Changed prior to commit: https://review

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 320020. akhuang added a comment. Fix test / string code after test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clang/AST/Mangle.h

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5f5deee9ee9: Reland "[DebugInfo][CodeView] Use as the display name for lambdas" (authored by akhuang). Repository: rG LLVM Github Mono

[PATCH] D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding this, since there's currently no documentation about this. Repository: rG LLVM Github Monorepo https:

[PATCH] D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26e9c99010b6: [Docs] Add some documentation for constructor homing, a debug info optimization… (authored by akhuang). Repository: rG LLVM Github M

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang created this revision. akhuang added a reviewer: aaron.ballman. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're currently using address spaces to implement __ptr32/__ptr64 attributes; this patch fixes a bug where clang

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682 + isPtrSizeAddressSpace(Q2.getAddressSpace())) +MaybeQ1 = true; + else aaron.ballman wrote: > I'm pretty sure this is correct based on my inspection o

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

akhuang added a comment. Seems like there are also errors in chrome builds and the llvm compiler-rt build, will just revert it for now -- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 _

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682 + isPtrSizeAddressSpace(Q2.getAddressSpace())) +MaybeQ1 = true; + else aaron.ballman wrote: > akhuang wrote: > > aaron.ballman wrote: > > > I'm pretty

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang updated this revision to Diff 376936. akhuang added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110670/new/ https://reviews.llvm.org/D110670 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/CodeGen/ms-mixed-ptr-si

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, rsmith. Herald added a reviewer: aaron.ballman. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was motivated by the fact that constructor type homing (debu

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang marked an inline comment as done. akhuang added a comment. In D97411#2586201 , @dblaikie wrote: > Oh, that might be a bit different again - if the type isn't required to be > complete in this translation unit, should this attribute override the >

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1665 + let Spellings = [Clang<"force_debug_if_required_type">]; + let Subjects = SubjectList<[CXXRecord]>; + let Documentation = [Undocumented]; dblaikie wrote: > aaron.ballman wrote:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a subscriber: ldionne. akhuang added a comment. @ldionne Do you think it'd be reasonable to add this debug info attribute to some types in libc++? (For types that have constructors but don't call them; some previous discussion in https://reviews.llvm.org/D90719). Repository: rG

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326438. akhuang marked an inline comment as done. akhuang added a comment. -Add LangOpts[CPlusPlus] to the attribute -Maybe change the attribute to also override required complete types and change name to standalone_debug Repository: rG LLVM Github Monore

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang closed this revision. akhuang added a comment. Committed in 9d070b2f4889887f9ce497592ef01df7b9601a1c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://re

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added a comment. yep, I'll look into it, probably sometime tomorrow-- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 ___ cfe-commits mailing list cfe-c

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:857-858 + OS.reset(new llvm::raw_fd_ostream(Temp->FD, /*shouldClose=*/false, +Binary ? llvm::sys::fs::OF_None +

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang created this revision. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when searching for header files (with relative paths) we concatenate the path to the module map with the header filename. However when searchin

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang updated this revision to Diff 366153. akhuang added a comment. add case for include_nexts; I don't entirely understand this part of the code so not sure if it's what we want, but it seems to make building with -no-canonical-prefixes happier Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D107921: [Modules] Fix bug where header resolution in modules doesn't work when compiling with relative paths.

akhuang updated this revision to Diff 366344. akhuang added a comment. undo previous change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107921/new/ https://reviews.llvm.org/D107921 Files: clang/lib/Lex/HeaderSearch.cpp Index: clang/lib/Lex/H

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326738. akhuang marked an inline comment as done. akhuang added a comment. -Add documentation -Add more test cases and semantics tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.ll

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2591030 , @aaron.ballman wrote: > Thanks! I am still curious about the forward declare/redeclaration behavior > and whether that is a situation that makes sense or not. I suspect this case > may make sense (and likely

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326787. akhuang marked 3 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2594345 , @ldionne wrote: > I don't have an opinion about the attribute itself. I do have an opinion > about using that attribute in libc++ instead of fixing the underlying issue > (I think we shouldn't do it). Can you

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2595155 , @dblaikie wrote: > In D97411#2595049 , @akhuang wrote: > >> In D97411#2594345 , @ldionne wrote: >> >>> I don't have an opinion ab

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. I think they're all singular types, like __hash_node . Actually, `__tree_node` might not be problematic. I could look more at the types if it's helpful; I

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a reviewer: EricWF. akhuang added a subscriber: EricWF. akhuang added a comment. @EricWF, comments on using this attribute in libc++ vs fixing the code otherwise? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://revie

[PATCH] D98472: Emit inline implementation of __builtin__wmemchr on MSVCRT platforms.

akhuang created this revision. akhuang added a reviewer: rnk. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The MSVC runtime library doesn't have a definition for wmemchr, so provide an inline implementation. Repository: rG LL

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 330316. akhuang added a comment. Herald added a subscriber: jdoerfert. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang/Bas

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 330344. akhuang added a comment. add allowInC to attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cd208f08af: [DebugInfo] Add an attribute to force type info to be emitted for types that… (authored by akhuang). Repository: rG LLVM Github Mono

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang created this revision. akhuang added a reviewer: rnk. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update docs to reflect the fact that this flag is on by default now. Repository: rG LLVM

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang added a comment. In D136188#3866266 , @dblaikie wrote: > (not sure whether to discuss this here or on the bug) > > Should we remove the documentation? Part of the principles of "cc1" flags is > that their implementation details, not to be publicl

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 468677. akhuang edited the summary of this revision. akhuang added a comment. Remove documentation paragraph. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files:

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang added a comment. Actually, maybe I should add some of this info to the -fstandalone-debug section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 ___

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 468687. akhuang added a comment. Move ctor homing info to fstandalone-debug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rst Ind

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 471240. akhuang added a comment. Add another debug info strategy to the description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rs

[PATCH] D136188: Update docs for -fuse-ctor-homing

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8433a2b06d5: Update docs for -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D1

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang created this revision. Herald added a subscriber: nlopes. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136998 Files: clang/l

[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

akhuang added a comment. We're seeing this warning in code with global constants, e.g. const Enum x = static_cast(-1); is this intended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131704/new/ https://reviews.llvm.org/D131704 ___

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang added a comment. In D133959#3793283 , @hans wrote: > Could the new flag be marked as an Alias in the tablegen, so that we don't > need to do any code changes for it? It appears before _SLASH_Zl in the file so we'd have to move it out of place.

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462042. akhuang marked an inline comment as done. akhuang added a comment. Change name of flag, and alias /Zl to this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D13

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462230. akhuang marked an inline comment as done. akhuang added a comment. Fix flag name in test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959 Files: clang/i

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG3283f71069a0: Add clang flag equivalent to clang-cl /Zl flag (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://review

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added a comment. In D133457#3832590 , @mstorsjo wrote: > @akhuang I noticed that > https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/MSVC.cpp#L199-L200 > has got an explicit check for `Args.hasArg(options::OPT__SLASH_MD,

[PATCH] D135730: Make inalloca lambda parameters work (for 32-bit windows).

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug where inalloca arguments can't be used as parameters in non-capturing lambdas. Repository: rG LLVM Gith

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 472447. akhuang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGClass.cpp clang/

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 472450. akhuang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 472761. akhuang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType()); +

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType()); +

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType()); +

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 473082. akhuang added a comment. moved some stuff around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/Co

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType()); +

<    1   2   3   4   5   >