akhuang added a comment. In D97411#2594345 <https://reviews.llvm.org/D97411#2594345>, @ldionne wrote:
> I don't have an opinion about the attribute itself. I do have an opinion > about using that attribute in libc++ instead of fixing the underlying issue > (I think we shouldn't do it). Can you confirm what the problematic types are? > In another patch I saw `__hash_node`, `__hash_value_type`, `__tree_node` and > `__value_type`. Is that it? Not entirely sure - those were pointed out as types with missing debug info, but there might be more. I tried looking for types in libc++ that have a `value_type` member, since those seem to follow a similar pattern. Possibly `__forward_list_node`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
