akhuang added a comment.

In D133457#3832590 <https://reviews.llvm.org/D133457#3832590>, @mstorsjo wrote:

> @akhuang I noticed that 
> https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/MSVC.cpp#L199-L200
>  has got an explicit check for `Args.hasArg(options::OPT__SLASH_MD, 
> options::OPT__SLASH_MDd)` - I think that this would need to be amended to 
> handle these cases too - or is that inferred from here somehow?

You're right, those cases aren't being handled right now. I'll upload a patch 
for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133457/new/

https://reviews.llvm.org/D133457

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D133457: Add Clang... Martin Storsjö via Phabricator via cfe-commits
    • [PATCH] D133457: Add ... Amy Huang via Phabricator via cfe-commits

Reply via email to