akhuang added inline comments.

================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682
+              isPtrSizeAddressSpace(Q2.getAddressSpace()))
+            MaybeQ1 = true;
+          else
----------------
aaron.ballman wrote:
> I'm pretty sure this is correct based on my inspection of what code MSVC is 
> generating. But it would be helpful to have some codegen tests in Clang for 
> this functionality as well.
ha, I apparently didn't check that the behavior actually matches.. apparently 
in MSVC a ptr32 isn't equivalent to a ptr64


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110670/new/

https://reviews.llvm.org/D110670

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to