[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

aemerson abandoned this revision. aemerson added a comment. In https://reviews.llvm.org/D40864#1100492, @dexonsmith wrote: > Did this eventually go in? No, this approach was superseded. I will upstream a new implementation in the near future. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D46863: [X86] Use __builtin_convertvector to implement some of the packed integer to packed float conversion intrinsics.

aemerson added a comment. Hi Craig, The `__builtin_ia32_cvtdq2ps` builtin seems to be supported by gcc, and this change breaks code which has been using this without problems for years. Can we restore it? Amara Repository: rC Clang https://reviews.llvm.org/D46863 __

[PATCH] D43108: Support for the mno-stack-arg-probe flag

aemerson added a comment. Can we clarify the meaning of this option a bit. The doc you've added here is saying that `-mno-stack-arg-probe` disables stack probes. Then what does `-mstack-arg-probe` mean specifically? Does it mean that only stack probes for ABI required reasons are enabled, or pr

[PATCH] D43108: Support for the mno-stack-arg-probe flag

aemerson added a comment. In https://reviews.llvm.org/D43108#1023300, @nruslan wrote: > By default, stack probes are enabled (i.e., -mstack-arg-probe is the default > behavior) and have the size of 4K in x86. This part what I wanted to clarify, `-mstack-probe-arg` is enabling stack probes if

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

aemerson updated this revision to Diff 189237. aemerson retitled this revision from "[Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library." to "[Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.". aemerson edite

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

aemerson added a comment. In D58320#1418477 , @peter.smith wrote: > I've no objections to adding the command line as a Darwin only option. > Implementation looks fine to me although I've not got any prior experience > with Darwin. Thanks, @ab ok for Da

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson created this revision. aemerson added reviewers: kristof.beyls, t.p.northover, olista01. aemerson added a project: clang. Herald added subscribers: arphaman, javed.absar. Some intrinsics like saturating operations may set flags, so if the scalar arg is inserted into an undef vector, the

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson created this revision. aemerson added reviewers: paquette, eli.friedman, t.p.northover. aemerson added projects: LLVM, clang. Herald added subscribers: Petar.Avramovic, hiraditya, kristof.beyls, javed.absar. This is the result of discussions on the list about how to deal with intrinsics

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson updated this revision to Diff 191745. aemerson added a comment. Minor test tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson added a comment. I've put up a langref change as a separate review: D59657 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 _

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson marked an inline comment as done. aemerson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; ---

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson updated this revision to Diff 191774. aemerson added a comment. Simplify logic and don't try to upgrade if IR is invalid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

This revision was automatically updated to reflect the committed changes. Closed by commit rL356722: [AArch64] Split the neon.addp intrinsic into integer and fp variants. (authored by aemerson, committed by ). Changed prior to commit: https://reviews.llvm.org/D59655?vs=191774&id=191792#toc Rep

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson added a comment. In D59615#1439153 , @t.p.northover wrote: > Did you look into a scalar variant of the intrinsic call instead? These > instructions have non-vector variants (e.g. `sqadd s0, s0, s0`), and that's > actually why the intrinsics exi

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson added a comment. Ping. I've filed PR41260 for the code quality issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59615/new/ https://reviews.llvm.org/D59615 ___ cfe-commits mailing list cfe-

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson created this revision. aemerson added reviewers: peter.smith, dexonsmith, ab. aemerson added a project: clang. Herald added subscribers: jdoerfert, jfb. This driver flag is useful when users want to link against the compiler's builtins, but nothing else, and so use flags like -nostdlib.

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson added a comment. In D58320#1402254 , @peter.smith wrote: > The implementation changes in the Darwin toolchain look fine to me, although > with respect to the command line option I think Petr Hosek's message on > cfe-dev is interesting: > > > GCC

[PATCH] D58320: [Darwin] Introduce a new flag, -flink-builtins-rt that forces linking of the builtins library.

aemerson abandoned this revision. aemerson added a comment. After discussion on the thread, we can implement this requirement with -nolibc -nostdlib++ -nostartfiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58320/new/ https://reviews.llvm.org/

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

aemerson marked an inline comment as done. aemerson added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2084 AddLinkRuntimeLib(Args, CmdArgs, CompilerRT, RLO_IsEmbedded); } ab wrote: > This is different from 'builtins'. Are you OK wit

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL360483: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the… (authored by aemerson, committed by

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson added a comment. Herald added a subscriber: danielkiss. Does anyone object to this? I'd like to get it off my review dashboard one way or the other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59615/new/ https://reviews.llvm.org/D59615

[PATCH] D59615: [AArch64] When creating SISD intrinsic calls widen scalar args into a zero vectors, not undef

aemerson abandoned this revision. aemerson added a comment. Seems no one is enthusiastic about this change, so I'm going to drop it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59615/new/ https://reviews.llvm.org/D59615 _

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

aemerson created this revision. Add a new -mstack-probe and -mno-stack-probe option to enable the generation of stack probing functions on non-Windows platforms, if supported. This patch only enables this for Darwin. Repository: rC Clang https://reviews.llvm.org/D40864 Files: include/cla

[PATCH] D40864: [Darwin] Add a new -mstack-probe option and enable by default

aemerson added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:442 Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning(); + Options.EnableStackProbe = CodeGenOpts.StackProbe; ahatanak wrote: > Is there a reason you can't use function attributes

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

aemerson added a comment. I just reverted this in 6e6be5f9504d because it seems to have broken macOS builds: llvm/lib/Support/Compression.cpp:24:10: fatal error: 'zstd.h' file not found #include ^~~~ Rep

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aemerson created this revision. aemerson added reviewers: paquette, Gerolf, ab, t.p.northover, arsenm. aemerson added a project: LLVM. Herald added a subscriber: kristof.beyls. Herald added a project: All. aemerson requested review of this revision. Herald added subscribers: MaskRay, wdng. Herald a

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aemerson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7218-7219 + CmdArgs.push_back("-global-isel=1"); + CmdArgs.push_back("-mllvm"); + CmdArgs.push_back("-global-isel-abort=0"); +} arsenm wrote: > Why abort=0? I can

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aemerson updated this revision to Diff 472753. aemerson added a comment. Add a clang release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https://reviews.llvm.org/D137269 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/T

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf64802e8d3e9: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64… (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D137269?vs=472753&id=473807#toc Repositor

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aemerson added a comment. Sorry, for some reason I hadn’t received any emails about this so I only noticed now. I’ll look into the issues and come back once the issues are resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https:

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aemerson added a comment. Gentle ping on this discussion. @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.llvm.org/D127762 ___ cfe-commits mailing list cfe-commit

[PATCH] D77103: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

aemerson added a comment. Sorry, forgot to add cfe-commits to the original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77103/new/ https://reviews.llvm.org/D77103 ___ cfe-commits mailing list cf

[PATCH] D77103: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

aemerson created this revision. aemerson added reviewers: paquette, arsenm, qcolombet, bogner. aemerson added a project: LLVM. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls, wdng. Herald added a project: clang. aemerson added a comment. Sorry, forgot to add cfe-commits to the or

[PATCH] D77103: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f1ea924c695: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it. (authored by aemerson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4115986 , @aeubanks wrote: > __clang_hip_math.hip is annoying... > > We'll need to remove the `MandatoryFirst` inliner in > `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with > that or not

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4116114 , @aeubanks wrote: > In D143624#4116080 , @aemerson > wrote: > >> In D143624#4115986 , @aeubanks >> wrote: >> >>> __clang_hi

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4116546 , @aeubanks wrote: > Had a chat offline with @mtrofin, wanted to be clear for future purposes that > we do need the separate AlwaysInliner pass because it's used in -O0 and > constructing a call graph there i

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1082 + MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false)); + aeubanks wrote: > aeubanks wrote: > > I think we want to insert lifetime intrinsics when optimizin

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4118257 , @dmgreen wrote: > Hello - I had to revert this because of some large regressions we got from > routines in CMSIS-DSP. > > The llvm/test/Transforms/PhaseOrdering/ARM/arm_mult_q15.ll test shows the > problem

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4118341 , @dmgreen wrote: >> It’s not clear from the original commit message why the test is related to >> inlining order? It seems entirely testing vectorization cost model which >> should be insensitive to these ki

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. I have another attempt at fixing this in D149918 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143624/new/ https://reviews.llvm.org/D143624 _

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. Herald added a subscriber: jplehr. @dmgreen I've been looking at this test again trying to see what's missing. The problem now is that only a VF of 4 is chosen. In the good case, instcombine/simplifyCFG runs so that it simplifies down to an `smin` intrinsic. After this

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4312905 , @dmgreen wrote: > Hello. It sounds like it is really close to being OK. The combine of the > shift just seem to make things more difficult. > > The `icmp ult i1 %cmp4.i, true` is just a not, would it help if

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

aemerson created this revision. aemerson added a project: clang. Herald added subscribers: kristof.beyls, tschuett, javed.absar. [AArch64] Add support for handling the +sve target feature. This also adds the appropriate predefine for SVE if enabled. Depends on https://reviews.llvm.org/D35076 R

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

aemerson added inline comments. Comment at: lib/Basic/Targets.cpp:6245 enum FPUModeEnum { -FPUMode, -NeonMode +NeonMode = (1 << 0), +SveMode = (1 << 1) rengolin wrote: > Is there any AArch64 arch without SIMD? > > Anyway, that seems deliberate

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

aemerson added a comment. In https://reviews.llvm.org/D35118#806730, @rengolin wrote: > @jmolloy Can you check this change, please? I'm not really removing FPUMode, I'm just converting an enum to a bit field. FPUMode, i.e. no NEON, after this change is now represented by simply having all bit

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

aemerson updated this revision to Diff 106386. aemerson added a comment. The reason it's removed is because it's not actually used anywhere, just as a default value. I'm not going to debate it further though so I've put it back in. Repository: rL LLVM https://reviews.llvm.org/D35118 Files:

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL307919: [AArch64] Add support for handling the +sve target feature. (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D35118?vs=106386&id=106432#toc Repository: rL LLVM https

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson created this revision. aemerson added reviewers: qcolombet, echristo. Herald added subscribers: kristof.beyls, rovka. Add an -fexperimental-isel driver option to enable/disable GlobalISel. This is a more user friendly way of enabling GlobalISel instead of doing -mllvm -global-isel. Re

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson updated this revision to Diff 130530. Repository: rC Clang https://reviews.llvm.org/D42276 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/global-isel.c Index: test/Driver/global-isel.c

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4699 +else + CmdArgs.push_back("-global-isel=0"); + } qcolombet wrote: > qcolombet wrote: > > I think that it would be useful to also set -global-isel-abort=2, so that > > user

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson updated this revision to Diff 131191. aemerson added a comment. I've added two kinds of warnings, one for targets which have incomplete GISel support, and another for unsupported optimisation levels (for ARM64 -O{1,2,3,s,z}). Repository: rC Clang https://reviews.llvm.org/D42276 Fi

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

This revision was automatically updated to reflect the committed changes. Closed by commit rC323485: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel. (authored by aemerson, committed by ). Repository: rC Clang https://reviews.llvm.org/D42276 Files: include/cla

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

aemerson created this revision. aemerson added reviewers: hans, qcolombet. Add note for the new -fexperimental-isel flag. Repository: rC Clang https://reviews.llvm.org/D42860 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ===

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

aemerson added a comment. @Hans if you're happy with this could you commit to the branch? Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

aemerson created this revision. aemerson added reviewers: paquette, ahmed, qcolombet, pete. aemerson added a project: clang. Herald added subscribers: steven_wu, hiraditya. aemerson requested review of this revision. GlobalISel is currently not enabled when using -flto since the front-end -mvllm

[PATCH] D99126: [darwin][driver] Pass through -global-isel LLVM flags to ld.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66af90b46e1f: [darwin][driver] Pass through -global-isel LLVM flags to ld. (authored by aemerson). Repository: rG LLVM Github Monorepo CHANGES SI