aemerson marked an inline comment as done.
aemerson added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2084
 
   AddLinkRuntimeLib(Args, CmdArgs, CompilerRT, RLO_IsEmbedded);
 }
----------------
ab wrote:
> This is different from 'builtins'.  Are you OK with the difference?  
> Otherwise maybe this should be an error for now;  I wouldn't be surprised if 
> we never hit this path (this part, I'm not familiar with)
I'm ok with it because we'll just ignore the option for the ARM embedded case, 
if that ever changes we can implement it later. I don't think we'll need to 
though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58320/new/

https://reviews.llvm.org/D58320



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D58320: [Darwin] Int... Amara Emerson via Phabricator via cfe-commits

Reply via email to