aemerson added inline comments.
================ Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1082 + MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false)); + ---------------- aeubanks wrote: > aeubanks wrote: > > I think we want to insert lifetime intrinsics when optimizing > this will never be called with `Level == OptimizationLevel::O0`, `true` is > good enough Ok. ================ Comment at: llvm/test/Transforms/Inline/always-inline-newpm.ll:1 +; RUN: opt --Os -pass-remarks=inline -S < %s 2>&1 | FileCheck %s +target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128" ---------------- aeubanks wrote: > a better file name is `always-inline-phase-ordering`, legacy PM is deprecated > anyway > > was this file exploding before? Ok I'll rename, this one is demonstrating different/smaller code size with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143624/new/ https://reviews.llvm.org/D143624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
