aemerson added a comment. In D143624#4115986 <https://reviews.llvm.org/D143624#4115986>, @aeubanks wrote:
> __clang_hip_math.hip is annoying... > > We'll need to remove the `MandatoryFirst` inliner in > `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with > that or not > > This isn't quite what I had initially thought, but this might be better. (I > was thinking that we sort the calls in the inliner to visit alwaysinline > calls first, but that might cause more compile time issues since we have to > update the call graph after visiting all the calls in a function, but we > might be visiting every function twice if we first batch process the > alwaysinline calls then all other calls) I think that doesn't actually do the same thing as this, since the `Calls` vector is populated by visiting the functions in the current SCC. What we're trying to do with this patch is to ensure that all always-inline calls globally are processed first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143624/new/ https://reviews.llvm.org/D143624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
