[clang] [AMDGPU] Change the representation of double literals in operands (PR #68740)

rampitec wrote: > I suppose left shift of negative values is undefined because if you shift out > the sign bit you can overflow and get a positive value. https://github.com/llvm/llvm-project/pull/68959 https://github.com/llvm/llvm-project/pull/68740

[clang] 411ceac - [Clang] Fix tautological assertion in `Sema::CheckX86BuiltinTileDuplicate`

Author: Yingwei Zheng Date: 2023-10-13T15:19:35+08:00 New Revision: 411ceacf4351bd3af9db75b859063864b19e71e1 URL: https://github.com/llvm/llvm-project/commit/411ceacf4351bd3af9db75b859063864b19e71e1 DIFF: https://github.com/llvm/llvm-project/commit/411ceacf4351bd3af9db75b859063864b19e71e1.diff

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

nikic wrote: This also breaks the clang standalone build. You need to `include(config-ix)` in order to use `llvm_find_program`. https://github.com/llvm/llvm-project/pull/65650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

antmox wrote: Hi! This commit broke some armv8/armv7 bots: https://lab.llvm.org/buildbot/#/builders/245/builds/15263 https://lab.llvm.org/buildbot/#/builders/187/builds/13069 Int & Void* have the same size there, so no warning on bitfield-width.c:20. https://github.com/llvm/llvm-project/pull/68

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

nikic wrote: Actually no, that's not possible as config-ix modules are explicitly private to their subproject and should not be used outside them. I'm going to revert this change due to this layering violation. https://github.com/llvm/llvm-project/pull/65650 ___

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= Message-ID: In-Reply-To: carlosgalvezp wrote: Friendly ping @AaronBallman @shafik https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] ac32d7b - Revert "Add Documentation for Execution Results Handling in Clang-Repl (#65650)"

Author: Nikita Popov Date: 2023-10-13T09:39:00+02:00 New Revision: ac32d7b87f4d4b546eea96b9b722e88fdb3a5b49 URL: https://github.com/llvm/llvm-project/commit/ac32d7b87f4d4b546eea96b9b722e88fdb3a5b49 DIFF: https://github.com/llvm/llvm-project/commit/ac32d7b87f4d4b546eea96b9b722e88fdb3a5b49.diff

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template instantiations on dema automatic language interoperability. It also helps static languages such as C/C++ become apt for data science. +Execution Results Handling in Clang-Repl +==

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

@@ -64,6 +64,10 @@ C/C++ Language Potentially Breaking Changes ``__has_c_attribute(warn_unused_result)``, 202003, 0 ``__has_c_attribute(gnu::warn_unused_result)``, 202003, 1 +- Fixed a bug in finding matching `operator!=` while adding reveresed `operator=

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

https://github.com/cor3ntin commented: Looks reasonable, but i found a typo https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/68774 >From 67f878a270d159d5d09d1dd029f862443125b511 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Wed, 11 Oct 2023 15:45:36 +0800 Subject: [PATCH] [clang][ASTImporter] Fix crash when template class static member impo

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67095 >From a7c2b5a2834ef6dc345257e8d67caae909abbe20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 22 Sep 2023 08:4

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/68774 >From 99c30605aea8586fca39f3125f49b0bae04e3478 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Wed, 11 Oct 2023 15:45:36 +0800 Subject: [PATCH] [clang][ASTImporter] Fix crash when template class static member impo

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9a8ff346bb20a684e8edd62035077aba06bea084 67f878a270d159d5d09d1dd029f862443125b511 --

[clang] [clang][Interp] Support AddOffset with 128bit offsets (PR #68679)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/68679 >From 8aae860a7079d50e8b3a657335e115c2cca9fcc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 10 Oct 2023 08:52:43 +0200 Subject: [PATCH] [clang][Interp] Support AddOffset with 128bit of

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/68774 >From e45c5e2792563ee8c7d84106fd6860656bac63bc Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Wed, 11 Oct 2023 15:45:36 +0800 Subject: [PATCH] [clang][ASTImporter] Fix crash when template class static member impo

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/68288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

@@ -366,26 +366,50 @@ StringRef ARM::getArchExtFeature(StringRef ArchExt) { } static ARM::FPUKind findDoublePrecisionFPU(ARM::FPUKind InputFPUKind) { + if (InputFPUKind == ARM::FK_INVALID || InputFPUKind == ARM::FK_NONE) +return ARM::FK_INVALID; + + const ARM::FPUName &I

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

vabridgers wrote: > Hi! This commit broke some armv8/armv7 bots: > https://lab.llvm.org/buildbot/#/builders/245/builds/15263 > https://lab.llvm.org/buildbot/#/builders/187/builds/13069 Int & Void* have > the same size there, so no warning on bitfield-width.c:20. I'll revert this change for no

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/68962 The _mm_cmpistri instruction can be used to quickly parse identifiers. With this patch activated, clang pre-processes 1.8% faster, and sqlite3.c amalgametion 1.5% faster, based on time measurements an

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (serge-sans-paille) Changes The _mm_cmpistri instruction can be used to quickly parse identifiers. With this patch activated, clang pre-processes 1.8% faster, and sqlite3.c amalgametion 1.5% faster, based on time measureme

[clang] Revert "[Sema] Add check for bitfield assignments to integral types" (PR #68963)

https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/68963 This reverts commit 47e36266e93de9c34ba3028951a58124864bb2b4. This change broke some arm8/arm7 build bots because int and void * have the same size. >From d431af998d3cf677417f337842e66fa8d13692c8 Mon Sep 17

[clang] Revert "[Sema] Add check for bitfield assignments to integral types" (PR #68963)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (vabridgers) Changes This reverts commit 47e36266e93de9c34ba3028951a58124864bb2b4. This change broke some arm8/arm7 build bots because int and void * have the same size. --- Full diff: https://github.com/llvm/llvm-project/pull/68963

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/68774 >From a0e6d307436ab147bc02db5c38c9453d98379074 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Wed, 11 Oct 2023 15:45:36 +0800 Subject: [PATCH] [clang][ASTImporter] Fix crash when template class static member impo

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/68962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

https://github.com/cor3ntin commented: This is pretty neat. I'm wondering if this change would be tested by any of our bots? https://github.com/llvm/llvm-project/pull/68962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

@@ -1847,19 +1851,46 @@ bool Lexer::LexUnicodeIdentifierStart(Token &Result, uint32_t C, return true; } +static const char *fastParseASCIIIdentifier(const char *CurPtr, const char* BufferEnd) { cor3ntin wrote: ```suggestion static const char *fastParseASC

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9a8ff346bb20a684e8edd62035077aba06bea084 ccf33cafada526241a3fb1aca9c2d280444b589b --

[clang] Revert "[Sema] Add check for bitfield assignments to integral types" (PR #68963)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/68963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To:

[clang] Revert "[Sema] Add check for bitfield assignments to integral types" (PR #68963)

cor3ntin wrote: Original PR - https://github.com/llvm/llvm-project/pull/68276 FYI you do not need to make a PR to revert a change that breaks the build - especially your own https://github.com/llvm/llvm-project/pull/68963 ___ cfe-commits mailing list

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

@@ -1847,19 +1851,46 @@ bool Lexer::LexUnicodeIdentifierStart(Token &Result, uint32_t C, return true; } +static const char *fastParseASCIIIdentifier(const char *CurPtr, const char* BufferEnd) { +#ifdef __SSE4_2__ + static constexpr char AsciiIdentifierRange[16] = { +

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

@@ -420,20 +444,35 @@ bool ARM::appendArchExtFeatures(StringRef CPU, ARM::ArchKind AK, CPU = "generic"; if (ArchExt == "fp" || ArchExt == "fp.dp") { +const ARM::FPUKind DefaultFPU = getDefaultFPU(CPU, AK); ARM::FPUKind FPUKind; if (ArchExt == "fp.dp") { +

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

@@ -420,20 +444,35 @@ bool ARM::appendArchExtFeatures(StringRef CPU, ARM::ArchKind AK, CPU = "generic"; if (ArchExt == "fp" || ArchExt == "fp.dp") { +const ARM::FPUKind DefaultFPU = getDefaultFPU(CPU, AK); ARM::FPUKind FPUKind; if (ArchExt == "fp.dp") { +

[clang] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68900 >From ddbde18e483d12485ba25c715e8a94480b9d6dcf Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Thu, 12 Oct 2023 16:55:22 +0200 Subject: [PATCH 1/3] [mlir][arith] Fix canon pattern for large ints in chained a

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/67572 >From 583b6c3bf838bf74899a1ce5ab53b3722ddb8e66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 6 Sep 2023 13:39:27 +0200 Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2

[clang] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68900 >From ddbde18e483d12485ba25c715e8a94480b9d6dcf Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Thu, 12 Oct 2023 16:55:22 +0200 Subject: [PATCH 1/4] [mlir][arith] Fix canon pattern for large ints in chained a

[clang] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

@@ -39,26 +39,29 @@ using namespace mlir::arith; static IntegerAttr applyToIntegerAttrs(PatternRewriter &builder, Value res, Attribute lhs, Attribute rhs, -function_ref binFn) { - return builder.getIntegerAttr(res.getType(), -

[clang] 2e955c0 - Revert "[Sema] Add check for bitfield assignments to integral types" (#68963)

Author: vabridgers Date: 2023-10-13T05:03:38-05:00 New Revision: 2e955c0504d4cc529e33e0342b60183170b5c815 URL: https://github.com/llvm/llvm-project/commit/2e955c0504d4cc529e33e0342b60183170b5c815 DIFF: https://github.com/llvm/llvm-project/commit/2e955c0504d4cc529e33e0342b60183170b5c815.diff LO

[clang] Revert "[Sema] Add check for bitfield assignments to integral types" (PR #68963)

https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/68963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Sema] Add check for bitfield assignments to integral types" (PR #68963)

vabridgers wrote: > Original PR - #68276 FYI you do not need to make a PR to revert a change that > breaks the build - especially your own revert is merged, thanks for the advice. Best https://github.com/llvm/llvm-project/pull/68963 ___ cfe-commits m

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/68962 >From ccf33cafada526241a3fb1aca9c2d280444b589b Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 12 Oct 2023 22:30:30 +0200 Subject: [PATCH 1/2] [clang] Provide an SSE4.2 implementation of ide

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

@@ -1847,19 +1851,46 @@ bool Lexer::LexUnicodeIdentifierStart(Token &Result, uint32_t C, return true; } +static const char *fastParseASCIIIdentifier(const char *CurPtr, const char* BufferEnd) { +#ifdef __SSE4_2__ + static constexpr char AsciiIdentifierRange[16] = { +

[clang] [clang] Provide an SSE4.2 implementation of identifier token lexer (PR #68962)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/68962 >From ccf33cafada526241a3fb1aca9c2d280444b589b Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 12 Oct 2023 22:30:30 +0200 Subject: [PATCH 1/3] [clang] Provide an SSE4.2 implementation of ide

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922 >From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 12 Oct 2023 21:35:52 +0200 Subject: [PATCH 1/3] Find opertor!= in the correct namespace --- clang/lib/Sema/Se

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

usx95 wrote: > Does this work for function-scope operator declarations? @zygoloid I am not sure I follow. Could you please give an example. If this is about member operator, the search scope is class scope of the first operand. https://github.com/llvm/llvm-project/pull/68922 __

[clang-tools-extra] [MLIR][Presburger] Implement matrix inverse (PR #67382)

@@ -241,6 +245,32 @@ class IntMatrix : public Matrix /// Returns the GCD of the columns of the specified row. MPInt normalizeRow(unsigned row); + // Return the integer inverse of the matrix, leaving the calling object + // unmodified. + std::optional integerInverse(); +

[clang] [MLIR][Presburger] Implement matrix inverse (PR #67382)

@@ -390,4 +463,83 @@ MPInt IntMatrix::normalizeRow(unsigned row, unsigned cols) { MPInt IntMatrix::normalizeRow(unsigned row) { return normalizeRow(row, getNumColumns()); +} + +std::optional IntMatrix::integerInverse() { + Fraction det = Fraction(determinant(), 1); + Frac

[clang-tools-extra] [MLIR][Presburger] Implement matrix inverse (PR #67382)

@@ -283,12 +326,43 @@ template bool Matrix::hasConsistentState() const { return true; } +template +T Matrix::determinant() { + unsigned r = getNumRows(); + unsigned c = getNumColumns(); + if (r == 1) +return at(0, 0); + if (r == 2) +return (at(0, 0) * at(1, 1)

[clang] [MLIR][Presburger] Implement matrix inverse (PR #67382)

https://github.com/Superty requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR][Presburger] Implement matrix inverse (PR #67382)

@@ -390,4 +463,83 @@ MPInt IntMatrix::normalizeRow(unsigned row, unsigned cols) { MPInt IntMatrix::normalizeRow(unsigned row) { return normalizeRow(row, getNumColumns()); +} + +std::optional IntMatrix::integerInverse() { + Fraction det = Fraction(determinant(), 1); + Frac

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

https://github.com/dybv-sc updated https://github.com/llvm/llvm-project/pull/68904 >From eca69cd54e9f2f68d89787376c603164c2508da1 Mon Sep 17 00:00:00 2001 From: Dmitry Bushev Date: Mon, 9 Oct 2023 19:49:09 +0300 Subject: [PATCH] [clang] Add information about lld presence in RISCVToolchain. ---

[clang-tools-extra] [MLIR][Presburger] Implement matrix inverse (PR #67382)

@@ -390,4 +463,83 @@ MPInt IntMatrix::normalizeRow(unsigned row, unsigned cols) { MPInt IntMatrix::normalizeRow(unsigned row) { return normalizeRow(row, getNumColumns()); +} + +std::optional IntMatrix::integerInverse() { + Fraction det = Fraction(determinant(), 1); + Frac

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

SLTozer wrote: > looks good - a few bits should be committed separately from this change, so > please do those first and then commit this change Separate review opened up at: https://github.com/llvm/llvm-project/pull/68967 For simplicity's sake I'll keep this patch as-is, and rebase it when th

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

https://github.com/dybv-sc updated https://github.com/llvm/llvm-project/pull/68904 >From 087d22970d1d2eea6dd0dd79eedd49ed69bc49c3 Mon Sep 17 00:00:00 2001 From: Dmitry Bushev Date: Mon, 9 Oct 2023 19:49:09 +0300 Subject: [PATCH] [clang] Add information about lld presence in RISCVToolchain. ---

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

vgvassilev wrote: > Actually no, that's not possible as config-ix modules are explicitly private > to their subproject and should not be used outside them. I'm going to revert > this change due to this layering violation. @nikic, can you suggest a particular fix? We saw this approach was done

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/68621 From a7425ee9846cd740cf491d23d7afa676767beb18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Mon, 9 Oct 2023 21:28:01 +0200 Subject: [PATCH] [clang-format][NFC] Annotate co

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template instantiations on dema automatic language interoperability. It also helps static languages such as C/C++ become apt for data science. +Execution Results Handling in Clang-Repl +==

[clang] [clang-format][NFC] Annotate control statement r_braces (PR #68621)

@@ -2756,6 +2756,10 @@ FormatToken *UnwrappedLineParser::parseIfThenElse(IfStmtKind *IfKind, CompoundStatementIndenter Indenter(this, Style, Line->Level); parseBlock(/*MustBeDeclaration=*/false, /*AddLevels=*/1u, /*MunchSemi=*/true, KeepIfBraces, &IfBloc

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

https://github.com/yxsamliu approved this pull request. LGTM. Thanks https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

AaronBallman wrote: > (Was out of town...) > > As mentioned at [#67360 > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374) > , I think a default error is probably not appropriate. A priority value <= > 100 may compete with a runtime `__attribute__((constructo

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

AaronBallman wrote: > (Was out of town...) > > As mentioned at [#67360 > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374) > , I think a default error is probably not appropriate. A priority value <= > 100 may compete with a runtime `__attribute__((constructo

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template instantiations on dema automatic language interoperability. It also helps static languages such as C/C++ become apt for data science. +Execution Results Handling in Clang-Repl +==

[clang] [ARM] fix "+fp.dp" in multilib selection (PR #67412)

https://github.com/domin144 updated https://github.com/llvm/llvm-project/pull/67412 From 4cc2328982cc8260263aa803f2b02bff7d7b4a85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20W=C3=B3jt?= Date: Wed, 20 Sep 2023 16:39:27 +0200 Subject: [PATCH 1/2] [ARM] fix "+fp.dp" in multilib selection W

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

nikic wrote: You probably should just use find_program instead of llvm_find_program. It looks like llvm_find_program is used in just a single place, while we have very wide direct use of find_program, so I'm not sure why it is a thing in the first place. https://github.com/llvm/llvm-project/p

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

thakis added a comment. FWIW, the standard procedure for adding new functionality to existing warnings is (assuming that it makes the warning fire a lot, else no extra group is needed): - Add it in a subgroup with its own flag - Enable it by default The reasoning is that people who aren't read

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

dybv-sc wrote: Encountered code formatting check failure seems to be not reproducible locally: ``` $ git-clang-format --diff 7025ff6fa3dfe2ce8d3d7fcb0ec9de9a357d2c6f 087d22970d1d2eea6dd0dd79eedd49ed69bc49c3 -- clang/lib/Driver/ToolChains/RISCVToolchain.cpp clang/lib/Driver/ToolChains/RISCVToo

[clang] [MSVC, ARM64] Add __prefetch intrinsic (PR #67174)

https://github.com/nico approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/67174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

https://github.com/dybv-sc updated https://github.com/llvm/llvm-project/pull/68904 >From 0802a4170b6eddd1ae5bd532f90274794b0e00c4 Mon Sep 17 00:00:00 2001 From: Dmitry Bushev Date: Mon, 9 Oct 2023 19:49:09 +0300 Subject: [PATCH] [clang] Add information about lld presence in RISCVToolchain. ---

[clang] [AArch64] Stack probing for dynamic allocas in SelectionDAG (PR #66525)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5d35273a32d239b7407338e13ed71b59174d6536 e32ff3b92cbbf074567d6d04f7ec5c1f3b9b27a5 --

[clang] 3efa479 - [clang][Interp] Support AddOffset with 128bit offsets (#68679)

Author: Timm Baeder Date: 2023-10-13T14:47:46+02:00 New Revision: 3efa4794ecd5ca6235f9f7e3fc83a8d9e59b66c9 URL: https://github.com/llvm/llvm-project/commit/3efa4794ecd5ca6235f9f7e3fc83a8d9e59b66c9 DIFF: https://github.com/llvm/llvm-project/commit/3efa4794ecd5ca6235f9f7e3fc83a8d9e59b66c9.diff L

[clang] [clang][Interp] Support AddOffset with 128bit offsets (PR #68679)

https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/68679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASAN] Adjust asan instrumented GlobalVariable size to not include redzone (PR #66666)

hctim wrote: My assumption is that you have some driver code or preloaded DSO that effectively implements `copy_to_amdgpu`, which would do something with the symtab. Can you just make your driver not be asan-ified (either by not building it with `-fsanitize=address` or using `__attribute__((n

[clang] [AArch64] Stack probing for function prologues (PR #66524)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8d59fc5fd1599bd7153817d2af903ae9a6103343 7b66d75f43bfd4e52f48307e9fcc2992eefb8bdd --

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading. (PR #68986)

https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/68986 - [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7) - Clone function-local types after metadata loading. This is a follow-up for https://reviews.llvm.org/D144006, fixing a

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156565/new/ https://reviews.llvm.org/D156565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Only emit function_param_value_unknown in C++11 (PR #67990)

AaronBallman wrote: > https://reviews.llvm.org/D156565 hasn't been merged as far as I can tell and > it's the only test case I have for this. :( Ah shoot, let me ping that review and see if I can get it accepted and landed so we can have test coverage. https://github.com/llvm/llvm-project/pul

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading. (PR #68986)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes - [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7) - Clone function-local types after metadata loading. This is a follow-up for https://reviews.llvm.org/D1440

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading. (PR #68986)

https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/68986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading. (PR #68986)

https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/68986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4651955 , @hans wrote: > We're hitting an assert after this change: > > llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2331: > virtual void llvm::DwarfDebug::endFunctionImpl(const llvm::MachineFunction > *): > Ass

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

@@ -100,12 +100,13 @@ template class IntegralAP final { } static IntegralAP from(const Boolean &B) { assert(false); -return IntegralAP::zero(); +return IntegralAP::zero(1); } - static IntegralAP zero() { -assert(false); -return IntegralAP(0); + s

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

@@ -100,12 +100,13 @@ template class IntegralAP final { } static IntegralAP from(const Boolean &B) { assert(false); -return IntegralAP::zero(); +return IntegralAP::zero(1); AaronBallman wrote: Ah, please add FIXME comments to unimplemented stu

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading. (PR #68986)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3efa4794ecd5ca6235f9f7e3fc83a8d9e59b66c9 5012fac53513949a3e1987e0d6cc4695ac5dbd69 --

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

https://github.com/AaronBallman approved this pull request. Aside from nits, this LGTM. https://github.com/llvm/llvm-project/pull/68081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68908)

@@ -9716,13 +9716,16 @@ Value *CodeGenFunction::EmitSMELdrStr(const SVETypeFlags &TypeFlags, if (Ops.size() == 3) { Function *Cntsb = CGM.getIntrinsic(Intrinsic::aarch64_sme_cntsb); llvm::Value *CntsbCall = Builder.CreateCall(Cntsb, {}, "svlb"); -llvm::Value *Mul

[clang-tools-extra] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

erichkeane wrote: > > (Was out of town...) > > As mentioned at [#67360 > > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374) > > , I think a default error is probably not appropriate. A priority value <= > > 100 may compete with a runtime `__attribute__((const

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

erichkeane wrote: > > (Was out of town...) > > As mentioned at [#67360 > > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374) > > , I think a default error is probably not appropriate. A priority value <= > > 100 may compete with a runtime `__attribute__((const

[clang] Let clang-cl support CUDA/HIP (PR #68921)

yxsamliu wrote: The main objective is to make porting cmake files easier. Without it, you have to use clang-cl.exe to compile C++ and clang.exe to compile HIP since the options are not compatible. Now you can use clang-cl.exe to compile both, which accepts both MSVC options and clang options.

[clang-tools-extra] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

AaronBallman wrote: > > > (Was out of town...) > > > As mentioned at [#67360 > > > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374) > > > , I think a default error is probably not appropriate. A priority value > > > <= 100 may compete with a runtime `__attrib

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

AaronBallman wrote: > > > (Was out of town...) > > > As mentioned at [#67360 > > > (comment)](https://github.com/llvm/llvm-project/pull/67360#issuecomment-1736187374) > > > , I think a default error is probably not appropriate. A priority value > > > <= 100 may compete with a runtime `__attrib

[clang-tools-extra] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

erichkeane wrote: I missed the compiler-rt bit there, thats a real shame, this is a really valueable patch that I'd hope someone would take up. While "GCC Doesnt Error" isn't particularly compelling and we SHOULD be better than that, I'd also prefer not throwing the baby out with the bath wat

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

erichkeane wrote: I missed the compiler-rt bit there, thats a real shame, this is a really valueable patch that I'd hope someone would take up. While "GCC Doesnt Error" isn't particularly compelling and we SHOULD be better than that, I'd also prefer not throwing the baby out with the bath wat

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67673)

Endilll wrote: If Aaron weren't able to fix this in several commits, I'm not sure it's a `good first issue`. https://github.com/llvm/llvm-project/pull/67673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [analyzer][NFC] Simplifications in ArrayBoundV2 (PR #67572)

https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/67572 >From 7bd280e2da3f2ee8fe5fd7086a4704331f21b435 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 6 Sep 2023 13:39:27 +0200 Subject: [PATCH] [analyzer][NFC] Simplifications in ArrayBoundV2

[clang] [clang][AArch64] Pass down stack clash protection options to LLVM/Backend (PR #68993)

https://github.com/momchil-velikov created https://github.com/llvm/llvm-project/pull/68993 None >From 870650ae6e2c5b7f34c4d0b1572c5f6a88b6e9b6 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Mon, 2 Oct 2023 14:46:27 +0100 Subject: [PATCH 1/2] [CFIFixup] Allow function prologues to span mo

  1   2   3   >